c4c3124d34
settings: Indent organization permissions checkboxes.
2017-07-05 17:50:04 -07:00
bd23e0a62b
settings: Change bot settings top text to a tip.
2017-07-05 17:45:59 -07:00
62cc8b658e
settings: Change stream list top text to a tip.
2017-07-05 17:45:52 -07:00
1b616d761e
settings: Fix email input whitespace issue.
...
This fixes the issue where the email has whitespace potentially in the
input due to the HTML formatting.
2017-07-05 17:45:30 -07:00
efc2df168c
subs: Fix the autocomplete suggestions while adding subscribers.
...
Earlier, the autocomplete was also showing the emails of the users who
were already subscribed to the stream.
Fixes : #4028 .
2017-07-05 13:22:07 -07:00
598535717b
emoji_picker: Extract `add_scrollbar()` function.
...
Calling this function with an element will cause a `perfectScrollbar` to
be added to it.
2017-07-05 13:14:40 -07:00
a6cd460f72
emoji: Rename `emoji.realm_emojis` to `emoji.all_realm_emojis`.
2017-07-05 13:02:41 -07:00
29ff36cd2a
reactions: Don't send add/remove requests for deactivated realm emojis.
...
Eventually, we'll want to support unreacting to deactivated realm
emoji, but for now the issues around name conflicts mean we can't
really support that.
2017-07-05 13:02:20 -07:00
c4ec9523fc
frontend: Make sure deactivated emojis don't appear for use anywhere.
...
Deactivated emojis should not appear at any of the following places for
use:
1: Emoji pickers.
2: Composebox autocomplete.
3: Custom emoji settings page.
2017-07-05 13:00:14 -07:00
9e40f063d6
markdown: Use `active_realm_emojis` instead of `realm_emojis`.
...
We should use `active_realm_emojis` instead of manually checking for
deactivated emojis in `realm_emoji` dict.
2017-07-05 12:05:10 -07:00
90f04062e7
emoji.js: Add `active_realm_emojis` dict.
...
This dict will hold all the realm emojis which have not been deactivated.
2017-07-05 12:05:10 -07:00
9b279072df
notifications.js: Use the singular 'they' pronoun.
2017-07-05 09:27:44 -07:00
5a3d3ae291
narrow.js: Use the singular 'they' pronoun.
2017-07-05 09:27:43 -07:00
77dc5df56a
uploads: Display year in attachments UI upload timestamp.
...
Modified timerender.js absolute_time() to include the
year in the returned time stamp string.
Fixes #5600 .
2017-07-04 16:13:20 -07:00
98847937f4
realm: add mandatory topic setting on org level.
...
Lets organizations require users to specify a topic the discussion.
Fixes : #5164 .
2017-07-04 14:09:21 -07:00
b13265d135
util: Remove execute_early.
...
This function was removed in favor of loading everything in
ui_init.js. The asynchronous nature of jQuery 3 document-ready
events may cause an undesirable order in which these are executed.
2017-07-04 13:54:33 -07:00
effd7ef41f
server_events: Move initialization to ui_init.js.
2017-07-04 13:54:33 -07:00
e33b178054
message_store: Move initialization to ui_init.js.
2017-07-04 13:54:33 -07:00
25be3a402d
message_fetch: Move initialization to ui_init.js.
...
This involves modifying a casper test, because now
upon registration, there is one unread message.
2017-07-04 13:54:33 -07:00
7d005919ca
portico: Improve detection of URL in product page JS.
...
The product page JS detects the page to run small bundle functions
but does not work correctly with language prefixes in the pathname,
such as /es/apps, so this properly detects that.
Fixes #5635 .
2017-07-03 10:22:38 -07:00
d3d6712fa3
left-sidebar: Update the size of the scrollbar after narrowing to a stream.
2017-07-03 09:53:41 -07:00
30c7629212
Change code block typeahead to only sometimes close fence.
...
Fixes #5556 .
Some tests needed to be moved around to make sure the
stubbing wouldn't break future tests.
2017-07-03 11:05:18 -04:00
802ea9abf5
Refactor to delete mousewheel.js.
...
This old third party library added support
for a "mousewheel" event to detect scrolling.
However, it is not compatible with jQuery 3
and is obsolete now that there is a standard
"wheel" event that accomplishes the same thing.
2017-07-03 11:04:20 -04:00
90ec20b4e4
Remove English translations.json from source control.
...
This commit deletes the file from git repo and adds the
file to gitignore.
Fixes #5640
2017-07-03 10:10:43 -04:00
f848ffc03b
Patch spectrum.js for jQuery 3 compatibility.
...
This includes removing deprecated functions
(namely bind/unbind/delegate) and fix an aspect
of event handling that breaks in the new jQuery.
2017-07-02 07:59:24 -04:00
10fa6b75f9
Patch filedrop for jQuery 3 compatibility.
...
This entails removing the use of jQuery.event.props,
which has been removed from jQuery 3.
2017-07-02 07:59:24 -04:00
4cb8ac100a
emoji: Fix the title and alt text for unicode emojis.
...
Unicode emojis when rendered should display canonical short name.
Similarly, the alt text should be of the format `:<short_name>:`.
For both of these we currently display the actual unicode symbol.
As some systems don't have the fonts necessary for displaying them
properly, they are rendered as empty square blocks. This commit also
ensures that the markup generated for emoji generated by canonical
name and by an unicode emoji is same.
Fixes : #5555 .
2017-07-01 11:14:24 -07:00
8abbb6d781
search: Remove in:all token from suggestions.
2017-07-01 12:19:52 -04:00
0f4b7496e1
Use _.each to set page_params values for update_dict events.
2017-07-01 08:50:50 -04:00
28ec32d757
compose.js: Use get_subscriber_count in show_all_everyone_warning().
2017-06-30 19:57:14 +05:30
4f33a650af
i18n: Use double lowdash instead of handlebars.
...
We do not allow handlebars within {{#tr}}{{/tr}}.
2017-06-30 10:12:31 -04:00
ef815e9e79
Remove unused channel.abort_all().
2017-06-30 09:48:04 -04:00
2be5046144
compose.js: Use stream_data.get_subscriber_count in message mentions.
...
In this commit we basically start using the get_subscriber_count
function from stream data to get subscriber count.
2017-06-29 10:34:47 -04:00
7531a85c4d
stream_data: Add get_subscriber_count() function.
2017-06-29 10:34:47 -04:00
7a0387e0b1
compose.js: Add return true for subscribed streams.
...
This is basically going to fix a regression which was introduced in
89090cd
2017-06-29 18:02:25 +05:30
12b124ba71
single_message.handlerbars: Use __starred_status__ in tooltip.
...
We do not allow handlerbars within tranlation tags. To use variables in
translatable strings, enclose variables with double lowdashes.
2017-06-29 07:39:20 -04:00
d44c62e894
update_starred: Make the status translatable.
2017-06-29 07:39:20 -04:00
8921496ccc
message_list_view: Add starred_status to message objs.
...
This starred_status property can be used to provide the context in
the single_message.handlebars template to show the proper tooltip.
2017-06-29 07:39:20 -04:00
9b75daaa60
Extract reactions.view.remove_reaction().
2017-06-29 07:19:52 -04:00
e2ae4aeb16
Extract reactions.view.update_existing_reaction().
2017-06-29 07:19:52 -04:00
8cf6ef95b1
Extract reactions.view.insert_new_reaction().
2017-06-29 07:19:52 -04:00
791e489938
Use a proper context in insert_new_reaction().
...
Before this change, we were piggybacking fields on to the event
object, which coupled us to any other function that relies on
the event.
2017-06-29 07:19:52 -04:00
84b52661bb
compose.js: Remove small piece of dead code.
...
In this commit we remove a small piece of dead code from
check_stream_for_send() function and also rename it to
check_unsubscribed_stream_for_send() which makes more sense.
2017-06-28 07:45:21 -04:00
89090cd3af
compose.js: Refactor validate_stream_message_address_info().
...
In this commit we just refactor validate_stream_message_address_info
function to early return in case of stream_data.is_subscribed()
returns true.
2017-06-28 07:45:21 -04:00
eec9a9babb
compose.js: Export validate_stream_message_address_info().
2017-06-28 07:45:21 -04:00
69e8e06104
stream-popover: Remove overlapping of chevron and the scrollbar.
...
- Move the chevron and the message count a bit towards
left.
- Make changes in the position of message count in
global_filters to align it with of message count in
stream_filters.
This fixes the overlapping of stream popover with the
scrollbar in the stream list.
Fixes : #5552 .
2017-06-28 06:55:31 -04:00
efa1cf6fb5
subs: Fix the traceback when an user subscribes/unsubscribes.
...
On receiving a `peer_add`/`peer_remove` event we were performing a
subscribers list re-rendering even when the stream settings form was
not open which was causing a traceback. This commit fixes this behavior
by first checking if the corresponding stream settings form is open and
performs a re-rendering only when it is open.
2017-06-27 16:23:00 -04:00
ac64ee355d
compose_actions.js: Allow compose to empty narrow.
...
This allows r/enter hotkeys to compose to
an empty narrow (no messages).
Fixes #4500 .
2017-06-27 14:06:59 -04:00
c4914eeec9
narrow.js: Create narrowed_by_stream_reply().
...
This function returns if you are narrowed
to a stream.
2017-06-27 14:06:59 -04:00
1324596cdd
docs: Document /streams/{stream_id} API endpoint.
2017-06-27 08:33:56 -04:00
Brock Whittaker
Harshit Bansal
Vaida Plankyte
David Coleman
Franziska von der Goltz
Cory Lynch
Umair Khan
Steve Howell
Aditya Bansal
tejaskasetty
Joshua Pan
Yago González