4871b48bf2
node tests: Add tests for stream() and topic() in narrow_state.
2017-11-29 09:39:43 -08:00
4a0c372de4
get_user_group_from_name: Remove existence check.
...
Using user_group_name_dict.get() will return `undefined`.
`blueslip.error` statement caused an exception notification to the
admins.
Tweaked by tabbott to add a test for a nonexistent group.
2017-11-29 09:36:04 -08:00
191f8f1b39
left sidebar: Change Home to All messages.
...
We made this change because users often unnecessarily click "Home"
first in their use of Zulip, because it seems appealing. While "All
messages" isn't quite precise (it doesn't include muted streams), it
does describe relatively simply the interleaved view that this
represents.
This commit leaves everything as "home" in the code, and only changes
user-visible strings and docs. Changing the code will be a big project;
there are hundreds of relevant occurrences in variable names, etc.
Further, we'll probably want to convert those various variable names
in different ways.
Tweaked by tabbott to extend the commit message and update a few comments.
2017-11-28 15:42:58 -08:00
6e22847548
refactor: new message content -> compose textarea.
2017-11-28 12:53:40 -08:00
b9826e9067
Add filters for toMarkdown to paste data to compose-box.
...
This fixes bugs with pasting headings and italic styling.
Fixes #7485 .
2017-11-28 09:56:48 -08:00
29e9d16ac7
refactor: s/upload-bar/compose-upload-bar.
2017-11-27 21:35:14 -08:00
6a694418b2
refactor: s/error-msg/compose-error-msg.
2017-11-27 21:35:14 -08:00
b9c2f479d3
refactor: s/send-status-close/compose-send-status-close.
2017-11-27 21:35:14 -08:00
c0c58f9761
refactor: s/send-status/compose-send-status.
2017-11-27 21:35:14 -08:00
19b518c801
refactor: Extract tests for upload mechanics.
...
This temporarily removes the tests for clear_out_file_list since
fixing that test proved to be difficult.
2017-11-27 21:34:55 -08:00
ddaff4cd2a
refactor: Extract upload mechanics to new JS module.
...
Tweaked by tabbott to move changes from the next commit that are
required for this to pass tests into this commit.
Note that this exports a few items that were not previously exported.
2017-11-27 21:31:51 -08:00
83149a953a
copy paste: Turn off toMarkdown in production.
...
At least until some of the TODOs at the bottom of
node_tests/copy_and_paste.js are done.
2017-11-27 16:44:16 -08:00
3fcfcd2a55
copy paste: Add toMarkdown test for `1. text`.
2017-11-27 16:44:16 -08:00
8082780853
typeahead: Update @mention to not autocomplete "@ " (@space).
...
Tweaked by tabbott to also cover "@** ".
Fixes #7533 .
2017-11-27 15:15:56 -08:00
025b8c19ae
Simplify code to warn about private stream links.
...
This change does a few things:
* I use "early return" to make the code a bit flatter
and easier to comment.
* I added more comments.
* I removed some unneeded passing of `invite_only` into
the template.
2017-11-27 10:41:10 -08:00
e74118e730
tests: Improve templates.compose_private_stream_alert() test.
...
I assert that the stream_name gets properly placed into the HTML.
2017-11-27 10:41:10 -08:00
8f190e0746
user-groups: Update marked.js to do proper local echo for mentions.
...
We implement markdown in the JS as well to improve the
usability. Comes complete withunit tests.
Fixes #7381 .
2017-11-27 09:16:09 -08:00
90994bccac
user-groups: Recognize single asterisk for group mentions.
...
The character combination of @* now begins a group mention, so
this test is no longer valid.
2017-11-27 09:16:09 -08:00
c78846a274
markdown.js: Add error function to blueslip.
...
If we do not add this, we get an exception before we reach the
assertion.
2017-11-27 09:08:30 -08:00
1d826ae201
composebox: Warn when linked to private streams.
...
Fix issue #6860
2017-11-27 07:41:59 -08:00
5e23bfa779
typeahead: show typeahead for syntax of the from @**... or #**...
...
Fixes : #7494 .
2017-11-26 11:18:47 -08:00
0f8ee343de
node: Fix copy_and_paste test output.
...
I'm confused how this was passing when I tested previously.
2017-11-23 14:18:28 -08:00
cc8c8ab21c
node: Fix style in copy-paste test.
...
This bug got merged due to a problem with Travis CI.
2017-11-23 13:06:17 -08:00
4d4532a27e
copy_and_paste: Add a simple extensible test suite.
...
This commit is mostly about adding the test suite; some of the results
are things we'd like to change.
2017-11-23 12:59:01 -08:00
15501c8b07
lint: Clean up json_rules logic for tab-based whitespace.
...
This both improves the comment to be more readable, and also uses the
new and improved exclude feature to limit the exclusion to just the
webhook fixtures (where it's needed).
Also fixes a mypy error.
2017-11-23 12:01:20 -08:00
f70b36a5a9
12-toggle-message-editing: Add wait before flaky test.
2017-11-23 10:43:42 -08:00
9fa58a3c16
compose_ui: Automatically resize textarea after adding new syntax.
...
This fixes existing problems as well as an upcoming problem that
copy-and-pasting in markdown should usually expand the compose text
area.
2017-11-21 19:52:47 -08:00
34689370cd
settings: Create UI and backend for setting signups stream.
2017-11-21 17:39:51 -08:00
bff736868e
Generate custom-icon-webfont on each provision or update-prod-static.
...
Fixes #7354 .
2017-11-20 16:36:49 -08:00
73e4d647c7
casper: Add a few more explicit waits to message editing tests.
...
This is a second attempt at fixing a casper test flake we've been
having recently.
2017-11-20 16:18:34 -08:00
c7f47f5477
casper: Use casper.then() more consistently in editing tests.
...
Hopefully, this will fix the test flake problems we've been having
with this test since upgrading Casper.
2017-11-20 16:04:26 -08:00
8a4fc9970f
reactions.js: Migrate webapp to use the new reactions API.
...
Fixes : #6909 .
2017-11-20 15:27:20 -08:00
fa0fb9e299
casper: Switch to use a newer casper off master.
...
Newer casper should fix some problems we've had with contenteditable.
2017-11-16 22:20:38 -08:00
7072fa5b37
docs: Reorganize developer docs to improve navigation.
...
This commit helps reduce clutter on the navigation sidebar.
Creates new directories and moves relevant files into them.
Modifies index.rst, symlinks, and image paths accordingly.
This commit also enables expandable/collapsible navigation items,
renames files in docs/development and docs/production,
modifies /tools/test-documentation so that it overrides a theme setting,
Also updates links to other docs, file paths in the codebase that point
to developer documents, and files that should be excluded from lint tests.
Note that this commit does not update direct links to
zulip.readthedocs.io in the codebase; those will be resolved in an
upcoming follow-up commit (it'll be easier to verify all the links
once this is merged and ReadTheDocs is updated).
Fixes #5265 .
2017-11-16 09:45:08 -08:00
ce62abce73
dark-mode: Add "T" hotkey for dark mode theme.
2017-11-15 16:45:34 -08:00
b31917be1d
frontend: Remove redundant stream separator in the left sidebar.
...
In the case of no 'normal' streams (only pinned and dormant ones) there are two separators
between the groups of streams. My commit removes one.
2017-11-15 10:06:25 -08:00
940ca17c46
hotkeys: Expand collapsed sidebars when sidebar searches are initiated.
...
Fixes #7351 .
2017-11-14 11:12:13 -08:00
7e2b452f6a
user-groups: Add composebox_typeahead tests.
2017-11-13 11:43:16 -08:00
597a6e6c74
user-groups: Add user groups in typeahead code.
2017-11-13 11:42:17 -08:00
0b800b0a7d
icons: Create framework for custom icons and add new bot icon.
2017-11-10 11:18:42 -08:00
d7254a0556
Append space as needed in compose_ui.smart_insert().
2017-11-09 09:49:20 -08:00
f935afa241
Prepend space as needed in compose_ui.smart_insert().
2017-11-09 09:49:20 -08:00
1b1858aa64
node tests: Test compose_ui.smart_insert().
2017-11-09 09:49:20 -08:00
12dc567a89
Move insert_syntax_and_focus() to compose_ui.js.
...
This change also removes a couple lines of test code that
weren't really testing anything.
2017-11-09 09:49:20 -08:00
19bc55aa45
Fix various typos.
...
The typos and their corrections were found with the
aid of https://github.com/lucasdemarchi/codespell .
2017-11-09 16:26:38 +01:00
c3b89845c9
node tests: Use zrequire in typing_status.js.
2017-11-08 12:24:17 -08:00
0fc20bf943
node tests: Use zrequire in typing_data.js.
2017-11-08 12:24:17 -08:00
c32f69bef6
node tests: Use zrequire in topic_data.js.
2017-11-08 12:24:17 -08:00
1dc5218ef5
node tests: Use zrequire in rtl.js.
2017-11-08 12:24:17 -08:00
f65d3316e0
node tests: Use zrequire in recent_senders.js.
2017-11-08 12:24:17 -08:00
Sivagiri
Umair Khan
Rishi Gupta
Tommy Ip
Garvit
Rohitt Vashishtha
Steve Howell
Rhea Parekh
Shubham Dhama
Tim Abbott
Vishnu Ks
rht
Harshit Bansal
David Rosa Tamsen
Brock Whittaker
Florian Jüngermann
Cynthia Lin
derAnfaenger