Tim Abbott
f806526551
auth: Remove unused request.verified_email variable.
...
This has never been used since it was introduced in the very first
version of our Google auth code in April 2013.
2018-04-22 14:44:06 -07:00
Tim Abbott
fb6cc4cb65
secrets: Make it a bit easier to do GitHub auth in development.
2018-04-22 14:44:05 -07:00
Tim Abbott
b91de0e283
i18n: Pass the name of the single-sign on system into strings.
...
This should avoid us needing to add a new set of translated strings
every time we add a new authentication method.
2018-04-22 13:34:37 -07:00
Utkarsh Patil
955d03b8a0
emoji: Prefix sort for emojis.
...
Emoji prefix sort for "popular emojis first". Fixes #7625 .
2018-04-21 22:28:45 -07:00
Utkarsh Patil
59f5af6b62
emoji: Export popular emojis list.
...
Provisions to export popular emojis list.
2018-04-21 22:24:07 -07:00
Cynthia Lin
ff88712db8
portico: Fix broken mobile responsive design on Plans page.
2018-04-21 22:15:56 -07:00
Cynthia Lin
323e2faac8
css: Change `*-device-width` to `*-width` selectors.
...
See https://stackoverflow.com/questions/18500836/should-i-use-max-device-width-or-max-width
for an explanation on why this isn't optimal.
2018-04-21 22:15:56 -07:00
Eeshan Garg
ca5ea20ab7
doc tests: Add portico pages to tools/test-help-documentation.
...
Fixes #9117 .
2018-04-21 21:51:32 -07:00
Tim Abbott
f90b765824
docs: Document what's involved in doing your own push notifications.
...
We've had a few folks ask about this recently, and it seemed like it'd
be good to cover this a bit more explicitly.
2018-04-21 21:42:24 -07:00
Priyank Patel
55ff9a6806
quick fix: Revert ES6 idiom that istanbul warns about.
2018-04-20 16:33:33 -07:00
Shubham Dhama
26d2ffa821
populate_db: Add new user of "guest" type.
...
The purpose of this user is to act as a guest.
(This is a preliminary step in adding the guest type of user
and is a part of #8385.)
2018-04-20 16:20:00 -07:00
Shubham Dhama
1191f1730a
guest: Add a model field for guest users.
...
This adds new field `is_guest` to UserProfile model and
is meant for the new type of user i.e. "Guest Users".
(Part of #8385 ).
2018-04-20 16:08:29 -07:00
Steve Howell
5f53fb1561
refactor: Remove factory code for toggle component.
...
We now have components.toggle simply return an object, without
putting the object into a lookup table. The consumers of the
objects have all been changed to just store the object in their
own module scope.
The diff is a bit hard to read here, but it's mostly de-denting
code and removing these things:
- we don't have opts.name
- we don't have __toggle.lookup
- we don't have keys
- we don't create a sibling object to the prototype object
2018-04-20 13:45:58 -07:00
Steve Howell
f73bfd2a5c
refactor: Extract settings_toggle.js.
...
This mostly moves code, and we also abandon the lookup mechanism
for finding our toggler.
2018-04-20 13:45:58 -07:00
Priyank
02dddd6b35
node_test: Use let/const instead of var in activity.js.
...
This was left in previous cleanup.
2018-04-20 15:46:28 -04:00
Priyank
2dd2ab4f7e
node_tests: Update alert_words.js to use es6.
2018-04-20 15:46:28 -04:00
Priyank
3174827f93
node_tests: Update channel.js to use es6.
2018-04-20 15:46:28 -04:00
Priyank
b1c5f6c07d
node_tests: Update bot_data.js to use es6.
...
bot_data.js uses let/const for variables, and uses rest operator
instead of _.extends.
2018-04-20 15:46:28 -04:00
Priyank
6c8753ef25
eslint: Update eslint config to have es6 env.
...
This will allow us to use spread operator.
2018-04-20 15:46:28 -04:00
Rishi Gupta
6c8a266119
portico: Update meta tags.
2018-04-20 12:13:50 -07:00
Tim Abbott
49f58583a4
models: Introduce can_access_public_streams field.
...
This is a simple computed field. It's intended to more clearly
capture the meaning of this restriction for the users in zephyr mirror
realms, and eventually support guest user accounts in normal Zulip
realms.
2018-04-20 12:06:57 -07:00
Tim Abbott
dc6d7d0d12
actions: Use presence_disabled for presence zephyr_mirror code path.
...
This is part of the effort to remove the use of is_zephyr_mirror_realm
across the code path for situations that might be relevant for other
users. It helps keep the code readable.
2018-04-20 12:06:57 -07:00
Tim Abbott
09f995e966
left sidebar: Fix clipping of private message users with "g" in name.
...
This fixes an issue where users whose names had a "g" in them would
have the "g" clipped in the "private messages" section in the left sidebar.
We avoid a change in the effective visible line-height by shrinking
the margin.
2018-04-20 11:28:18 -07:00
Tim Abbott
7ef23a0139
slack import: Document how to send password resets to all users.
...
This is likely to be an important follow-up step after one finishes
the Slack import.
2018-04-20 10:56:06 -07:00
Tim Abbott
7e91e66987
import: Fix ordering of subdomain availability check.
...
When you're importing with --destroy-rebuild-database, we need to
check subdomain availability after we've cleared out the database;
otherwise, trying to reuse the same subdomain doesn't work.
2018-04-20 10:39:30 -07:00
Cynthia Lin
0886424ed3
analytics: Eliminate slider-focused text selection in Firefox.
...
Fixes #9151 .
2018-04-20 09:19:43 -07:00
Tim Abbott
360d708340
gitlab: Document the local network security setting.
...
This should help users debug issues with the GitLab webhook not
working with recent GitLab releases.
2018-04-20 08:34:38 -07:00
Tim Abbott
e25d6968a5
docs: Expand documentation on our other test suites.
...
This is long overdue, and I was actually kinda surprised how many of
these we have at this point :).
Fixes #7461 .
2018-04-19 23:49:28 -07:00
Cynthia Lin
d963fd8180
night-mode: Change coloring for compose close button.
2018-04-19 23:04:15 -07:00
Tim Abbott
d1cc442404
compose: Move colorblock CSS to compose.css.
2018-04-19 22:51:25 -07:00
Cynthia Lin
f1db3a681a
compose: Refactor compose box from `<table>` to `<div>` structure.
...
`<td>` elements are fixed-width, so we refactor the entire
`<table>` structure for responsive design.
This fixes a bug with how the `To:` block looks in other languages.
Fixes #9152 .
2018-04-19 22:51:13 -07:00
Akash Nimare
1a124ad865
portico: Add open graph and twitter meta tags to all pages.
...
This PR adds few basic meta tags which are required for a better SEO.
Fixes : #8255 .
2018-04-19 22:10:27 -07:00
Roman Godov
d99758129e
subs: Notify organization admins when private streams are renamed.
...
This commit sends the event for renaming of a private stream to
organization admins of the realm, in addition to the obvious list of
subscribers of the private stream.
Normally, admins can manage a private stream (e.g. unsubscribing a
user). But when the admin tried to unsubscribes a user from a
previously renamed stream, we previously were throwing a JS error, as
the webapp hadn't been notified about the new stream name.
Fixes #9034 .
2018-04-19 22:00:18 -07:00
Preston Hansen
e168f9938c
tests: Refactor use of test and webhook data fixtures.
2018-04-19 21:50:29 -07:00
Preston Hansen
76d6c71595
tests: Move zerver/fixtures to zerver/tests/fixtures for clarity.
...
Fixes #9153 .
2018-04-19 21:50:17 -07:00
Shubham Dhama
d0801dd602
settings: Make saving spinner visible in night mode.
...
Fixes : #9154 .
2018-04-19 21:47:04 -07:00
Shubham Dhama
9aa9ed9472
org settings: Refactor code for get_property_value.
...
This just makes the code for getting the property value more readable
and less confusing.
2018-04-19 21:47:04 -07:00
Tim Abbott
a06c7bc247
puppet: Allow manual configuration of postfix_mailname.
...
This allows users to configure a mailname for postfix in
/etc/zulip/zulip.conf
2018-04-19 14:41:05 -07:00
Tim Abbott
62b12e0c34
zulip_ops: Add missing dependency on dhcpcd.
2018-04-19 14:27:48 -07:00
Tim Abbott
e53c0fe273
docs: Further clarify privacy details for push notifications.
2018-04-19 14:20:57 -07:00
Rishi Gupta
3f94a62309
portico: Add contact info to FAQ.
2018-04-19 12:48:27 -07:00
Natalie Totonchy
bc7c3df621
drafts: Fix confusing disconnect between focused element and enter hotkey.
...
The enter hotkey targets the focused message, not the one the user is
hovering over.
Fixes #9093 .
2018-04-19 12:44:03 -07:00
Rohitt Vashishtha
ba21afe9a6
zblueslip: Convert node_tests/people_errors.js to zblueslip.
2018-04-19 15:02:00 -04:00
Rohitt Vashishtha
a836473746
zblueslip: Convert node_tests/compose.js to zblueslip.
2018-04-19 15:02:00 -04:00
Rohitt Vashishtha
25c75b66d3
zblueslip: Convert node_tests/emoji.js to zblueslip.
2018-04-19 15:02:00 -04:00
Rohitt Vashishtha
4738644339
zblueslip: Create zblueslip.js for improved error handling.
...
Adds a basic API for controlling the allowed error messages and
documents the usage in the form of unit tests, similar to zjquery.
Fixes #8675 .
2018-04-19 15:02:00 -04:00
Tarun Kumar
55f830c345
server_events_dispatch: Add node coverage for user groups.
2018-04-19 14:59:08 -04:00
Tarun Kumar
deab3ac541
hash_util: Add 100% node-coverage for hash_util.js.
2018-04-19 14:59:08 -04:00
Shubham Dhama
9c096840be
node tests: Increase coverage for settings_org.
2018-04-19 14:58:12 -04:00
Shubham Dhama
b41a204dbb
org settings: Remove redundant property type from org_permissions object.
...
`add_emoji_by_admins_only` is already covered in
`get_complete_data_for_subsection` function.
2018-04-19 14:58:12 -04:00