Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
48,650 Commits 28 Branches 143 Tags 606 MiB
Commit Graph

7 Commits

Author SHA1 Message Date
Anders Kaseorg c520890f54 node_tests: Remove low-hanging uses of __Rewire__. 
When we were preparing the conversion to ES modules in 2019, the
primary obstacle was that the Node tests extensively relied on the
ability to reach into modules and mutate their CommonJS exports in
order to mock things.  ES module bindings are not mutable, so in
commit 173c9cee42 we added
babel-plugin-rewire-ts as a kludgy transpilation-based workaround for
this to unblock the conversion.

However, babel-plugin-rewire-ts is slow, buggy, nonstandard,
confusing, and unmaintained.  It’s incompatible with running our ES
modules as native ES modules, and prevents us from taking advantage of
modern tools for ES modules.  So we want to excise all use of
__Rewire__ (and the disallow_rewire, override_rewire helper functions
that rely on it) from the tests and remove babel-plugin-rewire-ts.

Commits 64abdc199e and
e17ba5260a (#20730) prepared for this by
letting us see where __Rewire__ is being used.  Now we go through and
remove most of the uses that are easy to remove without modifying the
production code at all.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-07-13 16:27:30 -07:00
Anders Kaseorg 25f6b53e90 docs: Capitalize Handlebars consistently. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-06-27 13:35:10 -07:00
Anders Kaseorg f84a2c08d5 js: Prefix jQuery object variable names with $. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-16 12:52:07 -07:00
Anders Kaseorg 64abdc199e zjsunit: Split deprecated __Rewire__ functionality out of override. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-01-08 10:01:27 -05:00
rht bb8504d925 lint: Fix typos found by codespell. 2021-10-19 16:51:13 -07:00
Dinesh 55512a4247 node_tests: Rewrite example8.js. 
The previous code has a lot of code unrelated to mock_template.
So, this commit replaces it with a better example which also
demonstrates how to test conditionals in templates.
 2021-10-07 16:32:08 -07:00
Dinesh 74206acbfd node_tests: Add a mock_template example test. 2021-07-22 09:47:47 -04:00