zulip

Commit Graph

Author	SHA1	Message	Date
Prakhar Pratyush	3afc8ed7ae	webhooks: Rename topic local variables to topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use topic as the local variable name for topic names. We rename local variables of the form topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.	2024-01-17 08:35:29 -08:00
Zixuan James Li	4e46899494	webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>	2022-11-08 08:20:51 -08:00
Christopher Chong	5362a6b555	integrations: Add RhodeCode webhook integration. Fixes #19627.	2022-07-13 14:10:00 -07:00

Author

SHA1

Message

Date

Prakhar Pratyush

3afc8ed7ae

webhooks: Rename *topic local variables to *topic_name.

This is preparatory work towards adding a Topic model.
We plan to use the local variable name as 'topic' for
the Topic model objects.

Currently, we use *topic as the local variable name for
topic names.

We rename local variables of the form *topic to *topic_name
so that we don't need to think about type collisions in
individual code paths where we might want to talk about both
Topic objects and strings for the topic name.

2024-01-17 08:35:29 -08:00

Zixuan James Li

4e46899494

webhooks: Pick a more reasonable length for short sha.

7 characters are not enough for large projects, so we change
it to reasonably longer. As an example, The Linux kernel needs
at least 11 characters of sha in its shortened form to identify
a revision. We pick 11 so it should work for most of the projects.

Signed-off-by: Zixuan James Li <p359101898@gmail.com>

2022-11-08 08:20:51 -08:00

Christopher Chong

5362a6b555

integrations: Add RhodeCode webhook integration.

Fixes #19627.

2022-07-13 14:10:00 -07:00

3 Commits