22bb5a5830
Fix longpolling on messages to nobody.
...
This is what caused our server to hang when receiving certain messages
over the last couple days. It was introduced by me making in the
assumption that doing the same thing we did after validate_notify
failed was a correct way to immediately return from
notify_new_message, which it was not. The code of validate_notify
actually finished the handler in the event that validation failed,
which isn't "correct", but did not manifest in a visible problem.
The correct way to trigger an immediate response from a tornado view
is to just return the value, not call handler.finish() and then return
None.
Similarly, the correct way to trigger longpolling from a tornado view
is to either return None (or equivalently, / drop off the end of the
function) or return a generator.
(imported from commit 5b931248b4650fc88d5d68f5936a95f19e097af9)
2012-10-31 16:35:30 -04:00
5a7b307d71
Create the narrowbar using a Handlebars template
...
This fixes an XSS hole (#249 ).
(imported from commit 5f70c0bc23e0d992f2d85889e2ba9157f1b73b3a)
2012-10-31 16:02:17 -04:00
5a3d52baa7
Make the narrowing tooltips a bit more verbose.
...
(imported from commit ab2cbaa7bfe4eeb0b1d1dd00b6db6aa76574cbff)
2012-10-31 14:06:35 -04:00
b33c0c4eee
Send the stripped stream name to add_subscriptions_backend.
...
(imported from commit c3bbb9bd200629020fe7e60d42644beaab30bff5)
2012-10-31 14:06:35 -04:00
f319eef425
humbug_trac: Remove redundant 'Trac ' in subjects.
...
(imported from commit 309b477963cd0d3cca06eef2a685b1143c144455)
2012-10-31 14:06:35 -04:00
31666a1f3d
humbug_trac: Try to compress the rest of the changes.
...
(imported from commit a7bdf3cb8243d43837705d4c9eb00d5e6d75d4b5)
2012-10-31 14:06:35 -04:00
b9c54ed6f2
Include the trac summary in the Humbug subject.
...
(imported from commit 23298d8455e2b0e8c4947f2d2e76874b66a8e28c)
2012-10-31 14:06:35 -04:00
212a4e76d4
zephyr_mirror: Append our elements to the start of sys.path.
...
(imported from commit 674848bcac71d5bd28549f14a5da0f72c6c59d69)
2012-10-31 14:06:35 -04:00
426ab9559d
Fix creating new users via zephyr mirroring.
...
(imported from commit 05e01efabdce081fc574486916c7db343f2cdb1d)
2012-10-31 14:06:35 -04:00
564565f627
When narrowing a second time, don't move the pointer and display the persistent pointer
...
(imported from commit f49222f3a5df636517cadcafbc3d278f4f0ced00)
2012-10-31 12:03:00 -04:00
eac48d9b04
Clear password boxes on settings change submission
...
(imported from commit 523df7ee039db7be30e66608c491cc441f14fd70)
2012-10-30 17:05:10 -04:00
30aab26ccd
Fix test_missing_last_received to match current behavior.
...
(imported from commit 101b08d740ddf46d100c9763f2b78b86e2b07a00)
2012-10-30 16:59:25 -04:00
70f21f9d8e
Fix 'Stream does not exist' test.
...
(imported from commit d4f0f3deaa3cc4b9cab67c90b87aa8bff2e72653)
2012-10-30 16:59:25 -04:00
013a2381b2
zephyr_mirror: More reliable killing of other zephyr_mirror processes.
...
(imported from commit ae00299114a74ebd582aec835ffd5f8127d8f55f)
2012-10-30 16:59:25 -04:00
73f6c614b8
Move trac bot to the trac stream.
...
(imported from commit 7c05062d73d6bd4de4b9329f1f2b7baa705c9d2b)
2012-10-30 16:59:25 -04:00
e48bdfe847
Use json_success for api_fetch_api_key.
...
(imported from commit 395d992fa634f5304f8a44f38f0251109c1a0810)
2012-10-30 16:59:18 -04:00
c00e37c106
Use json_error rather than HttpResponseBadRequest and friends.
...
(imported from commit a9f6df2e561218db46f4ade86bac1ecd87b6ca78)
2012-10-30 16:59:18 -04:00
9fa2f0d4f8
Use @require_post for login_required_json_view.
...
(imported from commit e7efea5f016b1b44a0a3deba024e3df828006cfa)
2012-10-30 16:59:18 -04:00
e7e05d8617
Fix up some overzealous "instance->subject" renames.
...
(imported from commit f4ddcfd3749d374cc6abee3b1e7a5aacc3b83e16)
2012-10-30 16:48:00 -04:00
1b316023af
Add example msmtprc
...
(imported from commit 8fd934f6439b92c0b86e9db3bb56fdbab3e60a14)
2012-10-30 15:40:10 -04:00
8c238f252c
review: Send mail using msmtp
...
(imported from commit 7cf60baeb846df9a8c15500a6d14713aec45fc8c)
2012-10-30 15:40:10 -04:00
5788c4c280
review: Update for python-git 0.3 instead of 0.1 (?)
...
(imported from commit 3e90459bfcf5dbd2f209836bff1a2ad9038f50bb)
2012-10-30 15:40:10 -04:00
d8b8e396a6
review: Customize for humbughq.com
...
(imported from commit f757954077f287a9d3092a7a5a475fd5c0c12a2f)
2012-10-30 15:40:10 -04:00
26115c8232
review: Fix trailing whitespace
...
(imported from commit 6161f378913d3a939655dd903f7fe634e2b170f5)
2012-10-30 15:40:10 -04:00
a7fbb1c15f
Import Ksplice code review script
...
From https://github.com/ksplice/code-review
(imported from commit ff6ca29832749ab8f2f6434eb64395a239031f1c)
2012-10-30 15:40:10 -04:00
75c6fa7202
When doing a deployment, set the site name to app.humbughq.com.
...
(imported from commit b89f72f0cb94fae7678db570a1e9774dbe471ba9)
2012-10-30 15:13:12 -04:00
4e9df28c12
send_message: Don't create streams automatically on send.
...
(imported from commit 7be1b72c5fdf9a21167d2be3948cf1febf8da8ed)
2012-10-30 15:02:45 -04:00
2c577d70b3
Restart apache2, ssh, and nginx after running puppet.
...
(imported from commit 0e0b7fd10d1742efe86ff6bdab8d3ac4e4d291a9)
2012-10-30 14:21:31 -04:00
1d6a5741e0
Previously conditionals used the wrong case to reference request.POST.
...
(imported from commit 2624def3745c3b26114ee1a1a9a20288e078b243)
2012-10-30 13:29:40 -04:00
9f61e27218
Fix broken conditionals in get_old_messages_backend.
...
(imported from commit 13b934cdd2805d45efff18f7ce485b3e17e11c1a)
2012-10-30 13:24:02 -04:00
172a2cf299
Update terms
...
(imported from commit 5009a26db34d9ecda3f8c52c1225e21ec1b1dc7c)
2012-10-30 12:29:29 -04:00
545476c6a4
Puppet: Don't install sudo
...
We're no longer using it, and fewer setuid programs is better.
Fixes #225 .
(imported from commit 68b06bb8afedc0854d96ad072b5de718832932ed)
2012-10-30 12:30:18 -04:00
4a6eafd6bf
Provide the static access control link for the 404 page
...
(imported from commit 3915ff409e1026c35a6d976ed5eea51ba679e0c3)
2012-10-30 11:01:36 -04:00
f0c2421f00
Customize the 404 error page Nginx serves for missing static content
...
(imported from commit 70fc821f9ae29b8a902c48ce57e39273c90f57ff)
2012-10-30 11:00:10 -04:00
7267ba9cd2
Fix test for /accounts/logout
...
(imported from commit 256929fc4d462832358c31c99bd470a23ffaba29)
2012-10-30 00:18:01 -04:00
5bcb522952
Provide a better link for changing Gravatar
...
For users logged in to Gravatar, this goes directly to the page where you
change your avatar. For those not logged in, it's a more directed path to
logging in or signing up, compared to the gravatar.com front page. However
it's less clear why you are signing up for a new thing, so maybe that's bad.
Also this link uses HTTPS; it seems we can't get that without the 'en.' prefix.
(imported from commit e03f97ef5ed2ff6593a9b349176da5fd056c4514)
2012-10-30 00:03:44 -04:00
6a57432133
login.html: Don't autofocus two things
...
(imported from commit 3c3a6977aa261314675912ed472fb92c49cda51c)
2012-10-30 00:03:43 -04:00
233cba1380
Remove old copy of my.cnf
...
This is now found at servers/puppet/files/mysql/my.cnf . It's identical to the
one we remove here.
(imported from commit fe70529a716842a57058386eaf697a23a6d6251c)
2012-10-30 00:03:31 -04:00
9de0d3c7b8
install-server: Add note about hostname domain
...
(imported from commit 1fb9fd79cfc88d7ec191b1116b45e4b7b7bb9c2f)
2012-10-29 23:21:00 -04:00
e9a8d3e447
install-server: Restart sshd after configuring it
...
Needed for disabling password authentication to take effect. Fixes #202 .
(imported from commit f082b08076ecb1f0facb3f66d5b416ea545dfa4f)
2012-10-29 23:21:00 -04:00
044b08b409
Remove more commented out example code
...
(imported from commit 83f7c8763d96af5341fe630d1d8be11eef1f33aa)
2012-10-29 23:21:00 -04:00
270912e582
zephyr_mirror: Remove 'continue' at the end of a loop
...
(imported from commit 5d6143828f1a6946b67ae23342c0bc2185ebee07)
2012-10-29 23:21:00 -04:00
cae174847a
zephyr_mirror: Use a set for current_zephyr_subs
...
(imported from commit 2736ea13dac7d3b5914eac27ed92ddacafd6ee8e)
2012-10-29 23:21:00 -04:00
c99f995782
Update comment in debug.js
...
(imported from commit c23c67331c6433e11e9131f75edce9be52d3ecff)
2012-10-29 23:21:00 -04:00
c8eb1c2464
Remove class="nav-zephyr" on sidebar
...
This became unused in 0a5fe548d4d848c0358c9780df7af1fe1abc93fa.
(imported from commit c3df459f3af7ddd99d2e9dd5adcebf4b0ec0b274)
2012-10-29 23:21:00 -04:00
cce370c7b3
Remove class="zephyr" on new message form
...
This isn't used by our CSS or Javascript, and we're trying to get rid of the
"zephyr" name.
(imported from commit c3cae24168088eef2bb64944d9a1bd1d8be4b59d)
2012-10-29 23:21:00 -04:00
04b6ea1e5b
Drop the next= parameter on logout link
...
The new logout_then_login view does what we wanted anyway.
(imported from commit 334b0f7e384d9d9198e7ec9f5df85bc78ef104db)
2012-10-29 23:21:00 -04:00
0fcf1db00a
Fix tracebacks sending messages nobody will receive.
...
(imported from commit afe3d7465f105015f7fa8247ab3cba7476b89fc2)
2012-10-29 19:17:26 -04:00
9c5136c8cc
zephyr_mirror: Clean up some code duplication.
...
(imported from commit ab21fc28d167d6f74e9d93aa8a7ccb252b5664c2)
2012-10-29 18:57:54 -04:00
45387a8e63
Fix logout view
...
Previously if you hit /accounts/logout with no ?next=... parameter, you would
see a broken version of index.html missing dynamic content.
(imported from commit d9bca92d1c3c82893524ba69b132d59c48aa34c9)
2012-10-29 18:30:01 -04:00
Tim Abbott
Keegan McAllister
Zev Benjamin
Waseem Daher
Luke Faraone
Jeff Arnold