Harshit Bansal
42ac7fa5cc
server_events: Fix the updation code for `add_emoji_by_admins_only`.
...
`add_emoji_by_admins_only` backend setting is represented by page_param's
`realm_add_emoji_by_admins_only` attribute. When this setting was changed
we were wrongly updating the `add_emoji_by_admins_only` attribute which
doesn't exist.
2017-07-13 14:08:30 -07:00
Harshit Bansal
86de196d12
emoji: Don't lock out admins when only admins are allowed to upload emoji.
...
Prior to this, when the setting for controlling whether can admins only
upload an emoji was set to true, we were not displaying upload emoji form
even for admins and as a result they were locked out.
2017-07-13 14:08:30 -07:00
Sarah
db3539438c
test_events: Simplify testing code for bool user settings.
...
Use bool_change if the user_display setting property_type is bool, so that no additional code needs to be added to test_events for new boolean user display settings.
2017-07-13 14:07:54 -07:00
James Rowan
05934fd4c6
user docs: Clarify that drafts are only stored locally.
2017-07-13 11:21:44 -07:00
Cory Lynch
8afdb06e2a
search: Add test case for searching for a link.
...
Fixes #2038
2017-07-13 09:23:34 -07:00
Umair Khan
f94e8530ee
Django 1.11: Remove jinja2 backend.
...
Django 1.11 adds the ability to pass context processors in Jinja2
backend. Django also sends template_rendered signal in tests.
These two issues were the reason why we added Jinja2 backend, but
after upgrading to Django 1.11 we can remove it.
We still need jinja2/__init__.py, which modifies the environment,
and jinja2/compressors.py, which adds minify_js compressor.
2017-07-12 17:53:25 -07:00
Steve Howell
b4bc048993
codecov: Turn off "patch" diffs.
...
These seem to be mostly useless and throw errors in a lot of PRs that
don't touch files where code coverage is relevant.
2017-07-12 17:52:26 -07:00
Vaida
281ca8263d
frontend: Increase contrast of text on login/register pages.
...
Darkened login/register texts: google and github buttons,
login description links, footers.
2017-07-12 17:40:54 -07:00
Tim Abbott
6a914c83ef
docs: Fix indentation of DocPageTest.
2017-07-12 16:28:38 -07:00
Tim Abbott
344af2a7c9
travis: Use a wrapper script for installing moreutils.
...
This works around a frequent problem we've been having with Travis
CI's apt repository being busted on startup. This, in turn, caused
`apt-get install moreutils` to fail.
We attempt to fix this by adding our own retry logic.
2017-07-12 13:43:47 -07:00
Aditya Bansal
6100d43339
test_subs/test_users: Fix breaking tests due to regressions.
2017-07-13 01:56:26 +05:30
Tim Abbott
5acc7506ac
test_users: Fix GetProfileTest to test its original purpose.
...
This test accidentally got refactored to use some test suite library
functions that ended up somewhat defeating its purpose.
2017-07-12 13:03:38 -07:00
Vishnu Ks
63586480a5
test_subs: Replace hamlet@zulip.com with self.example_email('hamlet').
2017-07-12 12:49:12 -07:00
Vishnu Ks
6e133cc77a
test_subs: Eliminate redundant class variable realm.
...
The SubscriptionAPITest class variables `realm` and `test_realm` stores
the same information and are redundant. I have eliminated all occurances
of self.realm and replaced with self.test_realm.
2017-07-13 00:45:24 +05:30
Vishnu Ks
bf729c9a4d
test_classes: Use get_user in notification_bot fcuntion.
2017-07-13 00:45:24 +05:30
Vishnu Ks
f28b29177b
test_classes: Use get_user in mit_user function.
2017-07-13 00:45:24 +05:30
Vishnu Ks
0b701b52df
test_classes: Use get_user in example_user function.
2017-07-13 00:45:24 +05:30
Vishnu Ks
ed0423784d
test_realm_emoji: Replace get_user_profile_by_email.
...
Replace with get_user.
2017-07-13 00:45:24 +05:30
Vishnu Ks
80d0039e2c
test_helpers: Remove unused get_user_profile_by_email import.
2017-07-13 00:45:24 +05:30
Vishnu Ks
ba4ea7dd8a
notifications.py: Replace get_user_profile_by_email.
...
Replace with get_user.
2017-07-13 00:45:24 +05:30
Tim Abbott
ac3e9256bb
frontend: Remove unused sender_name_hovered CSS.
2017-07-11 16:30:34 -07:00
Vaida Plankyte
74ab5b607a
frontend: Change main UI content to not be background images.
2017-07-11 16:30:07 -07:00
Srimukh
b2f105ac7e
landing: Prevent selecting the of X icon in mobile navigation.
...
This prevents accidental selection of the close button (X) of the left
sidebar on mobile landing page.
Fixes #5259 .
2017-07-11 15:35:18 -07:00
Aditya Bansal
de1dc50204
linter/pep8: Remove code infra to ignore the E261 violations.
2017-07-11 15:17:32 -07:00
Aditya Bansal
84e53f960d
pep8: Add compliance with rule E261 to tests/test_upload.py.
2017-07-11 15:17:32 -07:00
Aditya Bansal
1b5e3190e3
pep8: Add compliance with rule E261 to tests/test_subs.py.
2017-07-11 15:17:32 -07:00
Aditya Bansal
2643a40176
pep8: Add compliance with rule E261 to tests/test_signup.py.
2017-07-11 15:17:32 -07:00
Aditya Bansal
59b26e582a
pep8: Add compliance with rule E261 to tests/test_realm.py.
2017-07-11 15:17:32 -07:00
Aditya Bansal
0970d29ec1
pep8: Add compliance with rule E261 to tests/test_narrow.py.
2017-07-11 15:17:32 -07:00
Aditya Bansal
ce70ded488
pep8: Add compliance with rule E261 to tests/test_messages.py.
2017-07-11 15:17:32 -07:00
Aditya Bansal
8c233198f8
pep8: Add compliance with rule E261 to tests/test_events.py.
2017-07-11 15:17:32 -07:00
Aditya Bansal
ee97ea1356
pep8: Add compliance with rule E261 to tests/test_bugdown.py.
2017-07-11 15:17:32 -07:00
Abdul Qabiz
7d7f2f78c8
clean-repo: Optimize .pyc removal code.
...
This optimizes .pyc files removal.
Instead of removing all pyc files, it will only remove pyc files where
corresponding py file is not found. This saves about 1s in the
startup time of `run-dev.py` (and thus also `test-js-with-casper`).
Fixes #5760 .
2017-07-11 14:40:56 -07:00
EdOverflow
86cfed3e81
Update generate_secrets.py
2017-07-11 12:43:46 -07:00
Tim Abbott
f724900e68
install-node: Fix provisioning when node/npm don't exist.
...
Our recent performance changes to this script broke it in the case
where there was no previous version of node/npm installed.
2017-07-11 12:36:35 -07:00
Aditya Bansal
0c4165a5bd
pep8: Add compliance with rule E261 to populate_db.py.
2017-07-11 11:56:50 -07:00
Aditya Bansal
856e005d64
linter_lib/pep8.py: Remove files which don't have E261 conflicts.
2017-07-11 11:55:30 -07:00
Aditya Bansal
d46cf59b0d
pep8: Add compliance with rule E261 to worker/queue_processors.py.
2017-07-11 11:55:02 -07:00
Aditya Bansal
1e3b57570e
pep8: Add compliance with rule E261 to tornado/websocket_client.py.
2017-07-11 11:55:02 -07:00
Aditya Bansal
94b790c28d
pep8: Add compliance with rule E261 to tornado/socket.py.
2017-07-11 11:55:02 -07:00
Aditya Bansal
b9bffaa446
pep8: Add compliance with rule E261 to prod_settings_template.py.
2017-07-11 11:55:01 -07:00
Aditya Bansal
5f87a0f8f8
pep8: Add compliance with rule E261 zproject/settings.py.
2017-07-11 11:53:33 -07:00
Aditya Bansal
7c6ad4a770
pep8: Add compliance with rule E261 zproject/dev_settings.py.
2017-07-11 11:53:33 -07:00
Aditya Bansal
44edab1cff
pep8: Add compliance with rule E261 tools/run-dev.py.
2017-07-11 11:53:33 -07:00
Aditya Bansal
73ad834129
pep8: Add compliance with rule E261 bugdown/__init__.py.
2017-07-11 11:53:33 -07:00
Aditya Bansal
f5d5c48831
pep8: Add compliance with rule E261 models.py.
2017-07-11 11:53:33 -07:00
Vishnu Ks
48617c5915
send_password_reset_email: Replace get_user_profile_by_email with get_user.
2017-07-11 11:48:21 -07:00
Vishnu Ks
aca4d18f23
generate_invite_links: Replace get_user_profile_by_email with get_user.
...
The extra refactoring is because the realm is made a compulsary
argument.
2017-07-11 11:48:21 -07:00
Eeshan Garg
b37ace33ee
help: Document bot types in add-a-bot-or-integration.
2017-07-11 13:25:51 -04:00
Eeshan Garg
37fbed0993
webhooks: Recommend creating "incoming webhook" bot.
...
In all our webhooks' docs, we now recommend creating a bot with the
"Incoming webhook" bot type.
2017-07-11 13:25:51 -04:00