Zev Benjamin
1a6929d9ae
Handle get_old_messages case where num_before = 0 and num_after = 0 and a narrow is specified
...
Previously, we assumed that num_before or num_after would be always be non-zero
after adjustment for the anchor. However, we don't adjust num_before or
num_after when a narrow is specified.
(imported from commit 9239fef140e109b11bdfbeef42e9fbed78660ad1)
2014-02-19 12:24:17 -05:00
Steve Howell
8ce5404777
Describe negated search terms correctly.
...
This changes Filter.describe and Filter.operator_to_prefix
to handle negated terms correctly.
(imported from commit 673c0d3a5a77784e95772c14e12534ad2daecda2)
2014-02-19 11:05:31 -05:00
Steve Howell
8611cc3977
Extract 'verb' variable in Filter functions.
...
Extract 'verb' in Filter.operator_to_prefix() and
Filter.describe(). This doesn't change any functionality;
it is designed to make a subsequent change have a less
noisy diff.
(imported from commit e9c4b6edc498d88ec1783ccdba079d980def9438)
2014-02-19 11:05:31 -05:00
Steve Howell
e645574b14
Add more test coverage to Filter.describe()
...
(imported from commit 9249af23e19b307f2ae168227aa73bba56b1a991)
2014-02-19 11:05:30 -05:00
Steve Howell
44564274a1
Move methods from search_suggestion to filter.
...
The methods describe() and operator_to_prefix() are
now in filter.js. They seem like they eventually
may be useful outside the scope of search suggestions,
and they seem to go hand in hand with other Filter
responsibilities.
(imported from commit 55f14c3ee848febb2e7c8c6a27afd690569b4e08)
2014-02-19 11:05:30 -05:00
Jessica McKellar
f0c20d8acb
nagios: give digest emails even more processing time before alerting.
...
(imported from commit 057511c22af39d147e4c4c499fee5a3fb7392786)
2014-02-18 16:07:31 -05:00
Jason Michalski
0244b50f0b
Split bot deactivation from user deactivation
...
(imported from commit 153a870b244e040e3b5976f639866dbace5563f6)
2014-02-18 15:09:22 -05:00
Jason Michalski
d177f49a96
Change the create bot API to use rest_dispatch
...
(imported from commit 0fac290be2ed04178c4df866f5bc958441b2d320)
2014-02-18 15:09:20 -05:00
Jason Michalski
9d973ff106
Change get_bots API to use rest_dispatch
...
(imported from commit 921895dd636ba118a0f57e60a7bcb9dca1c7c605)
2014-02-18 15:09:19 -05:00
Allen Rabinovich
7822be5cd9
Fix failing stream sidebar node test
...
(imported from commit 3187a8f34389bf1f0b37e80edec9fb56f7281306)
2014-02-18 12:50:32 -07:00
Allen Rabinovich
d0572f50fb
Miscellaneous style fixes for narrow window mode
...
(imported from commit f0a33be1640b2cb8810a0e7af52f453421cf0fe4)
2014-02-18 12:50:32 -07:00
Allen Rabinovich
b00ebd1bdf
Miscellaneous fixes to message pane redesign
...
(imported from commit 8cedb21cb3a520dd9a28c943e047e8f73f410cae)
2014-02-18 12:50:32 -07:00
Allen Rabinovich
cff698d210
Restyle unread markers
...
(imported from commit 70a363cb50eebdd0bd2f11ab56074e46301117b3)
2014-02-18 12:50:32 -07:00
Allen Rabinovich
56f1c023ab
Redesign elements in left sidebar
...
(imported from commit 37ae516325a4bd4db7a9e45e7862af6fee3af46e)
2014-02-18 12:50:32 -07:00
Allen Rabinovich
cdd43baf5d
Add sticky class and an extra recipient bar wrapper
...
(imported from commit 17724a9e31d5baa5a011ead6d521dd7a4e6fe0e2)
2014-02-18 12:50:32 -07:00
Allen Rabinovich
b0d768b16b
Visual adjustments for redesign
...
(imported from commit 79ab506f15671ae2c3d7c6d06213f24125eca603)
2014-02-18 12:50:32 -07:00
Allen Rabinovich
01a04c3169
Add offsets to fixed elements based on the width of the browser scrollbar.
...
(imported from commit 2026725165dead381d0b99181ef84a67a5bd6626)
2014-02-18 12:50:31 -07:00
acrefoot
8af170a3c3
update old messages' stream-color text class
...
(imported from commit 998611bd5b4e25985be73c9262a5c1e772f87ce1)
2014-02-18 12:50:31 -07:00
Jason Michalski
320c2b8eaf
Fix casper tests for redesign
...
Commit "ecf0eb85 Redesign styles for message pane" removed the
right_part class, updates the tests to not use it.
(imported from commit 277eb3748913895b13ab7bdca11e668033c9f9b3)
2014-02-18 12:50:31 -07:00
Steve Howell
de8509e40d
Fix broken template test.
...
(imported from commit a5d935ab84fd16d5fb83ff25fd773b251486c5cd)
2014-02-18 12:50:31 -07:00
Allen Rabinovich
dc71961dd9
Fix showing stream names on dark background
...
(imported from commit 82185ac2717b380e81656630d34f377094d16c38)
2014-02-18 12:50:31 -07:00
Allen Rabinovich
de65bb8194
Move the header and its menus to the top z-index
...
(imported from commit bbbc1f0f3868782959b13c0585435ca02300f9cb)
2014-02-18 12:50:31 -07:00
Allen Rabinovich
4c4cd1ed8e
Fix top notification display to appear above the floating recipient bar
...
(imported from commit 0a5915af3589db09ee2bc294afced0a21352fde2)
2014-02-18 12:50:31 -07:00
Allen Rabinovich
da3ac9ae1b
Implement new unread marker style as background for timestamp
...
(imported from commit e7782d98216f77f6a018c4c01e88aa57eb05144e)
2014-02-18 12:50:31 -07:00
Allen Rabinovich
48476fcbc5
Code cleanup: remove commented code and console logs
...
(imported from commit 20058b87775653f2d526c2d3249549402bc36807)
2014-02-18 12:50:30 -07:00
Allen Rabinovich
2c56e692a2
Fix floating recepient bar hiding when switching to settings pages
...
(imported from commit 9a643075197a53e84df196c3dcc1ce04766d3d4e)
2014-02-18 12:50:30 -07:00
Allen Rabinovich
235baf5187
Fix showing the private message floating recipient bar
...
(imported from commit 1ee76153dfe72627cbe43ea07b746407e5461da7)
2014-02-18 12:50:30 -07:00
Allen Rabinovich
9dd8779a3a
Fix stream color change logic
...
(imported from commit 45dbc57bf28d6b4536fe7683b4a9ce1331d3d072)
2014-02-18 12:50:30 -07:00
Allen Rabinovich
9d68048d1d
Fix edited message squashing against the timestamp
...
(imported from commit c3d39accc75930841ea1795d8df65d39f02574b6)
2014-02-18 12:50:30 -07:00
Allen Rabinovich
78a3da7fbe
Fix issues with message editing and status message layouts
...
(imported from commit 3ec5c6ccf6c20a6c102075887b6ff36afc613bdd)
2014-02-18 12:50:30 -07:00
Allen Rabinovich
25331d8bb2
Adjust dividing line darkness, compose pane width
...
(imported from commit 5a0b59a5a967eb2e26291e9892ad89413b8fdd61)
2014-02-18 12:50:29 -07:00
Allen Rabinovich
ee3cb60e3c
Redesign styles for message pane
...
(imported from commit 394249d58f1cc3b976b432bbc421b99510e7fff9)
2014-02-18 12:50:29 -07:00
Allen Rabinovich
8f90baf1eb
Remove borders around messageboxes
...
(imported from commit 7ffaf256773daa2c2d79a6043c6e252e283fbaa9)
2014-02-18 12:50:29 -07:00
Allen Rabinovich
34f9cf3aa6
Restyle subject editing form
...
(imported from commit f2093939fa8069b73e7c785a4dd835eab4c825cd)
2014-02-18 12:50:29 -07:00
Allen Rabinovich
dbdc0a9721
Switch message pane headers to new design
...
(imported from commit f640641553779450f9d9d15e5586ef38e068367b)
2014-02-18 12:50:29 -07:00
Allen Rabinovich
e7e2f3a79c
Modify crumbbar style to look like an arrowbar
...
Also:
* Change fixed element positioning and fix bugs
* Move settings dropdown back to the right and add left padding to left sidebar
(imported from commit fcf903b59617687f94618a01ce7544b69f408130)
2014-02-18 12:50:29 -07:00
Allen Rabinovich
29250a6692
Move crumbbar to header and change visual appearance
...
(imported from commit 435e3b46b615f6c496be10b7d170ed3e4201787d)
2014-02-18 12:50:29 -07:00
Steve Howell
8bae4d746d
Remove unused json_to_list function.
...
(imported from commit 9da59ee4edd3c569f798710267db5400b9abdb30)
2014-02-18 14:24:04 -05:00
Steve Howell
4bc76b2d6d
Handle more types of data in extract_recipients.
...
We now allow the list of recipients to be sent as a
comma-delimited string with optional JSON encoding.
(imported from commit e928b037bbd258348eb5b2ecca486d0bb77f593e)
2014-02-18 14:24:04 -05:00
Steve Howell
6edb758136
Add test_extract_recipients.
...
(imported from commit 13a5d1287fd489664c7f667d5b75a513f5f744c1)
2014-02-18 14:24:03 -05:00
Steve Howell
f1ee2c6503
Put "Link to this conversation" lower in the message menu.
...
(imported from commit 73d75ac40f097c161f7168a5590c069c1b9e0641)
2014-02-18 13:19:39 -05:00
Steve Howell
bbfd33185c
Remove narrowing options from message chevron menu.
...
Remove the options to narrow by topic/person from the menu,
because there are better ways to do this in the UI, and
remove the time travel option, because the "Link to this
conversation" achieves mostly the same effect.
(imported from commit b7e0cfe64c0760e5a7bf7a8c9c05ed1a5b747300)
2014-02-18 13:19:39 -05:00
Steve Howell
580b6949cc
Remove reply-to-person-only option from message chevron menu.
...
(imported from commit 469ebc9b01ee60eb8c0a673099e0dc735ea95a0e)
2014-02-18 13:19:39 -05:00
Steve Howell
64ff916ca2
Be concise in popover menus.
...
Say Edit/Reply/Collapse/etc. and omit phrases like "this message".
(imported from commit bcf0a8690683c1e0d54b7a6a58fe78b787271357)
2014-02-18 13:19:38 -05:00
Steve Howell
14281de262
Fix brittle layout for "Keyboard shortcuts" help.
...
Adding one row to the Navigation table made the
Keyboard shortcuts dialog look ridiculous, and it
was caused by a design based around float-left-ing
that broke down when the size of the "Navigation" box
was bigger than the "Composing messages" box.
Now we use a div to enclose the top two boxes in
the modal.
(imported from commit 90288ec288d4cf3d50ed7f5bcb48c8bb3d033f19)
2014-02-18 13:04:36 -05:00
Steve Howell
2c6d7e8e18
Support q hotkey to Search people.
...
(imported from commit eafaf5900461e2df52de9ddbdc49823bf6d9e403)
2014-02-18 13:04:36 -05:00
Steve Howell
2d09036466
Have ESC blur Search people if it is empty.
...
(imported from commit d816c8b24cabfbea964fec9cb043f8a00c05f205)
2014-02-18 13:04:35 -05:00
Steve Howell
ebce82b136
Eliminate json_to_dict and use check_dict instead.
...
All usages of json_to_dict were replaced with the check_dict
validator. The check_dict validations can eventually be
extended to validate the keys and values of incoming data,
but now we just use check_dict([]) in all the places where
we had json_to_dict, which means we aren't checking for any
specific keys; we are just making sure it's a dictionary.
(imported from commit fc5add9a7ef149dfac2a9a6d9a153799c4c0c24d)
2014-02-18 13:02:08 -05:00
Steve Howell
3d04f5f738
Use check_list instead of json_to_list.
...
(imported from commit 9ead12bc2a4744b94a747ca27054124aacde7ae4)
2014-02-18 13:02:08 -05:00
Steve Howell
8b58d8574b
Use check_bool instead of json_to_bool.
...
(imported from commit 52eb892a92e293d6ecb854c51bd7bd32355206c9)
2014-02-18 13:02:08 -05:00