5c9d56d2f7
get_safe_redirect_to: Remove incorrect allowed_hosts setting.
...
set(redirect_host) is a set of characters, so the only non-relative
redirects being allowed were to certain one-character hostnames, which
certainly isn’t what was intended.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:51:52 -07:00
3decbd1e23
lint: Remove settings exemption for possibly undefined star imports.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:29:50 -07:00
3a15e4b51d
settings: Extract most of test_settings to test_extra_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:29:50 -07:00
5546762bd9
settings: Extract computed settings to computed_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:29:50 -07:00
826ca3bfdf
settings: Move LDAP_DEACTIVATE_NON_MATCHING_USERS default to default_settings.
...
Tweaked by tabbott to fix an incorrect translation to ONLY_SSO.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:27:55 -07:00
24d320f245
dev_settings: Move prod_settings_template import to configured_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:20:42 -07:00
34b03dcf8a
settings: Move DEBUG default to default_settings.
...
This is overridden in the prod_settings_template.py generated by
build-release-tarball.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:20:42 -07:00
c45962785c
settings: Group {default,prod,dev}_settings as configured_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:20:42 -07:00
18eba18df7
settings: Move bot email defaults to default_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
8ba25960e7
settings: Move NAGIOS_BOT_HOST default to default_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
92a58e9ce0
settings: Move IS_DEV_DROPLET default to default_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
9824405842
dev_settings: Set ZULIP_ADMINISTRATOR.
...
Fixes this error in the dev environment:
$ ./manage.py checkconfig
Error: You must set ZULIP_ADMINISTRATOR in /etc/zulip/settings.py.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
b8acd82b72
dev_settings: Deduplicate DEPLOY_ROOT definition.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
59dec63da3
settings: Remove unused slack_importer_test_settings.
...
Commit 3ebd30120c#8345 ) removed the
corresponding test.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
9cb6a75da5
docs: Fix location of default settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
a7a207d5d9
docs: Add missing code markers to settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
9b9154be91
recent_topics: Set focus on input element on launch.
2020-06-09 22:08:31 -07:00
ec00e39e45
recent_topics: Fix misplaced thead border and adjacent css properties.
2020-06-09 22:08:31 -07:00
e5e02319b4
recent_topics: Show msg if no topics are visible.
2020-06-09 22:08:31 -07:00
ad2e7026c8
recent_topics: Add functionality to sort rows via header.
...
Add custom sorting for stream and topic headers.
2020-06-09 22:08:31 -07:00
084cbd4ff7
recent_topics: Use list_render to display topic rows.
...
This fixes the laggy behaviour when there are 2k+ rows to processes,
since list_render uses lazy render based on what rows are visible
to the user.
2020-06-09 22:08:31 -07:00
0aeadd2c86
recent_topics: Set 'unread' and 'participated' as default filters.
...
Decided after a poll on czo.
2020-06-09 22:08:31 -07:00
33ace41ffe
recent_topics: Add filter button to show muted topics.
...
We don't show muted streams/topics by defualt. Only when user
turns on muted filter.
2020-06-09 22:08:31 -07:00
89fe133d2d
recent_topics: Add button to clear search.
2020-06-09 22:08:31 -07:00
9f50825610
recent_topics: Only rerender when recent_topics is visible.
...
We update the data in the background but only update the view
when recent topics is visible to user.
Also, we always do a complete rerender on launch.
2020-06-09 22:08:31 -07:00
e8cc9da4c7
recent_topics: Don't complete_rerender on filter change.
...
We store the relevant data to hide/show a topic in the row itself,
and use jquery to hide/show it on filter change.
This also fixes search breaking the set filters.
2020-06-09 22:08:31 -07:00
272a3eed8a
recent_topics: Show unread count after topic name.
...
We remove the non-obvious unread count column and move the unread
counts to be displayed after topic.
2020-06-09 22:08:31 -07:00
e6611089fd
recent_topics: Update stored message id of locally echoed messages.
...
This fixes the bug that message was undefined since we used to store
locally echoed message id and were not updating it after new message
id for the same message was received from the server.
2020-06-09 22:08:31 -07:00
35f584e5ef
recent_topics: Remove old rendered topic row on topic edit.
...
We remove all trace of the old topic and reprocess all the new
messages in old and new topics.
process_topic_edit function was moved since it needs to be below
get_topic_row function.
2020-06-09 22:08:31 -07:00
d8a312eddb
recent_topics: Append proper prefix before stream name.
...
We reuse the existing logic for displaying and updating stream color
from the stream left sidebar.
Tests fixtures were extracted and updated for this commit.
2020-06-09 22:08:31 -07:00
515334dfb2
recent_topics: Extract test fixture into a function.
2020-06-09 22:08:31 -07:00
ee7faf13cc
recent_topics: Show checkbox icons for active filters.
2020-06-09 22:08:31 -07:00
cea3bb437f
recent_topics: Make table headers fixed.
2020-06-09 22:08:31 -07:00
4f1b7542ed
recent_topics: Toggle topic display according to filters.
2020-06-09 22:08:31 -07:00
bc7136590a
recent_topics: Add avatars of recent senders to topic.
2020-06-09 22:08:31 -07:00
bdaf4e1079
recent_topics: Add action to mark topic as read.
2020-06-09 22:08:31 -07:00
3c5adeee8a
recent_topics: Update unread count of topics inplace.
2020-06-09 22:08:31 -07:00
52529107d2
recent_topics: Clean unused starred data.
...
The approach that supposed to use this data was not implemented
and hence this data will no longer be used.
If this feature is implemented in future,
this data will still not be used since we would depend upon
starred_messages.js library to provide us the required information.
2020-06-09 22:08:31 -07:00
464b541363
recent_topics: Display recent topics in a table.
...
* Add action to mute topics.
* We don't need to store muted data per topic as previously planned.
* Moved launch topic test to the top so that they run on non-modified
data.
2020-06-09 22:08:31 -07:00
9328dc8437
templates: Show Overlay of Recent Topics.
...
* Show an empty overlay of recent topics.
* Register click event to open recent topics.
* Launch recent topics on "t" keypress.
This is based on the draft overlay.
2020-06-09 22:08:31 -07:00
56b1b6c067
navbar: Add recent topics button.
...
This commit is kept separate so that we can easily move the
place where the recent topic button should be finally kept.
2020-06-09 22:08:31 -07:00
04919528e7
models: Parameterize .extra(where=["… IN …"]) with tuple/list adapter.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 21:12:43 -07:00
de22f7a378
migrations: Use cursor.execute correctly.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 21:12:43 -07:00
859c8b169e
stream_recipient: Use cursor.execute correctly.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 21:12:43 -07:00
68e78c809f
get_recent_private_conversations: Use cursor.execute correctly.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 21:12:43 -07:00
3aab9c03a9
fix_unreads: Use cursor.execute correctly.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 21:12:43 -07:00
14bbfe6ffb
bulk_get_subscriber_user_ids: Use cursor.execute correctly.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 21:12:43 -07:00
2604ebba38
import_message_data: Use psycopg2.extras.execute_values.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 21:12:43 -07:00
6649c8e35f
bulk_insert_ums: Use psycopg2.extras.execute_values.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 21:12:43 -07:00
5839fdf963
analytics: Improve escaping correctness with psycopg2.sql.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 21:12:43 -07:00
Anders Kaseorg
Aman Agrawal
Aman Agrawal