Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
20,670 Commits 28 Branches 143 Tags 605 MiB
Commit Graph

20670 Commits

Author SHA1 Message Date
Umair Khan a5c05f9812 push_notification: Retry event in case of error. 
Fixes #5301
 2017-08-22 11:16:48 -07:00
Umair Khan 62cae23601 queue: Extract event retry into retry_event(). 
This commit takes the code from zerver.lib.outgoing_webhook.request_retry
and creates a new generic function called retry_event.
 2017-08-22 11:16:48 -07:00
Brock Whittaker 1a9c1241af Disable ability to highlight message reactions. 
This adds the `user-select: none` property to `.message_reactions`
to disable accidental highlighting or selecting of the text.
 2017-08-22 11:11:40 -07:00
Robert Hönig c98ed31e80 testing: Remove obsolete coveralls conf file. 
Instead of coveralls, we now use codecov.
 2017-08-22 11:10:55 -07:00
Steve Howell 81e3f489f2 Use sender realm in user_profiles_from_unvalidated_emails. 
This change is mostly based on a similar commit from hackerkid
in a feature branch.  It borrows both code and ideas.  Some of
it's my own stuff, as I was working on a newer branch.

We now call get_user_including_cross_realm_email() inside of
user_profiles_from_unvalidated_emails(), instead of using
get_user_profile_by_email.

This requires a few of our callers to pass down sender into us.

One consequence of this change is that we change the symptoms
for trying to send to emails outside of your realm.  In some
cases, we simply raise an error that an email is invalid to us
instead of getting into the deeper validate_recipient_user_profiles
check.
 2017-08-22 10:42:15 -07:00
Steve Howell 54edecd510 Replace adddressee.for_email() with for_user_profile(). 
This requires us to change not just the immediate caller, but
also some of their callers, to pass user_profile objects around
instead of emails.
 2017-08-22 10:42:15 -07:00
Steve Howell c61c0f3edc Use user_profile, not email, in check_message(). 
We are trying to convert emails to user_profiles earlier in
the codepath.  This may cause subtle changes in which errors
appear, but it's probably generally good to report on bad
addressees sooner than later.
 2017-08-22 10:42:15 -07:00
Steve Howell c56a631b65 Move user_profiles_from_unvalidated_emails -> addressee.py. 
This will avoid circular dependencies.
 2017-08-22 10:42:15 -07:00
Steve Howell 32f18f77d4 Extract two methods from recipient_for_emails. 
We now have these methods:
    user_profiles_from_unvalidated_emails
    recipient_for_user_profiles
 2017-08-22 10:42:15 -07:00
Steve Howell 30d37d1270 Add Addressee class. 
This class simplifies the calling sequence to methods like
check_message and _internal_prep_message, and it's also more
type safe.

Checking for message types is encapsulated with calls to is_stream()
and is_private().  There are also shortcut constructors when you
know that the type of the address (stream vs. private), which is often.
 2017-08-22 10:42:15 -07:00
Tim Abbott 0d390edeeb version: Bump PROVISION_VERSION for latest changes. 2017-08-22 10:42:01 -07:00
Tim Abbott 15c49679fe requirements: Document the process a bit more. 2017-08-22 10:42:01 -07:00
Tim Abbott 559dc40ebb requirements: Mark dateutil as being explicitly used by tests. 
Since it's a library we might eventually start using in production
code without thinking about it, I'd rather just have it be available
in all environments.
 2017-08-22 10:42:01 -07:00
Tim Abbott f5fe9d24bb requirements: Remove unnecessary dateutil dependency. 
This is only needed for some Nagios scripts, which don't use the Zulip
virtualenv anyway.  They already correctly install the relevant
package via apt.
 2017-08-22 10:42:01 -07:00
Tim Abbott bc63cdf538 requirements: Remove unnecessary netifaces dependency. 
This is only used for
puppet/zulip_ops/files/zulip-ec2-configure-interfaces, and that
actually doesn't even use the Zulip virtualenv (and correctly already
has puppet configuration to install this dependency).
 2017-08-22 10:42:01 -07:00
Tim Abbott 54ec4e9e34 requirements: Remove flup dependency. 
This was needed for fastcgi, which we stopped using many months ago.
 2017-08-22 10:42:01 -07:00
Robert Hönig 84a7350de6 docs: Clarify webhook-specific guides. 2017-08-22 10:38:48 -07:00
rht 95df787a1e requirements: Remove scandir implicit dependency. 2017-08-22 10:10:57 -07:00
rht beba59bfd5 requirements: Remove socialauth.txt recursive dep file. 2017-08-22 10:10:57 -07:00
rht 3f343f4b7b requirements: Remove emailmirror.txt recursive dep file. 
The libraries in emailmirror.txt, with the exception of talon, are
imported indirectly, and so these are better autogenerated.
 2017-08-22 10:10:57 -07:00
rht 99511421d1 requirements: Rename py3_common.txt to common.txt. 2017-08-22 10:10:57 -07:00
rht 0a469fd4c8 requirements: Lock prod.txt instead of its py3_common dependency. 
`py3_common.txt` is no longer locked.
 2017-08-22 10:10:57 -07:00
rht 6a5869ec8d requirements: Rename py3_prod.txt to prod.txt. 2017-08-22 10:10:57 -07:00
rht e2627df7f0 requirements: Rename py3_socialauth.txt to socialauth.txt. 2017-08-22 10:10:57 -07:00
rht 80f4ba7a76 requirements: Replace py3_dev.txt with dev_lock.txt. 2017-08-22 10:10:57 -07:00
Tim Abbott 58edf75962 api: Allow incoming webhook bots to use the send_message API. 2017-08-22 10:06:34 -07:00
Max Schaefer 8aa5a02866 js: Remove a few spurious arguments. 2017-08-22 09:37:17 -07:00
Max Schaefer 4d0f304048 js: Fix two misphrased conditions. 2017-08-22 09:37:15 -07:00
Aditya Bansal 0dcbacdbc6 emoji_picker: Refactor toggle_emoji_popover to split out to functions. 2017-08-22 08:46:55 -04:00
Aditya Bansal f645a0304b emoji_pickers: Add tests for emoji_picker.initialize(). 2017-08-22 08:07:25 -04:00
Tim Abbott b55458b630 version: Bump PROVISION_VERSION for recent Python deps. 2017-08-21 18:38:29 -07:00
rht 1519a243bf Remove ipython,moto,scrapy,twisted recursive dep files. 2017-08-21 18:24:55 -07:00
rht 2be8a793e4 Lock the recursive requirements in dev.txt via pip-compile. 
First, all the lines of py3_dev.txt except for mypy.txt are mv-ed to
dev.txt. Then dev_lock.txt is generated from dev.txt to be used by
py3_dev.txt. `click` is removed from moto.txt since it is already a
dependency of several libraries and will appear as an autogenerated
dependency.
 2017-08-21 18:24:55 -07:00
rht 2afbc7e4d7 requirements: Squash dev.txt into py3_dev.txt. 2017-08-21 18:24:55 -07:00
rht e4e0d7effd requirements: Squash common.txt into py3_common.txt. 2017-08-21 18:24:55 -07:00
rht f24b1f2057 requirements: Squash prod.txt into py3_prod.txt. 2017-08-21 18:24:55 -07:00
rht 6baef37564 requirements: Remove Python 2-specific files. 2017-08-21 18:24:55 -07:00
Steve Howell e12da79732 create_realm: Redirect to a nice error page for SMTP errors. 
Fixes #3850
 2017-08-21 15:39:26 -07:00
Steve Howell 99e08fe49a accounts_home: Redirect to nice error page for SMTP errors. 2017-08-21 15:39:26 -07:00
Steve Howell ac80d1df0a Add /config-error/smtp endpoint for SMTP errors. 2017-08-21 15:39:26 -07:00
David Taylor 0ffc758129 Add 'category' to WebhookIntegration definition 2017-08-21 14:58:38 -07:00
Vishnu Ks ba16616961 requirements: Upgrade simplejson to 3.11.1. 2017-08-21 07:52:16 -07:00
Vishnu Ks 3351e2afb9 requirements: Upgrade Markdown to 2.6.9. 2017-08-21 07:52:16 -07:00
Vishnu Ks 55ce054bce requirements: Upgrade babel to 2.5.0. 2017-08-21 07:52:16 -07:00
Vishnu Ks d431d50da0 requirements: Upgrade httpretty to 0.8.14. 2017-08-21 07:52:15 -07:00
Vishnu Ks 557c92c16f requirements: Upgrade idna to 2.6. 2017-08-21 07:52:15 -07:00
Vishnu Ks 2031c24eb0 requirements: Upgrade redis to 2.10.6. 2017-08-21 07:52:15 -07:00
Vishnu Ks e46a5abe8d requirements: Upgrade fonttools to 3.15.0. 2017-08-21 07:52:15 -07:00
Vishnu Ks 12bb19a2cb requirements: Upgrade botocore to 1.6.3. 2017-08-21 07:52:15 -07:00
Vishnu Ks 1f90ad0a05 requirements: Upgrade w3lib to 1.18.0. 2017-08-21 07:52:15 -07:00