Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
56,794 Commits 28 Branches 143 Tags 624 MiB
Commit Graph

3 Commits

Author SHA1 Message Date
Anders Kaseorg e56863fa85 ruff: Fix DJ012 Order of model's inner classes, methods, and fields. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-01-29 10:41:54 -08:00
Alex Vandiver 7720d362ba messages: Only lock UserMessage rows, not other joined tables. 
By default, `SELECT FOR UPDATE` will also lock any rows which are
`JOIN`ed into the selected rows; in the case of UserMessage rows, this
can mean arbitrary Message rows.

Since the messages themselves are not being changed, it is not
necessary to lock them -- and doing so may lead to deadlocks, in the
case that the UserMessage row is locked for update before the Message,
and some other request has already taken a read lock on the Message
and is blocked on the UserMessage write lock.

Change `select_for_update_query` to explicitly only lock UserMessage.
 2024-01-09 13:13:59 -08:00
Anders Kaseorg b15999c799 models: Extract zerver.models.messages. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-12-16 22:08:44 -08:00