zulip

Commit Graph

Author	SHA1	Message	Date
Riken Shah	f95c539122	custom_check: Avoid use of assert to avoid confusion with assert.equal. This commit bans the use of `assert` and replaces it with `assert.ok` to avoid confusion with `assert.equal`. Fixes #18687.	2021-06-10 09:15:57 -07:00
Steve Howell	b7a188fde8	node tests: Deepen filter_user_ids test. We now test that activity.build_user_sidebar integrates with the user_search code.	2021-05-18 18:34:17 -04:00
Steve Howell	cd1510c0ef	node tests: Extract user_search tests. This is mostly moving tests from activity.js into user_search.js, but it's not a verbatim code move. The new module continues to make sure that the boundary between activity and user_search is correct, as most of the testing uses the configuration of UserSearch from static/js/activity.js. It does not use a real buddy_list, though, which simplifies some tests. I cleaned up some tests by making sure we were testing both sides of conditions more rigorously. After this change we no longer need the bloated activity.js tests to maintain full coverage on static/js/user_search.js.	2021-05-18 14:16:55 -04:00

Author

SHA1

Message

Date

Riken Shah

f95c539122

custom_check: Avoid use of assert to avoid confusion with assert.equal.

This commit bans the use of `assert` and replaces it
with `assert.ok` to avoid confusion with `assert.equal`.

Fixes #18687.

2021-06-10 09:15:57 -07:00

Steve Howell

b7a188fde8

node tests: Deepen filter_user_ids test.

We now test that activity.build_user_sidebar
integrates with the user_search code.

2021-05-18 18:34:17 -04:00

Steve Howell

cd1510c0ef

node tests: Extract user_search tests.

This is mostly moving tests from activity.js
into user_search.js, but it's not a verbatim
code move.

The new module continues to make sure that
the boundary between activity and user_search
is correct, as most of the testing uses
the configuration of UserSearch from
static/js/activity.js.

It does not use a real buddy_list, though,
which simplifies some tests.

I cleaned up some tests by making sure we
were testing both sides of conditions more
rigorously.

After this change we no longer need the
bloated activity.js tests to maintain full
coverage on static/js/user_search.js.

2021-05-18 14:16:55 -04:00

3 Commits