zulip

Commit Graph

Author	SHA1	Message	Date
Cynthia Lin	e9cf545ada	scroll_util: Account for element padding in height calculations.	2018-07-27 09:09:52 -07:00
Armaan Ahluwalia	6d255efe4c	app: Prepare JS files for consumption by webpack. This commit prepares the frontend code to be consumed by webpack. It is a hack: In theory, modules should be declaring and importing the modules they depend on and the globals they expose directly. However, that requires significant per-module work, which we don't really want to block moving our toolchain to webpack on. So we expose the modules by setting window.varName = varName; as needed in the js files.	2018-07-05 10:53:36 +02:00
Steve Howell	97b9367d20	refactor: Extract scroll_util.js. We now use scroll_element_into_container() in two different places, so it's worth extracting.	2018-04-28 11:15:14 -07:00

Author

SHA1

Message

Date

Cynthia Lin

e9cf545ada

scroll_util: Account for element padding in height calculations.

2018-07-27 09:09:52 -07:00

Armaan Ahluwalia

6d255efe4c

app: Prepare JS files for consumption by webpack.

This commit prepares the frontend code to be consumed by webpack.

It is a hack: In theory, modules should be declaring and importing the
modules they depend on and the globals they expose directly.

However, that requires significant per-module work, which we don't
really want to block moving our toolchain to webpack on.

So we expose the modules by setting window.varName = varName; as
needed in the js files.

2018-07-05 10:53:36 +02:00

Steve Howell

97b9367d20

refactor: Extract scroll_util.js.

We now use scroll_element_into_container() in two different
places, so it's worth extracting.

2018-04-28 11:15:14 -07:00

3 Commits