589551b6ee
settings: Change "Custom alert words" to "Alert words".
2017-03-15 11:25:37 -07:00
c155577246
Allow users to resize the message compose box.
...
This allows for users to resize the message compose box without it
collapsing back down to jQuery autosize’s preferred height.
When you hide the compose box and then re-show it, it keeps the
previous height but reactivates the jQuery module.
Fixes : #2236 .
2017-03-14 17:40:21 -07:00
ddd0b854f9
Remove references to page_params.domain.
...
Continuation of 098797c
2017-03-14 17:17:42 -07:00
b648c06009
hotkeys/refactor: Extract tab key handlers.
...
This extracts process_tab_key() and process_shift_tab_key().
It also removes some dead code related to alert words tabbing.
2017-03-14 16:42:40 -07:00
bdbaa5d386
hotkeys: Simplify navigation checks for page up/down.
...
We remove an unnecessary conditional that always returned true
due to checks that happen earlier in the function.
2017-03-14 16:42:40 -07:00
2a3e74427b
Export hotkey.tab_up_down() for testing.
2017-03-14 16:42:40 -07:00
8a408a6cbc
popovers: Fix actions popover menu positioning.
...
The main issue is that it wasn't doing the correct comparison; the old
logic that subtracted the viewport.scrollTop() was incorrect for how
our popovers seem to work.
Partially fixes #3741 .
2017-03-14 15:37:37 -07:00
e3fa42f833
edit: Hide emoji reactions when in message edit or view source mode.
...
This also entails displaying them when the editing mode ends.
Fixes #3870 .
2017-03-14 14:55:16 -07:00
11c7bb49d4
Restyle "invite" modal.
...
This restyles the invite modal to have the same header as the rest of
the overlays.
2017-03-14 14:47:12 -07:00
4c4208ac86
Make all modal exit "x" sizes uniform.
...
This makes all exit “x”’s uniformly 1.5rem in size and font-weight: 600.
2017-03-14 14:47:12 -07:00
b0e2c4ffee
settings: refactor code to hide "Email Change" button.
...
Previously, the code to hide "Change email" button on page load when
email changes are disabled was present in settings.js using jquery to
hide the button. Now, the show/hide is handled in the account-settings handlebars.
2017-03-14 14:43:35 -07:00
ef7e15ee00
admin: Add realm option to prevent users from changing their name.
...
A realm option to prevent users from changing their name is added.
Fixes #3950 .
2017-03-14 14:10:08 -07:00
1e5ec689b7
tools/css: Trim whitespace around CSS values.
2017-03-14 09:29:56 -07:00
2ffea94bd8
tools/css: Require semicolons after CSS declarations.
2017-03-14 09:29:56 -07:00
a1d7e1b5f6
css: Tweak padding around code blocks to look nicer.
...
It makes sense to a bit tighter padding around code blocks in a chat context.
2017-03-13 22:35:00 -07:00
a9db9eb389
css: Improve code block styling.
...
Change pygments for prettier syntax highlighting with white
backgrounds for both inline and multi-line code blocks.
2017-03-13 22:34:11 -07:00
a1b5f91c1a
hotkeys: Remove wasteful resize calls for keydown events.
...
This fix prevents us from calling the resize library for nearly
every single keydown event in the app (ouch!). Realistically,
this performance improvement only impacts folks who turned on
the autoscroll_forever feature, but it should be a significant
speed-up for them. We should go further with this fix, but the
main damage is undone.
2017-03-13 21:38:23 -07:00
c88c69db2e
bug fixes: Clean up hotkey mappings.
...
We simplify hotkey mappings by using different hashes for
keydown and keypress events. There are browser bugs (iOS, for
example) where keypress events have the wrong keyCode values.
This led us, under iOS, to interpret "!" as "page up."
This fix also helps us disinguish escape from shift-escape.
Brock Whittaker helped on figuring out the keypress/keydown
issues that are addressed in this commit.
Fixes #4019
2017-03-13 21:38:23 -07:00
dfa965717f
Fix drafts responsiveness issues.
...
The drafts container was too skinny on mobiles, so the enforced
max-width of 60% should be ignored in favor of expanding to 90%
of the screen width.
This also fixes an issue where the content does not reach the bottom
of the container due to having too short of a height.
Fixes : #3867 .
2017-03-13 21:15:56 -07:00
b99c190380
Extract hotkeys.process_enter_key().
2017-03-13 15:09:53 -07:00
cfcad48e46
bug fix: Blur message edit textboxes when hitting escape.
...
We have a somewhat janky mechanism for rendering message edits,
and before this fix, we were not unblurring the text boxes when
we closed the message editing session with the escape key, which
made it so that the escape key was unusable.
2017-03-13 15:09:53 -07:00
f9d26856e8
hotkeys: Remove typeahead logic for escape keys.
...
We had some ancient logic for typeaheads that was supposed to be
Firefox-specific, but I can't reproduce the code even running under
Firefox, and even if it did, it was returning true instead of false
for a long time, so I suspect the code has been wrong/irrelevant for
a long time.
2017-03-13 15:09:53 -07:00
55ade83ac2
Extract hotkey.process_escape_key().
2017-03-13 15:09:53 -07:00
87a7313143
refactor: Extract compose.reply_with_mention().
2017-03-13 15:09:53 -07:00
0979aad226
refactor: Export hotkey.processing_text() for tests.
2017-03-13 15:09:53 -07:00
1df2dfc6e0
hotkeys refactor: Flip conditional related to popovers.
...
When checking for hotkeys related to popovers, we avoid making
the external call for keys that won't be important for popovers.
This mostly helps testing.
2017-03-13 15:09:53 -07:00
b1ef7b2e53
Extract hotkey.is_editing_stream_name().
2017-03-13 15:09:53 -07:00
1d6e3124c1
Export hotkey.is_settings_page() for testing.
2017-03-13 15:09:53 -07:00
db3883fc51
hotkeys: Refactor backspace/shift-tab sections.
...
Only check to see if the compose send button is in focus if
we dealing with backspace/shift_tab. As the comment notes here,
these sections of code are somewhat dubious.
2017-03-13 15:09:53 -07:00
20f26c40e1
Export process_hotkey() for testing.
2017-03-13 15:09:53 -07:00
1f2eddad8b
user docs: Add user guide for *View a message's edit history* feature.
...
Fixes #3730
2017-03-13 15:03:35 -07:00
9df26a296f
composebox_typeahead.js: Remove unnecessary special case for zulip.com.
...
This was originally introduced in
025b79d98b
2017-03-13 14:36:34 -07:00
5e39ccd642
js: Rename viewport.js to message_viewport.js.
...
This fixes the mobile web experience for Chrome on iOS.
Apparently, Chrome-on-iOS silently has a `viewport` module that
overrides and user-defined module by that name, causing all of our
code that accesses the viewport module to not work on that platform.
We fix this by renaming it.
2017-03-10 14:59:59 -08:00
43b19a6997
Clean user_presence_row.handlebars to use 4 space indents.
2017-03-10 11:07:49 -08:00
ccec320f1d
Clean stream_sidebar_actions.handlebars to use 4 space indents.
2017-03-10 11:07:49 -08:00
ebf3eaf9ae
Clean stream_member_list_entry.handlebars to use 4 space indents.
2017-03-10 11:07:49 -08:00
d9a0fcc931
Clean tutorial_message.handlebars to use 4 space indents.
2017-03-10 11:07:49 -08:00
e08d28bd0f
Clean email_address_hint.handlebars to use 4 space indents.
2017-03-10 11:07:49 -08:00
11418ed9c8
Clean draft_table_body.handlebars to use 4 space indents.
2017-03-10 11:07:49 -08:00
bf577297c7
Clean tab_bar.handlebars to use 4 space indents.
2017-03-10 11:07:49 -08:00
c6681917c1
settings: Add UI to allow a user to reactivate his own bots.
...
Using this UI, a user can now reactivate the bots owned by him.
Until now if a bot was deactivated, there was no way to use the
old bot's original email address. But now they can be reactivated
and their email can be reused.
Fixes : #1183 .
2017-03-10 10:59:49 -08:00
0dbca4a3c3
settings: Display all the bots owned by an user.
...
Add UI to display all the bots owned by an user whether active
or inactive in "Your Bots" section.
2017-03-10 10:59:49 -08:00
876d7bbcdc
settings: Rename `bots_list` to `active_bots_list`.
2017-03-10 10:59:49 -08:00
900891b072
settings: Rename settings-status to account-settings-status.
2017-03-10 10:53:06 -08:00
05f0d1953b
account-settings: Removed 'Updated settings' message from admin.
...
The 'Updated Settings' message we get at the bottom
of admin-page when we change the name is removed.
Fixes #3815 .
2017-03-10 10:53:06 -08:00
5023b69ca5
stream settings: Add "View Stream" button.
...
This adds a button to #subsciption page called "View Stream"
that narrows the user to that particular stream.
This fix involves typical changes to JS/CSS to add new features,
and we also add a "preview_url" field to the sub object in
stream_data.js.
Fixes #3878
2017-03-10 08:26:57 -08:00
c17e574211
Remove product_name setting and return to harcoding 'Zulip'.
...
This removes some confusion in grep for frontend strings with Zulip in
them and also cleans up the code in some places.
Fixes #1602 .
2017-03-09 21:48:15 -08:00
e5ab3123af
Migrate json/set_muted_topics to muting/topics.
2017-03-09 20:52:29 -08:00
7f5abcef9c
subs: Modify css to fix stream description cut off.
...
Fixes the cut off of Stream descriptions at the bottom of
subscriptions page if they have `g`s in them.
Fixes #3277 .
2017-03-09 20:03:35 -08:00
ce826e82c5
reactions: Fix click handler for reactions button.
...
This was broken when we fixed the click target for the other reactions
button place.
2017-03-09 12:18:17 -08:00
217b8f2a85
hotkeys: escape key press dismiss "invite-users" modal.
...
Pressing escape key dismiss the invite-user modal.
Fixes #4008 .
2017-03-09 12:10:27 -08:00
9ab4b3b6cc
topics: Add tooltip showing full topic name in left sidebar.
...
This is useful if the topic name is too long and thus is cut off for
display purposes.
Fixes #3979 .
2017-03-09 11:12:32 -08:00
621e0749dc
Clean subscription_table_body.handlebars to use 4 space indents.
2017-03-09 01:17:25 -08:00
46ea4ea05f
Clean subscription_stream_privacy_modal.handlebars to use 4 space indents.
2017-03-09 01:17:25 -08:00
8b164b57ad
Clean muted_topic_ui_row.handlebars to use 4 space indents.
2017-03-09 01:17:25 -08:00
25c656a6cc
Clean message_reaction.handlebars to use 4 space indents.
2017-03-09 01:17:25 -08:00
33a8aa7bf2
Clean bot_owner_select.handlebars to use 4 space indents.
2017-03-09 01:17:23 -08:00
f5afcb5a4b
Clean topic_edit_form handlebar to use 4 space indents.
2017-03-09 01:17:23 -08:00
1143a2d8c4
attachment: Add file icon to the green box when file has no extension.
...
Fixes #3848 .
2017-03-09 00:56:37 -08:00
84d4f62abf
lint: Exclude Acme placeholders from translations.
...
These strings represented a small waste of time for our translators.
2017-03-09 00:38:15 -08:00
cc07190fdc
capitalization: Clean up failed message sending options.
2017-03-09 00:36:13 -08:00
2894924ffb
capitalization: Fix Only Admins may now create new streams.
2017-03-08 23:40:15 -08:00
c0e92015fd
capitalization: Fix Only Admins may now add new emoji.
2017-03-08 23:38:36 -08:00
70aa443c25
stream_popover: Fix references to topic_ops.
...
This apparently got lost in the refactoring that extracted
stream_popover.js.
2017-03-08 23:30:44 -08:00
5613358638
stream_popover: Fix hiding topic popover.
2017-03-08 23:25:30 -08:00
f63f251f8f
css: Fix styling and padding in mobile sidebars.
...
Fixup the styling of the mobile sidebars to be a little bit more
stylistically uniform.
2017-03-08 21:23:29 -08:00
a94077db07
Make subscriptions page scrolling responsive.
...
This fixes some scrolling issues that are present on mobile and iOS.
2017-03-08 21:08:36 -08:00
bb13cad60f
compose: Bring back the compose buttons on mobile.
...
Before they were hidden in favor of icons, but now there’s no need to
hide them, we should just display the original buttons.
2017-03-08 21:07:43 -08:00
c5ba4e11d4
Redesign "/integrations/" page in portico.
...
This redesigns the integrations page to incorporate the new landing nav,
CSS animations, and general styling of the product page set.
2017-03-08 17:42:17 -08:00
30bd61530d
Add elastic scrolling to iOS.
...
This adds elastic scrolling to iOS to allow for scroll inertia
properties as standard webpages should exhibit.
2017-03-08 17:04:10 -08:00
1d2c3cec10
Fix: change mobile sidebar click target to call new popover function.
...
This changes the click target that opens the mobile sidebar to call the
new popover function in stream_popover rather than the old popovers
object.
2017-03-08 17:04:10 -08:00
3b59e6c3cc
subs: Rename /#subscriptions to /#streams.
...
Fixes #3653 .
2017-03-08 16:57:58 -08:00
5cfd1e1266
bot settings: Change placeholder from bot_user_name to cookie.
2017-03-08 16:26:13 -08:00
3797fa657e
Change bot domains to string_id.EXTERNAL_HOST.
...
Change applies to both subdomains and non-subdomains case, though we use
just the EXTERNAL_HOST in the non-subdomains case if there is only 1 realm.
Fixes #3903 .
2017-03-08 16:26:13 -08:00
4a1f1db9ee
users: Avoid inserting into the DOM in a loop.
...
This fixes a major performance issue loading the administration page
in large organizations.
2017-03-08 16:21:25 -08:00
a8d8855624
attachment: Avoid inserting into the DOM in a loop.
...
This has a huge impact on the performance of loading the settings page
if you have a decent number of past uploaded files.
2017-03-08 16:20:50 -08:00
9c02e59b66
hotkey: Fix K/J being treated as hotkeys in compose.
2017-03-08 16:02:33 -08:00
e61b54b74a
Fix spacebar being broken in the compose box.
...
This fixes a regression introduced in
8801158dfd
2017-03-08 15:57:56 -08:00
fc3927a124
subs: Improve meta.stream_created targeting.
...
This fixes a potential race where you get subscribed to a stream
around the same time that you create a stream.
2017-03-08 14:47:49 -08:00
022aeca085
subs: Prepend new streams to top of stream list.
...
This prepends new streams that are created to the top of the list so
that they are more visible when being created.
2017-03-08 14:47:00 -08:00
8801158dfd
Add hotkey actions for page up/down in compose box.
...
The hotkey actions make the caret position go to the top of the compose
box or bottom respectively, while the compose box is open.
Fixes #1910 .
2017-03-08 14:13:05 -08:00
ee231c0223
login: Improve development server login copy.
2017-03-08 12:36:04 -08:00
d4228e8151
capitalization: Fix waiting period threshold changed.
2017-03-08 12:33:37 -08:00
22c1c13f38
capitalization: Fix View Source / Edit Topic.
2017-03-08 12:33:37 -08:00
935cacfc86
capitalization: Fix View Source.
2017-03-08 12:33:37 -08:00
523f8ecd79
capitalization: Fix Upload New Avatar.
2017-03-08 12:33:37 -08:00
3dd823b0af
capitalization: Fix Stream Name.
2017-03-08 12:33:36 -08:00
fdb709d0b7
capitalization: Fix No Drafts.
2017-03-08 12:29:07 -08:00
9faf73eaa9
capitalization: Fix Generate new API Key.
2017-03-08 12:29:07 -08:00
569418f0b4
capitalization: Fix Full Bot Name.
2017-03-08 12:29:07 -08:00
7d398f4ce3
capitalization: Fix Exit Tutorial.
2017-03-08 12:29:07 -08:00
7420d77cc3
capitalization: Fix Edit User.
2017-03-08 12:29:07 -08:00
1863ce41f1
capitalization: Fix Delete Avatar.
2017-03-08 12:29:07 -08:00
a67b405f3b
capitalization: Fix Delete Alert Word.
2017-03-08 12:29:07 -08:00
780e3d8d12
capitalization: Fix Deactivate Account.
2017-03-08 12:29:07 -08:00
6728d212a6
capitalization: Fix Copy from Stream.
2017-03-08 12:29:07 -08:00
33325d94ab
capitalization: Fix Change Password.
2017-03-08 12:29:07 -08:00
7973b7ffd2
capitalization: Fix Allow Subdomains.
2017-03-08 12:29:07 -08:00
0a41c12a07
capitalization: Fix Alert Word.
2017-03-08 12:29:06 -08:00
0d31bcc2f7
capitalization: Fix API Key.
2017-03-08 12:29:06 -08:00
Cynthia Lin
Brock Whittaker
Rishi Gupta
Steve Howell
Abhishek Bhattacharya
Philip Skomorokhov
Raghav Jajodia
Tim Abbott
adnrs96
Harshit Bansal
Kanak Garg
Amy Liu
Saurav Pratihar
Rafid Aslam
Umair Khan