58c84940f4
blueslip: Convert BlueslipError to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:40:42 -07:00
abe52e2191
filter: Convert Filter to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:40:42 -07:00
aee95ecf7e
util: Convert CachedValue to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:40:42 -07:00
4ad00c1aea
lightbox_canvas: Remove old-style window.onload handler.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:32:53 -07:00
fc21417d67
lightbox_canvas: Convert LightboxCanvas to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:32:53 -07:00
d5a0ee612f
lightbox_canvas: Make parameter type error fatal.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:32:53 -07:00
c4024e30c2
debug: Convert IterationProfiler to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:32:53 -07:00
ec9c272165
help: Document process for changing organization URL.
2020-07-24 16:12:56 -07:00
2922e2cbb1
compose: Use aria-label instead of aria-hidden.
...
aria-hidden hides something from the accessiblity tree,
it shouldn't be used for interactive elements.
2020-07-24 15:31:26 -07:00
8f99820120
composebox_typeahead: Remove deprecated workaround.
...
The Chromium bug[1] was fixed in 2015.
[1]: https://bugs.chromium.org/p/chromium/issues/detail?id=32865
2020-07-24 15:31:26 -07:00
21dfe76295
tests: Remove dead print-delay code.
2020-07-24 15:30:17 -07:00
5f0bd44d58
notifications: Fix incorrectly converted focus method call.
...
Commit a9ca5f603b#15863 ) incorrectly
converted this; window is quite obviously a DOM element, not a jQuery
element.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 14:48:47 -07:00
63991a0a3c
test_message_dict: Remove clock time assertion.
...
Clock time checks lead to tests that nondeterministically fail when
the CI container is super slow, and there's no good reason this test
in particular needs to do that sort of test in addition to our
standard database query count check (which is already does).
2020-07-24 13:29:26 -07:00
ce77a733e1
outgoing webhook tests: Make setup explicit.
...
Now when you are reading a single test, you can
explicitly see that the event and service handler
are tied to your bot, which is our test bot
for outgoing webhooks.
2020-07-24 13:13:34 -07:00
fb2a69ec78
outgoing webhook tests: Remove dead code.
...
The first assignment is redundant, and the
second assignment is ignored.
2020-07-24 13:13:34 -07:00
36027d495a
outgoing webhook tests: Avoid mock decorator.
...
Decorating an entire test with a mock makes it
hard to ascertain where the actual mock behavior
is expected to happen, plus it clutters up
the parameter list.
In fact, we remove a dubious re-assertion here that
a mock was called. The assertion that a mock was
called was true, but it was misleading to think
the code right before it had invoked the mock.
2020-07-24 13:13:34 -07:00
063e27ab52
mypy: Move accidental mock annotation for self.
...
Curiously, the obviously broken annotation for
self obscured the lack of assert here, so I
fixed that too.
2020-07-24 13:13:34 -07:00
924292ba65
outgoing webhook tests: Move code out of with blocks.
2020-07-24 13:13:34 -07:00
ad23c6e808
emoji: Switch to `user_profile.realm` for cross-realm reactions.
...
A temporary fix to enable cross-realm emoji reactions till `Message.realm`
is denormalized.
Fixes #15866 .
2020-07-24 13:11:27 -07:00
bcab06509a
analytics: Remove unused analytics management commands.
...
Unlike stream_stats, I'm not aware of any of these having been used in
the last few years, and it's basically just really bad subsets of the
data in /activity, which also doesn't require shell access to use.
These haven't had real work or usage, AFAIK, since 2013.
2020-07-24 13:10:43 -07:00
49d06b9d69
activity: Always include realms on standard plan.
2020-07-24 13:09:43 -07:00
f0c4cc9e46
js: Fix new import/order errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 13:04:07 -07:00
f5bc454b3a
emoji: Remove dependence on page_params.
...
This sets us up to make emoji a leaf module.
2020-07-24 12:57:52 -07:00
5280b87f19
emoji refactor: Let emoji.js own the data.
...
We now only use page_params.realm_emoji at
intialization time, and then settings_emoji
gets the data from emoji.js.
2020-07-24 12:57:52 -07:00
d11c6686a1
minor: Remove parameter to populate_emoji.
...
This is an easy prep step to help out phase
out page_params.realm_emoji.
All callers pass in what's effectively
page_params.realm_emoji. (The dispatch
code does it indirectly.)
2020-07-24 12:57:52 -07:00
4f195de78d
node tests: Split out settings_emoji.
...
This keeps the emoji tests free of jQuery
concerns.
2020-07-24 12:57:52 -07:00
cc31403112
mobile sharing: Move fenced_code.js to shared/js.
...
We also take fenced_code out of the global namespace,
since it only requires katex and underscore.
And we fix the exports to be ES6 style.
2020-07-24 12:57:52 -07:00
c50dbf8297
node tests: Extract markdown_katex.
...
I want to isolate this test to its own module,
because it is gonna require some rewireproxy
magic in an upcoming commit.
2020-07-24 12:57:52 -07:00
db1e47dd95
node tests: Organize requires for markdown tests.
2020-07-24 12:57:52 -07:00
473be34d90
sentry: Add sentry_sdk dependency.
2020-07-24 12:52:15 -07:00
f3921e57be
ci: Remove confused references to test-event-log.
...
The "event log" in question was never useful in our test systems (and
hasn't been used for anything real since 2014). I'm not sure how we
ended up with in the CI configuration.
2020-07-24 12:42:08 -07:00
a2fc823c3f
provisioning: Use AWS CLI to automate provisioning
...
The previous steps for standing up a new host were somewhat manual.
This further scripts the process, by using the AWS CLI to start the
instance, and pass it a "user data" script to provision itself upon
boot. This results in a hands-off provisioning process which
completes in 5min.
Additional settings are required for `~/.zulip-install-server.conf`.
It is not suited for all roles, as it assumes one instance type and
security group value. Additionally, not all of the post-provision
process is currently automated -- Nagios SSH key verification, for
instance, is still a manual step. There are also additional steps for
database or frontend servers. Regardless, this is a move toward
automated provisioning.
2020-07-24 12:40:14 -07:00
29c66cf7c2
actions: Remove log_event and its legacy settings.
...
Now that we've finally converted these to use RealmAuditLog, we can
remove this ultra-legacy bit of code.
2020-07-24 12:13:16 -07:00
0d79b55b2e
audit_log: Record RealmAuditLog in do_change_notification_settings.
...
Removed logging with log_event and used RealmAuditLog instead.
Added tests in test_audit_log for the same.
2020-07-24 12:04:40 -07:00
54df9290b9
audit_log: Record RealmAuditLog in do_rename_stream.
...
Removed logging with log_event and used RealmAuditLog instead.
Added tests in test_audit_log for the same.
2020-07-24 12:00:31 -07:00
94d2de8b4a
audit_log: Record RealmAuditLog while changing default streams.
...
Removed logging with log_event and used RealmAuditLog instead.
Added tests in test_audit_log for the same.
2020-07-24 12:00:31 -07:00
753713fde7
audit_log: Record RealmAuditLog in do_change_subscription_property.
...
Removed logging with log_subscription_property_change
and used RealmAuditLog instead.
Added tests in test_audit_log for the same.
2020-07-24 12:00:29 -07:00
e6f54a3278
audit_log: Record RealmAuditLog in do_change_icon_source.
...
Removed logging with log_event and used RealmAuditLog instead.
Added tests in test_audit_log for the same.
2020-07-24 11:56:40 -07:00
12a19b0ff1
actions.py: Removed unnecessary logging in notify_subscription_added/removed.
...
We already record RealmAuditLog in bulk_add/remove_subscription
so there is no need to log while notifying.
2020-07-24 11:51:47 -07:00
ccdf52fef6
audit_log: Log RealmAuditLog for realm notification properties.
...
Log RealmAuditLog for do_set_realm_notifications_stream and
do_set_realm_signup_notifications_stream function.
Added tests for the same.
2020-07-24 11:51:47 -07:00
8f6a1c3f40
actions.py: Removed do_set_realm_message_deleting function.
...
Used do_set_realm_property function instead of
do_set_realm_message_deleting and removed it.
2020-07-24 11:51:47 -07:00
422fa0ff7d
audit_log: Log RealmAuditLog for do_set_realm_message_editing.
...
Log RealmAuditLog for do_set_realm_message_editing. Added tests for
same.
2020-07-24 11:51:46 -07:00
ea7effbe8a
recent_topics: Skip non-stream messages in update_topics_of_message_ids.
...
Fixes an exception when deleting a private message, introduced by
commit 5d5434ec2f#15803 ).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 10:58:21 -07:00
96f579287a
i18n: Tag markdown_help text for translation.
2020-07-24 10:54:34 -07:00
fdbab54614
i18n: Translate Edit/View Source button's hmtl tooltip text.
...
This commit tags the html tooltip text for internationalization.
2020-07-24 10:54:34 -07:00
6cbbdcf37d
mailmap: Fix the mailmap entry for Rishi Gupta.
...
Rishi never had a zulip.com email id. Giving preference to
zulip.com email id resulted in GitHub marking Rishi's commit
as anonymous. So we give preference to zulipchat.com instead,
which is linked to his GitHub account.
2020-07-24 10:51:47 -07:00
11a410e792
mailmap: Add mailmap entry for Reid Barton.
...
This is the email mentioned in commits that
are linked to Reid's GitHub account.
2020-07-24 10:51:47 -07:00
76b892fbc2
mailmap: Add mailmap entry for Scott Feeney.
2020-07-24 10:51:47 -07:00
cc3e7ac90a
mailmap: Add mailmap entry for Kevin Mehall.
...
Both the emails don't have an associated GitHub account,
but the entry will combine the the two accounts into one
in team page.
2020-07-24 10:51:47 -07:00
cb293f135e
mailmap: Add mailmap entry for Allen Rabinovich.
2020-07-24 10:51:47 -07:00
Anders Kaseorg
Tim Abbott
Gittenburg
Steve Howell
majordwarf
Vishnu KS
Alex Vandiver
arpit551
Vinit Singh