9d1f77edc5
saml: Use self.logger in get_issuing_idp.
...
get_issuing_idp is no longer a class method, so that akward logger
fetching can be skipped and self.logger can be accessed.
2020-07-26 15:48:48 -07:00
389c190d49
saml: Fix incorrect settings object being passed in get_issuing_idp.
...
Fixes #15904 .
settings is supposed to be a proper OneLogin_Saml2_Settings object,
rather than an empty dictionary. This bug wasn't easy to spot because
the codepath that causes this to demonstrate runs only if the
SAMLResponse contains encrypted assertions.
2020-07-26 15:48:48 -07:00
aba53551ec
test: Add order_by in query for RealmAuditLog.
...
Added order_by("id") clause in query for RealmAuditLog
for consistent output.
It was causing zerver.tests.test_audit_log.TestRealmAuditLog
to fail due to order mismatch.
2020-07-26 15:47:16 -07:00
28f5dfefea
dispatch tests: Use run_test.
2020-07-26 12:50:07 -04:00
d0378b07c7
dispatch test: Remove unneeded blueslip wrapper.
...
I think this became irrelevant when I moved some
of the code to dispatch_subs a couple months ago.
2020-07-26 12:50:07 -04:00
978c179e19
node tests: Tweak stream_sort to use run_test.
2020-07-26 12:50:07 -04:00
7c8dd45da3
node tests: Simplify message_list overrides.
2020-07-26 12:50:07 -04:00
0d68a23066
zjsunit: Handle duplicate overrides.
...
We want to undo overrides in reverse order,
which is important if you override the
same name more than once in the same
function.
Until today the code basically prevented
us from ever using the original implementation
of a name we stubbed, and most of them start
as undefined due to their parent modules
starting with `set_global`.
But I do want this proper, and I introduced
a tiny pitfall today.
2020-07-26 12:50:07 -04:00
10bb60e13d
node test: Use override in more places.
...
I also removed some useless stubs in passing.
2020-07-26 12:50:07 -04:00
c9bb6ab843
node tests: Simplify stream_events.
...
We use the new override helper passed in to
run_test.
2020-07-26 12:50:07 -04:00
ccfcd2c9ae
zjsunit: Have run_test pass in override helper.
...
The subsequent commits will make it more clear
how this helps.
2020-07-26 12:50:07 -04:00
b086e987b8
zjsunit: Prevent spurious function overrides.
...
If you use the with_overrides() helper, we will
now detect bogus stubs.
2020-07-26 09:25:40 -04:00
23e14124aa
zjsunit: Only allow functions for overrides.
...
There was only one place where we weren't
overriding a function, and the use case there
was fairly unique.
Knowing that we're dealing with only functions
will simplify override and allow us to add
features like detecting spurious stubs.
2020-07-26 09:25:40 -04:00
b8b2e31463
zjsunit: Require explicit set_global for overrides.
...
This forces us to more explicitly document at the
top of the file what dependencies we are stubbing,
plus it's less magical.
Also, we may want to do occasional audits of
set_global to clean up places where we mock
things like stream_data, which are probably just
easier to use the real version of now that we
have cleaner APIs to set up stream data.
The modules most affected by this change are our
dispatch-oriented tests--basically, all the
modules that test handling of Zulip events
plus hotkey.js.
2020-07-26 09:25:40 -04:00
128cda6acd
zjsunit: Restore functions in with_overrides.
...
Before we were making it impossible to reuse
the function again (so we were preventing
leaks), but it's fine to just restore the
original function, especially now that some
of our tests have grown bigger.
2020-07-26 09:25:40 -04:00
48bb432e4f
dispatch tests: Localize overrides.
2020-07-26 09:25:40 -04:00
7de8726000
dispatch tests: Remove obsolete noop stubs.
2020-07-26 09:25:40 -04:00
a6a9897abd
node fixtures: Clean up user_group data.
2020-07-25 17:55:57 -04:00
97c21ff4da
node fixtures: Add all flags for update_message_flags.
2020-07-25 17:55:57 -04:00
2462282631
node fixtures: Add users for various settings.
...
We should probably remove this field, as it
seems extraneous.
2020-07-25 17:55:57 -04:00
f22d0b8abe
node fixtures: Add op for custom_profile_fields.
2020-07-25 17:55:57 -04:00
b63c7d1cbb
node fixtures: Add more realistic data for typing.
2020-07-25 17:55:57 -04:00
b4a4f9d568
node fixtures: Add more realistic data for streams/subs.
2020-07-25 17:55:57 -04:00
7092cbf6f5
node fixtures: Add more realistic data for user events.
2020-07-25 17:55:57 -04:00
aad98aa6cd
node fixtures: Add more realistic data for bots.
2020-07-25 17:55:57 -04:00
0ed9a0fc58
eslint: Forbid imports from outside shared in shared.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-25 12:29:47 -07:00
7727dae441
shared: Add missing katex dependency to shared package.json.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-25 12:22:25 -07:00
5b0b1efb15
support: Add functionality to approve sponsorship requests.
...
This should make it much easier to process these requests.
2020-07-24 17:55:38 -07:00
d3834f8b9a
emails: Simplify requested by line in sponsorship email.
2020-07-24 17:39:46 -07:00
6b9c22b211
support: Add a header for scrub realm section.
2020-07-24 17:37:41 -07:00
1a1396d07e
support: Show customer plan details in support page.
2020-07-24 17:37:41 -07:00
f6cbb9177a
models: Add plan_name attribute to CustomerPlan.
2020-07-24 17:37:41 -07:00
38d01cd4db
puppet: Generalize install-wal-g to be arbitrary tarballs.
2020-07-24 17:24:57 -07:00
b900e38dc6
topic_list: Convert widget to an ES6 class TopicListWidget.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:58:22 -07:00
4517c48de2
todo_widget: Convert task_data_holder to an ES6 class TaskData.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:58:22 -07:00
c5e397d469
tictactoe_widget: Convert tictactoe_data_holder to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:58:22 -07:00
cd913b7ebc
sent_messages: Convert message_state to an ES6 class MessageState.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:56:28 -07:00
daf5a78e98
search_suggestion: Convert make_attacher to an ES6 class Attacher.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:56:28 -07:00
f96bd3839c
user_search: Convert user_search to an ES6 class UserSearch.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
41778d81d2
unread: Convert unread_topic_counter to an ES6 class UnreadTopicCounter.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
e5ff78e893
unread: Convert unread_pm_counter to an ES6 class UnreadPMCounter.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
44053eba3f
unread: Convert make_bucketer to an ES6 class Bucketer.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
557e88df77
pm_conversations: Convert recent to an ES6 class RecentPrivateMessages.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
2bf6731f5a
stream_topic_history: Convert per_stream_history to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
e47fd521e3
stream_list: Convert build_stream_sidebar_row to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
2aae92b6e3
stream_list: Convert stream_sidebar to an ES6 class StreamSidebar.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
0ad8da139e
stream_data: Convert BinaryDict to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
30e4b51731
stream_create: Convert stream_name_error to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
3319848768
stream_create: Convert stream_subscription_error to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
ba4ef5bf90
blueslip: Convert Logger to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:40:42 -07:00
Mateusz Mandera
palash
Steve Howell
Anders Kaseorg
Vishnu KS
Alex Vandiver