AZtheAsian
9c0ebc7359
eslint: change no-else-return to error and fix violations
2016-12-02 14:43:09 -08:00
Brock Whittaker
d8636980ae
settings: Convert bot and alert word settings to use new buttons.
2016-12-02 13:03:43 -08:00
Tim Abbott
d184288e00
css: Add box-shadow and bg-white components.
2016-12-02 13:03:43 -08:00
Tim Abbott
6e86515b15
css: Move display-none and inline-block to components.css.
2016-12-02 13:03:43 -08:00
Tim Abbott
a7681c3c2f
css: Move .light to components.css.
2016-12-02 13:03:43 -08:00
Tim Abbott
b61d6bc251
settings: Use new checkboxes and buttons in display settings.
2016-12-02 13:03:40 -08:00
Tim Abbott
e13a892479
settings: Remove unnecessary outer div from display settings.
2016-12-02 13:03:35 -08:00
Tim Abbott
85d6fdda4d
settings: Use new checkboxes and buttons in UI settings.
2016-12-02 13:03:32 -08:00
Brock Whittaker
51fbe4395d
settings: Use new checkboxes and buttons in notification settings.
2016-12-02 13:03:23 -08:00
Brock Whittaker
7fd15984fc
components: Add a new settings page checkbox.
...
This allows us to style checkboxes to be transparent boxes with green
borders.
2016-12-02 12:06:49 -08:00
Brock Whittaker
0e3332d86e
[Bootstrap]: Fix Null Case Issue.
...
This fixes the case in which `this` evaluates as null and throws an
error in TravisCI.
2016-12-02 11:58:53 -08:00
Brock Whittaker
2aa9512506
Add data-name to realm filter settings section.
...
This new settings section, was added into master but doesn't have the
correct data-name attribute to be called by the new modal.
2016-12-02 11:56:24 -08:00
AZtheAsian
ed0bc831be
eslint: change one-var from warning to error and fix violations
2016-12-02 11:25:16 -07:00
Tommy Ip
b3f4feb996
eslint: change max-len from warning to error and fix violations.
2016-12-02 14:16:33 +00:00
kevv87
e6369fc29b
eslint: change no-plusplus from warning to 2 and fix violations.
2016-12-01 14:27:17 -08:00
Tommy Ip
c90da24541
eslint: change keyword-spacing from warning to error and fix violations.
2016-12-01 14:22:15 -08:00
aakash-cr7
d99b17070e
edit: Fix traceback when saving edits to unsent messages.
...
7b0c6459b4
accidentally failed to update
one of the calleers of update_private_messages, resulting in this code
path failing consistently.
Fixes #2416 .
2016-12-01 10:39:43 -08:00
Tommy Ip
7b2c313f37
eslint: change brace-style from warning to error and fix violations.
2016-12-01 10:20:22 -08:00
Joy Chen
2784a3e27f
docs: Add user guide for Uploading and Sharing Files.
2016-11-30 22:30:56 -08:00
AZtheAsian
3c0ea4da6f
docs: Add user guide for *mention a team member*.
2016-11-30 19:41:49 -08:00
Brock Whittaker
4935f0c693
popovers: Hide actions popover once the muting button is clicked.
...
The popover shouldn’t still display once a valid action on the popover
has been taken.
Fixes #2366 .
2016-11-29 16:47:03 -08:00
Brock Whittaker
b837221e05
Fix for possible webkit painting bug.
...
The left sidebar will overflow its bounds (even when set to overflow:
hidden) and go behind other text on the sidebar above. By setting the
z-index to 0 we seem to solve the problem.
This is probably actually a webkit bug, but this makes it no longer
affect us.
Fixes #1899 .
2016-11-29 15:29:59 -08:00
Arpith Siromoney
f7dc2f33cd
Change name of eslintrc file to .eslintrc.json
...
Currently it does this for the eslintrc files in zulip,
zulip/frontend_tests and static/js
This commit also fixes json style issues (quotes)
2016-11-29 08:58:39 -08:00
Tim Abbott
3d1bcb05e1
tornado: Move event_queue.py to zerver/tornado/.
...
Fixes #729 .
2016-11-26 22:29:28 -08:00
Tomasz Kolek
9636d89de1
Add documentation for changing SITE param in jenkins configuration.
2016-11-26 19:30:45 -08:00
Calvin Lee
4e5c4c5ffb
streams: Add support for setting stream description during creation.
...
Add new box for stream description in the stream creation form,
modify backend so its contents end up as the stream description.
Fixes : #2283 .
2016-11-26 16:55:35 -08:00
Tomasz Kolek
a79acf854f
docs: Automate creation of Hubot documentation lozenges.
...
This removes a bunch of semi-duplicated code.
2016-11-26 15:27:54 -08:00
Steve Howell
604079a9d4
Fix formatting for Group PMs in the right sidebar.
...
We now sort users by the lower case value of their
full names in each of the links in the "GROUP PMs"
section of the right sidebar. We still use "+n others"
for big huddles.
2016-11-26 11:48:52 -08:00
Steve Howell
d953eca14c
Make group PMs reply-to's more consistent in case.
...
We now sort lists of users ids deterministically, and we also
sort list of emails deterministically and without regard to case.
This probably fixes the bug #2343 , although I never got a great
repro on that.
2016-11-26 11:48:52 -08:00
Steve Howell
578b276523
node tests: Add tests for message_store.js.
2016-11-26 11:48:52 -08:00
Steve Howell
af9ff9a030
Have unread.num_unread_for_person accept a user_id.
...
(It used to take an email as its parameter.)
2016-11-26 11:48:52 -08:00
Steve Howell
772571fd82
Use data-user-ids-string in Private Messages sidebar.
...
This commit also changed message_store.recent_private_messages
to use user_ids_string instead of reply_to.
2016-11-26 11:48:52 -08:00
Steve Howell
aadfe133e2
buddy list: Use user_ids in DOM list elements.
2016-11-26 11:48:52 -08:00
aakash-cr7
73fb9c6f66
Fix alignment of 'Not Delivered buttons' on smaller devices.
2016-11-26 10:13:48 -08:00
aakash-cr7
79b4ac8155
Add tooltips to buttons appearing when message is not delivered.
2016-11-26 10:13:48 -08:00
aakash-cr7
0525b65f90
Fix positioning of error message appearing on adding custom alert words.
...
Fixes #2413 .
2016-11-26 10:11:55 -08:00
Arpith Siromoney
29d3019262
Switch no-loop-func eslint rule from warning to error (in .eslintrc)
...
The one error that needed to be fixed was in static/js/echo.js.
The function in the loop was being used by _.each(). This has been
replaced by iterating through the array using a while loop instead.
2016-11-25 14:02:44 -08:00
Arpith Siromoney
497c7702cc
Run eslint in tools/lint-all with npm run --silent lint
...
This commit adds a basic eslintrc that emulates jslint defaults.
Rules that conflict with our existing code have been switched to
warnings instead of errors. Globals have been added to the eslintrc. The
bundled js file (generated by webpack) and blueslip.js are ignored with
.eslintignore.
To display warnings, run npm run lint-loud. This runs eslint without the
--quiet option on static/js and frontend_tests.
npm run --silent lint is run by tools/lint-all (in addition to jslint).
The --silent option is used to suppress the default output from npm run.
Fixes #535 .
2016-11-18 16:15:45 -08:00
Vladislav Manchev
d7e1e4a2c0
Add initial implementation of custom realm filters.
...
This PR was abandoned by Vladislav and then substantially modified by
Igor Tokarev and Tim Abbott to complete it and fix a number of bugs.
Fixes #544 .
2016-11-17 17:11:25 -08:00
Steve Howell
8f96853fcb
presence: Convert presence_info to use user IDs.
...
When we filtered buddy lists, a recent change introduced some
bugs related to case-insensitive emails. We now circumvent the
bug by indexing presence_info with user_ids.
2016-11-17 13:27:28 -08:00
Tim Abbott
9c3d448fe4
compose: Clarify @-all errors are about mentions.
...
Every message to that stream goes to that number of users :).
2016-11-17 12:35:35 -08:00
Brock Whittaker
5d2b81358c
Code Simplification and Emoji Drag Fix.
...
There’s no need for four separate `$(sel).is()` statements, one will
do. This also added .drag to the list to ignore.
2016-11-17 11:21:15 -08:00
Brock Whittaker
2663215625
Do not close message compose box on drag.
...
On the drag to resize emoji box action, do not close the message
compose box.
2016-11-17 11:21:15 -08:00
Steve Howell
82a497ec08
Remove spurious blueslip error for topic lists.
...
If we update an unread count for a topic that is not part of
our truncated list, we don't need to complain.
2016-11-16 22:01:30 -08:00
Brock Whittaker
9582079cd9
edit: Fix "View source" icon being orphaned post-hover.
...
It turns out it wasn’t a one-liner, it was actually a -2-liner. :)
2016-11-16 14:03:54 -08:00
Steve Howell
3b594a6efa
bug fix: Keep old, active, upper-case topics in the topic list.
...
If you narrowed to a topic that was not one of the most recent 5
topics and had uppercase characters, it would disappear from the
topic list as soon as all of its messages were read.
2016-11-16 12:17:31 -08:00
Steve Howell
f4bf154981
bug fix: Fix topic unread counts for upper-case streams.
...
If stream names weren't entirely lowercase, then our function
topic_list.is_for_stream() was improperly reporting false and
failing to update unread counts for the active topic widget.
This regression was probably introduced in the fairly recent
53eea250d0
commit.
Fixes #2330 .
2016-11-16 10:08:44 -08:00
Steve Howell
9eb825fff5
Refactor PM unread counts to use user_ids as keys.
...
We now use comma-delimited lists of user_ids for the following
data structures in unread.js:
- unread_privates[<user_ids_string>]
- get_counts.pm_count[<user_ids_string>]
2016-11-15 18:31:59 -08:00
Steve Howell
1783879108
people.js: Add methods for user_ids_string/emails_string.
...
Added:
* people.user_ids_string_to_emails_string
* people.emails_strings_to_user_ids_string
2016-11-15 18:31:59 -08:00
Steve Howell
7750d43d23
Simplify finding elements in pm_list.js.
...
We no longer need iterate_to_find, and we just use simpler
selectors.
2016-11-15 18:31:59 -08:00