Umair Khan
9b42b7fad3
Add tests for TestZulipRemoteUserBackend.
2016-10-25 08:13:35 -07:00
Umair Khan
9f37b9b386
Add tests for TestDevAuthBackend.
2016-10-25 17:57:33 +05:00
Tim Abbott
c970a87dfa
code-style: Fix broken links to anti for-in styleguides.
...
These two pages were moved over the last few years.
2016-10-24 11:10:25 -07:00
Rishi Gupta
28dd7080c7
docs: Add message editing policy to prod security section.
...
Fixes #1214 .
2016-10-23 20:20:34 -07:00
Tim Abbott
28cefc4996
hashchange: Fix buggy arguments to hashchanged causing scrolltop bug.
...
Because jQuery passes the actual hashchange event to an onhashchange
handler, the `if reload` checks in the `hashchanged` function were
always returning true, resulting in the wrong logic being used for
computing where to send the user in the event that they edited the
hash in the browser to change their narrow.
2016-10-23 20:07:12 -07:00
Tim Abbott
56c0b80067
nginx: Fix JavaScript not being compressed properly.
...
Apparently, we weren't actually compressing our JavaScript being sent
over the wire due to incorrect nginx configuration.
2016-10-23 20:06:02 -07:00
Tim Abbott
e714ddbfc8
gather_subscriptions_helper: Fix mypy error.
2016-10-22 22:37:05 -07:00
Tim Abbott
c59cdbb92d
gather_subscriptions: Fix missing subscriber data in email_dict.
...
When we added data on never_subscribed streams to what
populate_subscribers is called on, we failed to add the corresponding
data on subscribers to email_dict, the mapping of user IDs to emails
for the subscribers.
2016-10-22 21:37:05 -07:00
Tim Abbott
14018353fc
Fix never_subscribed streams being sent for Zephyr mirroring.
...
Because in the Zephyr world, stream names can be a secret, and also
Zephyr mirroring tends to involve many thousands of streams, we
shouldn't send this data.
2016-10-22 21:36:11 -07:00
Sumana Harihareswara
f86cd0aa26
docs: Fix style in authentication methods doc.
2016-10-22 20:14:56 -07:00
Sumana Harihareswara
04c8c9d5bd
docs: Updates to production customization guide.
2016-10-22 20:13:37 -07:00
Sumana Harihareswara
dd3a19ab58
docs: Clarify export_single_user.
2016-10-22 20:13:06 -07:00
Sumana Harihareswara
facf0ac1f3
docs: Add psql instructions.
2016-10-22 20:13:06 -07:00
Tim Abbott
893679baff
Add migration to remove system avatar source.
...
Fixes the last commit having broken master.
2016-10-22 20:07:21 -07:00
Tim Abbott
5bea2f5e20
Remove unused AVATAR_FROM_SYSTEM code.
...
This is some of the code we'd need if we wanted to have Zulip generate
avatars for things. Since it is so little useful code, and it's not
clear we will need this feature ever, we can remove this code to make
the codebase less confusing. It'd be easy to dig this out of history
if we ever want it.
Fixes #2101 .
2016-10-22 19:48:50 -07:00
Tim Abbott
c20011ccd5
docs: Remove unnecessary and broken SSO breadcrumb link.
2016-10-22 19:30:24 -07:00
K.Kanakhin
9492bd37b4
docs-test: Fix documentation links.
...
- Fix internal documentation links and anchors according last project documentation version.
Fixes #1492
2016-10-22 19:30:24 -07:00
Tim Abbott
a32eaf28c0
docs: Remove broken indices and tables index section.
...
None of these links worked properly.
2016-10-22 19:23:11 -07:00
Tim Abbott
4352790795
docs: Fix broken link in node testing docs.
2016-10-22 19:21:19 -07:00
umkay
87d22c9e4d
analytics: Fix count_stream_by_realm.
...
Add a join clause on zerver_message in count_stream_by_realm,
otherwise we only output the final total streamcount for a realm
for every time entry.
2016-10-22 19:10:36 -07:00
Rishi Gupta
49b23ea84a
frontend: Allow users to see the source of messages they can't edit.
...
Previously we showed an "Edit" item in the actions popover menu when a user
could edit the content or topic of a message, and nothing otherwise. We now
show "Edit", "Edit Topic", or "View Source" in the popover menu for every
message, depending on the editability of the message, and present an
appropriate version of message_edit_form when the menu item is clicked.
Finishes #1604 and #1761 .
2016-10-22 18:53:59 -07:00
Rishi Gupta
879f2a1e2e
message editing: Refactor editability computation to use editability_types.
...
We compute the editability of messages in several places around the
frontend; standardize the definitions and store in
message_edit.get_editability. This commit should not change app behavior.
2016-10-22 18:52:49 -07:00
Rishi Gupta
c2c389e949
message_edit.js: Refactor edit_message.
...
Cleanup and re-organize edit_message in preparation for the view source
changes. There are no behavior or logic changes in this commit.
2016-10-22 18:52:49 -07:00
Tim Abbott
bd416c0425
message_edit: Cleanup unnecessary 2-layer nesting.
2016-10-22 18:52:49 -07:00
Tim Abbott
5b3caa4d18
message_edit: Fix tooltip with multiple messages being edited.
...
This fixes an issue where if there were multiple messages being
edited, all of them would have the same tooltip content.
2016-10-22 18:52:49 -07:00
Tim Abbott
5b656db303
message_edit: Clean up tooltip creation code.
...
This contains no functional changes.
2016-10-22 18:52:49 -07:00
Tim Abbott
0ccf8b162e
message_edit: Move topic-editing-only warning.
...
This makes no functional change, because
`page_params.realm_message_content_edit_limit_seconds === 0` means
can_edit_content is always true.
2016-10-22 18:52:49 -07:00
Tim Abbott
d5c3ad8eb5
message_edit: Only initialize composebox_typeahead if needed.
2016-10-22 18:52:49 -07:00
Tim Abbott
76d49300b3
message_edit: Move original_topic variable to a better spot.
2016-10-22 18:52:49 -07:00
Tim Abbott
0acfcbe247
message_edit: Update currently_editing_messages in clearer place.
2016-10-22 18:52:49 -07:00
Tim Abbott
d2501396cf
message_edit: Reindent form definition.
2016-10-22 18:52:45 -07:00
Tim Abbott
2b58fa0a19
message_edit: Move some setup code closer to where it's used.
...
This has no functional changes.
2016-10-22 18:40:44 -07:00
Rishi Gupta
ebc8bfa6ca
javascript: Change all message.is_stream to (message.type === "stream").
...
We need message.is_stream for some handlebars template code, but
message.is_stream should be thought of as a private variable for that
template.
2016-10-22 18:11:08 -07:00
Steve Howell
c21fe60430
Add make_stream() to django testing docs.
2016-10-22 18:09:34 -07:00
Steve Howell
4d6af33bad
Use make_stream() in test_subs.py.
2016-10-22 18:09:34 -07:00
Steve Howell
2a739318b9
Use make_stream() in test_signup.py.
2016-10-22 18:09:34 -07:00
Steve Howell
8410159af2
Use make_stream() in test_narrow.py.
2016-10-22 18:09:34 -07:00
Steve Howell
b1ebb09c96
Use make_stream() in test_messages.py.
2016-10-22 18:09:34 -07:00
Steve Howell
0861421912
Use make_stream() in test_events.py.
2016-10-22 18:09:34 -07:00
Steve Howell
79b6f3d39d
Create ZulipTestCase.make_stream().
2016-10-22 18:09:34 -07:00
deekshaarul
be903382f8
lint: Add rule to check for misspellings of 'GitHub'.
2016-10-22 17:09:55 -07:00
K.Kanakhin
16c3da6db5
tests: Add tests for SEND_MISSED_MESSAGE_EMAILS_AS_USER=False.
...
- Add tests for SEND_MISSED_MESSAGE_EMAILS_AS_USER is False (the
default!).
- Reorganized test case code by removing repeated parts of code,
improving code style and moving common parts to separate class
methods.
Fixes #1697 .
2016-10-21 08:47:24 -07:00
Umair Khan
8891731d7d
is_template_database_current: Open file in write mode.
2016-10-21 08:35:30 -07:00
Umair Khan
b894135fae
Check postgres-init-dev-db in is_template_database_current.
2016-10-21 08:35:30 -07:00
Umair Khan
176825d335
Refactor is_template_database_current.
...
Now all the files whose hash is to be checked are passed as a list
argument.
2016-10-21 08:35:30 -07:00
Umair Khan
bf4e0800e3
is_template_database_current: Create hashes in var/test_db_status.
2016-10-21 08:35:30 -07:00
Umair Khan
a2c57db630
Use argparse in provision.py
2016-10-21 08:35:30 -07:00
Umair Khan
8ade9e2408
Add tests to check subdomains with auth decorators.
...
Fixes : #1870
2016-10-21 12:21:47 +05:00
Tomasz Kolek
6e1674aca5
Normalize github issue or PR comment event's subject and content.
2016-10-20 23:15:51 -07:00
Tomasz Kolek
56dd1a9b90
Normalize gitlab issue event's subject and content.
2016-10-20 23:15:30 -07:00