34e3329919
linter: Add rule against misspelled "Terms of Service".
2017-09-07 06:29:33 -07:00
ee6235d716
lint: Add regex to disallow i18n string concatenation.
...
Fixes #6398
2017-09-06 07:01:43 -07:00
7d5d8ac61e
lint: Add rule for spacing inside Handlebars translation tags.
...
This commit also includes the fixes to make all Handlebars templates
compliant with the new rule.
2017-08-23 13:08:57 -07:00
3a4c6f83fc
lint: Ban trailing spaces in Handlebars translation tags.
2017-08-23 13:08:57 -07:00
aa5f57fda9
lint: Ban leading spaces in Handlebars translation tags.
2017-08-23 13:08:57 -07:00
b32fe9f2a0
features: Update screenshot and add tool to generate.
...
This adds a new management command that should make generating or
updating screenshots a bit easier in the future.
2017-08-22 11:32:22 -07:00
ceccd0c0f6
lint: Accept mentions of specific Python versions.
...
We're about to do this (a) in a number of places mentioning
system packages like `python3-dev` to install, and (b) in the
shebangs of every script in the tree.
2017-08-15 17:30:31 -07:00
ffc1ceeaa4
lint: Ban use of get_stream in the rest of messages.py.
...
This will help avoid potential future security bugs.
2017-08-15 10:40:02 -07:00
c5f0478374
linter: Add trailing whitespace check for json files.
2017-08-15 09:28:11 -07:00
c546016964
portico: Add translations bundle to portico pages.
2017-08-10 10:21:53 -07:00
6ac6d6ff5d
mypy: Add note re mypy supporting only global type aliases.
...
https://github.com/python/mypy/issues/3145
2017-08-05 17:53:18 -07:00
353f6fdb88
mypy: Hoist RuleList type alias out of function.
2017-08-05 12:08:59 -07:00
3e9a85ecb2
onboarding: Add turtle reaction to an initial message.
2017-08-01 22:51:05 -07:00
53e4d8562b
lint: Add a lint check for bare `type: ignore`s.
2017-07-27 16:31:55 -07:00
d7766d7b6e
lint: Fix colors being randomized on every file with custom checks.
...
Now, each custom check language gets a consistent color.
2017-07-27 16:03:12 -07:00
8e2ec1cddc
portico: Update registration form placeholders.
2017-07-21 13:09:06 -07:00
af430fe24d
tools/linter_lib: Clean unused imports told by F401 pyflakes.
...
The ' # NOQA' comment is added so that the unused imports check (F401)
can still be run while still having the Mypy type check.
2017-07-20 16:46:07 -07:00
5cdfd61f2b
lint: Require translation tags on aria-label tags.
...
Since these are, by their nature, directly user-facing strings, they
should always be tagged for translation.
2017-07-14 14:48:17 -07:00
2dc35e6c11
linter: Update custom linters' visual output.
2017-07-05 23:31:09 -07:00
e0d4a007e8
linter: Add `identifier` argument to `custom_check_file` function.
...
In preparation for the upcoming linter output update, each custom
linter now has a identifier argument. This would be used for separating
each line of lints, eg:
py | Missing space around "%" at analytics/views.py line 485:
py | output += '<hr>%s\n'%(string_id,)
css | 64c64,65
css | < opacity: 1; }
css | ---
css | > opacity: 1;
css | > }
css | static/styles/lightbox.css seems to be broken:
swagger | In static/swagger/zulip.yaml:
swagger | Duplicate operationId: registerQueue
2017-07-05 23:23:45 -07:00
f60d4849b7
Revert "lint: Don't allow handlerbars within translatable text."
...
This reverts commit 3c7b9cdc94
2017-06-30 10:12:31 -04:00
3c7b9cdc94
lint: Don't allow handlerbars within translatable text.
...
Fixes : #5544
2017-06-29 07:39:20 -04:00
4ad951f256
integrations/perforce: Migrate docs to Markdown.
2017-06-26 12:30:04 -04:00
d45d9c9ab5
bots: Add linter rule to prevent open() calls.
...
Addresses #5395 .
2017-06-21 10:16:59 -04:00
fd41a481e4
linter: Fix `include_only` rule path comparison.
...
In order for the `include_only` linter rule to not have
any side effects, we need to explicitly add a trailing '/'
after every directory we want to include.
2017-06-21 10:16:59 -04:00
e49afe3ebc
lint: Add code to suggest removing exclusions.
...
If excluded lines no longer exist in a file, print a message
asking the user to remove the exclusion.
2017-06-21 08:12:58 -04:00
572ea370ea
Speed up custom checkers in `./tools/lint`.
...
The main thing here is to make looping over lines be the inner
loop, instead of looping over rules. This keeps regexes in
cache, and it also avoids some O(N) checks.
This is a significant speedup for me, reducing time from 16s
to 11s.
2017-06-20 22:26:12 -04:00
33c0c00cd6
Outgoing webhook System: first Iteration of outgoing webhook UI.
2017-06-19 16:05:54 -04:00
bbe7ef6c5e
linter_lib: Exclude webhook URLs from long line checks.
...
Now, URLs starting with `{{ external_api_uri_subdomain }}` are
exempted from the 120 char per line requirement.
2017-06-14 17:42:17 -07:00
fab20ec6fd
templates: Add macro for appending branch names to Git webhook URLs.
2017-06-05 11:20:48 -07:00
40a2ffad98
Extract tools/linter_lib/custom_check.py.
...
As part of extracting this, we exempt the library from all custom
checks on itself. This is expedient, since a lot of our
custom checks are naive about whether things are in strings, and
it is also a pain to configure individual rules.
2017-06-05 09:20:21 -07:00
Robert Hönig
Umair Khan
Yago González
Rishi Gupta
Greg Price
Tim Abbott
Jack Zhang
neiljp (Neil Pilgrim)
rht
Tommy Ip
Eeshan Garg
Steve Howell
vaibhav