Anders Kaseorg
e363382628
push_notifications: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
e24b2fdf06
markdown: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
d64f036247
outgoing_webhook: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
e3fc74fd20
event_queue: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
0d7539dc50
test_classes: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
813cee3e50
test_helpers: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
acd439dee8
test_events: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
c0bbdbcadf
test_messages: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
98cc4073ee
test_realm: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
e2965dcb52
test_signup: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
3a7a828139
test_auth_backends: Fix strict_optional_errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
d690cc32e1
test_decorators: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
c65e7772a7
test_logging_handlers: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
dd7082e466
test_narrow: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
3126243245
test_outgoing_webhook_system.py: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
26fe6be16a
test_service_bot_system: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
2a0e5616f1
test_slack_importer: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
489d73f63a
queue: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
6c9c12ee2d
add_new_realm: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
3885fdadce
realm: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
654a03c897
webhooks: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
1c47b69f78
autoreload: Move mypy ignore_errors to inline configuration.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
7e874a4d39
docs: Add missing mypy annotation.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
Anders Kaseorg
dbd1b56362
remote_server: Fix send_to_push_bouncer type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-05 11:53:45 -07:00
Anders Kaseorg
82f04810d5
requirements: Upgrade Python requirements.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-03 19:47:18 -07:00
jagansivam28
c5818a554a
avatar: Fix user avatar delete button bug.
...
Since we migrated to `image_upload_widget.hbs`
for upload widget's so we have to access those widget's elements
according to the `image_upload_widget.hbs` new CSS class names.
We need to access delete button element with
`#user-avatar-upload-widget .settings-page-delete-button`
not with old CSS id `#user_avatar_delete_button`.
2020-07-03 17:32:28 -07:00
jagansivam28
9164247733
settings CSS: Remove unwanted CSS in `settings.scss`.
...
When we extract common HTML template (`image_upload_widget.hbs` )
for user avatar, realm day/night logo and realm icon widget's
lot of new CSS are created to match image_upload_widget.hbs and
old CSS are preserved in `settings.scss`. This commit removes all
unwanted or unused CSS in `settings.scss`.
2020-07-03 17:32:28 -07:00
Tim Abbott
52676c0670
lint: Work around a pyflakes bug.
...
Without this change, pyflakes reports this exception:
pyflakes | zerver/worker/queue_processors.py:152:9 local variable 'e' is assigned to but never used
pyflakes | zerver/worker/queue_processors.py:155:81 undefined name 'e'
2020-07-03 17:24:36 -07:00
Anders Kaseorg
e014ea966a
eslint: Enable comma-dangle for functions.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-03 16:55:51 -07:00
Anders Kaseorg
a79322bc94
eslint: Enable prefer-arrow-callback.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-03 16:55:50 -07:00
Anders Kaseorg
960174408f
frontend_tests: Use named functions to mock constructors.
...
This will stop ESLint from replacing them with arrow functions, which
cannot be constructors.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-03 16:55:50 -07:00
Anders Kaseorg
615b7fcc2c
eslint: Enable arrow-body-style.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-03 16:55:50 -07:00
Anders Kaseorg
aa838ec4bc
openapi: Disable arrow-body-style for javascript_examples.js.
...
Tweaked by tabbott to add a comment explaining why.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-03 16:55:43 -07:00
Anders Kaseorg
b0253c5a2e
eslint: Enable arrow-parens.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-03 16:53:39 -07:00
Mateusz Mandera
d51afcf485
emails: Improve handling of timeouts when sending.
...
We use the EMAIL_TIMEOUT django setting to timeout after 15s of trying
to send an email. This will nicely lead to retries in the email_senders
queue, due to the retry_send_email_failures decorator.
smtlib documentation suggests that socket.timeout can be raised as the
result of timing out, so in attempts I'm getting
smtplib.SMTPServerDisconnected. Either way, seems appropriate to add
socket.timeout to the exception that we catch.
2020-07-03 16:52:50 -07:00
arpit551
294510c68a
docs: Update documentation for Bionic to Focal upgrade.
...
Added -d Flag in do-release-upgrade for Bionic to Focal upgrade.
The -d switch is necessary to upgrade from Ubuntu 18.04 LTS
as upgrades have not yet been enabled and will only be enabled
after the first point release of 20.04 LTS.
Source https://wiki.ubuntu.com/FocalFossa/ReleaseNotes
2020-07-03 16:51:51 -07:00
Steve Howell
ad8e79a22e
urls: Support simple user_id-based slugs.
2020-07-03 16:50:18 -07:00
Steve Howell
2574efde3d
urls: Support simple integer stream slugs.
...
Fixes #15402
2020-07-03 16:50:18 -07:00
sahil839
f73ecfc2f7
settings_panel_menu: Remove "settings-wrapper" class from jquery selectors.
...
This commit changes the jquery selector to remove "settings-wrapper" class.
There is no element in the templates with this class.
2020-07-03 16:48:06 -07:00
Tim Abbott
36f916af53
docs: Update description of how narrow positions works.
...
We no longer need to explain the legacy algorithm for positioning in
the home view.
Fixes #8994 .
2020-07-03 16:00:14 -07:00
Steve Howell
0b65abcdf5
pointer: Remove pointer from UserProfile.
...
Most of the changes here are just that we no
longer need to provide a value for pointer
when we create UserProfile objects.
2020-07-03 13:08:40 +00:00
Steve Howell
50cbe1b19b
minor: Rename var to max_message_id.
...
We are phasing out the concept of pointer.
2020-07-03 13:08:40 +00:00
Vishnu KS
97403a09d0
install: Create zulip user only if required.
...
Otherwise, the useradd command will fail during the DigitalOcean
1-Click App installation because the install script is called
twice during the whole process. Plus the Zulip install script
is designed to be idempotent and this bug compromises that.
2020-07-02 14:55:04 -07:00
Anders Kaseorg
e3835554a7
postgres-init-db: Read terminate-psql-sessions script as root.
...
Fixes #15646 .
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 14:54:36 -07:00
Gittenburg
3a973b15ee
settings: Fix modal out of screen on mobile.
...
For the email and full name modals we simply change width to max-width.
The password modal used a flex-row class for no apparent reason,
the class wasn't used anywhere else and removing it fixes the UI bug.
Fixes #15311 .
2020-07-02 13:47:26 -07:00
Anders Kaseorg
c08ee904d8
models: Add explicit id fields for better type checking.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 13:28:10 -07:00
Anders Kaseorg
9b7c6828ec
models: Annotate most field types.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 13:28:10 -07:00
Anders Kaseorg
8c64a14a31
markdown: Fix get_user_by_id type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 13:28:10 -07:00
Anders Kaseorg
3cc6055958
bulk_get_streams: Fix get_active_streams call.
...
get_active_streams takes a Realm, not its id.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 13:28:10 -07:00
Rohitt Vashishtha
a47a3defa9
minor: Tag a string for translation.
2020-07-02 10:59:17 -07:00