tamara
96e3ad9311
invite: Add copied confirmation tooltip on invite link.
...
Fixes #26872
2023-10-22 14:21:16 -07:00
Aman Agrawal
09ab0f3c18
bootstrap: Remove bootstrap-dropdown library.
...
Gear menu was the last piece of dropdowns which used this. Since
we migrated it to tippy, we don't need this library.
2023-10-21 10:54:32 -07:00
Aman Agrawal
e4ae826a47
inbox: Improve look of empty inbox view.
2023-10-20 17:13:33 -07:00
Aman Agrawal
af271be1bd
navbar-dropdowns: Use specific classes for everything.
...
Replaced element selectors with specific selectors, those that
remain are intentionally left.
This is to avoid inner-most selectors as element selectors.
The reason being is that browsers evaluate selectors from right
to left, meaning that every time a selector ends in an element,
the browser has to work that much harder whenever and wherever
on a page it encounters the element.
2023-10-20 12:36:39 -07:00
Aman Agrawal
2efc2a5eb5
gear_menu_dropdown: Use better class name for theme buttons.
2023-10-20 12:36:39 -07:00
Aman Agrawal
51797809c4
header-button: Add background effects to different states.
2023-10-20 12:36:39 -07:00
Aman Agrawal
f9e7b814d6
navbar-dropdown-menu: Use focus-visible instead of focus.
2023-10-20 12:36:39 -07:00
Aman Agrawal
961693c354
gear_menu: Extract common hidden-for-spectators.
...
This avoids double borders in spectator view.
2023-10-20 12:36:39 -07:00
Aman Agrawal
05a640300a
gear_menu_popover: Remove presentation role.
...
We want to remove their semantics from accessibility tree.
2023-10-20 12:36:39 -07:00
Aman Agrawal
64ff483e27
gear_menu_popover: Use semantically correct HTML structure.
...
Using `ul > li > ul > li` here since that's the correct structure.
2023-10-20 12:36:39 -07:00
Aman Agrawal
1e3e70576b
gear_menu: Extract the new gear and personal menu style as a theme.
...
This also fixes some misalignment happening at some widths for gear
menu. Like at XL widths for spectators.
2023-10-20 12:36:39 -07:00
Aman Agrawal
67ba59f6e8
dropdown_list: Remove not useful role=menuitem.
...
Since the parent `ul` has doesn't have role=menu and `ul/li` elements
don't need a be specified a role anyway. We don't need it.
2023-10-20 12:36:39 -07:00
Aman Agrawal
ffcf792cc9
gear_menu: Use navigate-link-on-enter class instead of role=menuitem.
...
The class name make more sense give what it does.
2023-10-20 12:36:39 -07:00
Aman Agrawal
246c1d7b4e
hotkey: Call click() on elements with menuitem role in popovers.
2023-10-20 12:36:39 -07:00
Aman Agrawal
7932d49956
gear_menu_popover: Allow user to focus on these items.
...
These don't have an href attribute to use tabindex to
enable focus.
2023-10-20 12:36:39 -07:00
Aman Agrawal
bc3d48616e
gear_menu: Migrate to use tippy.
2023-10-20 12:36:39 -07:00
Aman Agrawal
1e93540d3b
navbar: Use new icon for user list toggle.
...
This needs to be done along with gear menu for navbar to look nice.
2023-10-20 12:36:39 -07:00
Aman Agrawal
a7f328d593
gear_menu_popover: Remove small-font-size class.
...
We can apply the required CSS to directly the org types.
2023-10-20 12:36:39 -07:00
Aman Agrawal
5cbf8ad91a
gear_menu_popover: Format "About Zulip" item like other items.
2023-10-20 12:36:39 -07:00
Aman Agrawal
d75df10729
gear_menu_popover: Move *-theme class to the li element.
...
It will help us hide the whole `li` element instead of just
`a` tag for spectators.
2023-10-20 12:36:39 -07:00
Aman Agrawal
897c19d17d
css: Add box-shadow to navbar dropdown menu as per figma design.
2023-10-20 12:36:39 -07:00
Aman Agrawal
41c06e2989
CSS: Extract common CSS for .navbar-dropdown-menu.
2023-10-20 12:36:39 -07:00
Aman Agrawal
e95b105566
gear_menu_popver: Use link-item class for li elements.
2023-10-20 12:36:39 -07:00
Aman Agrawal
cac411abc9
gear_menu_popover: Use better class and id name for gear-menu.
2023-10-20 12:36:39 -07:00
Aman Agrawal
12ea256e47
gear_menu: Extract dropdown part of gear menu.
2023-10-20 12:36:39 -07:00
Aman Agrawal
063669a921
gear_menu: Use new icons.
2023-10-20 12:36:39 -07:00
Sayam Samal
24d74f68ee
compose: Show pronouns in compose typeaheads.
...
This commit adds the pronouns custom profile field to the typeaheads in
the composebox along with the necessary node tests.
Details of the implementation:
- Added logic to display pronouns in ( ) next to the user's name when
the user has a non-empty pronoun-type custom profile field.
- If multiple pronoun fields exist in the organization, the
implementation selects the one earlier in the list of custom profile
fields.
- No pronouns are displayed if the selected pronoun field is empty.
Fixes #26924 .
2023-10-20 12:30:21 -07:00
Aman Agrawal
61bf72d30e
empty_feed_notice: Style empty message feed similar to other views.
2023-10-20 12:29:45 -07:00
Karl Stolley
8e7265fbb4
left_sidebar: Correctly handle focus on views controls.
2023-10-20 12:27:19 -07:00
Karl Stolley
c3062e80bb
left_sidebar: Place redesigned icons in views popover.
2023-10-20 12:27:19 -07:00
Karl Stolley
2c8a688983
left_sidebar: Place redesign icons in condensed views.
2023-10-20 12:27:19 -07:00
Karl Stolley
4a8f2773a8
icons: Add remaining views icons.
2023-10-20 12:27:19 -07:00
Karl Stolley
9535b5dbe0
left_sidebar: Add informational tooltips to condensed icons.
...
Though there is currently no keyboard shortcut to advertise with
these icons, both the star and the @ icons now have informational
tooltips, to match other icons in the condensed view.
Fixes : #25902
2023-10-20 12:27:19 -07:00
Karl Stolley
24d300f3fd
left_sidebar: Tune icon sizes for condensed presentation.
...
This slightly increases the size of the clock for recent
conversations, and descreases the size of the left-aligned icon
for all messages.
Icon sizes in the expanded view are left untouched.
2023-10-20 12:27:19 -07:00
Karl Stolley
41635566fd
left_sidebar: Improve logic for showing Scheduled messages.
2023-10-20 12:27:19 -07:00
Karl Stolley
46ce408a5f
left_sidebar: Add a 3-dot menu to condensed views.
...
Co-Authored-By: Hardik Dharmani <Ddharmani99@gmail.com>
2023-10-20 12:27:19 -07:00
Karl Stolley
4dd1bf7e32
left_sidebar: Expand and condense the VIEWS navigation.
2023-10-20 12:27:19 -07:00
Karl Stolley
3e78a792c1
left_sidebar: Move initialize() to end of file.
2023-10-20 12:27:19 -07:00
Karl Stolley
458d6411b4
left_sidebar: Handle condensed icon unread states.
2023-10-20 12:27:19 -07:00
Karl Stolley
9f5ca4f6f7
left_sidebar: Set backgrounds on condensed icon visible and hover.
2023-10-20 12:27:19 -07:00
Karl Stolley
7774abfe04
left_sidebar: Structure Views header with standalone icons.
...
This also introduces a combo grid/flex layout, which will also be
applied to the DM and Streams headings.
Because there are now multiple classes referenced from the
Puppeteer tests, those selectors now include the expanded
navigation area's parent ID selector.
2023-10-20 12:27:19 -07:00
Aman Agrawal
66d70eb8bf
recent_view: Use more precise calculation for checking if row visible.
2023-10-20 10:10:19 -07:00
Aman Agrawal
a1ba142047
resize: Use correct id for recent view filter buttons.
...
This seems to have left out in the renaming of recent view from
recent table -> recent conversations -> recent view.
`recent_view_filters_height` being `0` resulted in table having
more height than it should have, so when focus was set on a
hidden row, it somehow scrolled the whole table.
2023-10-20 10:10:19 -07:00
Aman Agrawal
454e22068b
views_util: Remove duplicate call to resize filters height.
...
Added by mistake.
2023-10-20 10:10:19 -07:00
Prakhar Pratyush
e7275d7e64
compose_banner: Fix the incorrect translation tags.
...
This commit fixes the translation tags in
'automatic_new_visibility_policy_banner.hbs'.
The incorrect tags were introduced in 7c46085
.
2023-10-20 10:07:38 -07:00
Aman Agrawal
b6fb77525f
hello: Adjust padding in client logos to be similar to original design.
...
Since Vlad used zoom in the original design and we used transform
since zoom was not supported by all browsers, some details got
lost in transition.
2023-10-20 10:04:46 -07:00
Aman Agrawal
41f26aebd9
hello: Make cta icons have similar spacing to original design.
...
There were lost when we converted inline svgs to files.
2023-10-20 10:04:46 -07:00
Prakhar Pratyush
d1f82c47fd
compose_banner: Show banner when automatically follow or unmute topic.
...
When we send a message and that causes a topic to be automatically
followed or unmuted due to the automatic visibility policy settings,
we tell the user via a post-send-message compose banner.
The "notify_unmute" banner is not shown when the topic has already
been unmuted or followed due to these policies.
Fixes part of #26900 .
2023-10-19 10:13:04 -07:00
Hardik Dharmani
31b3f8762f
gear_menu: Add new SVGs.
...
These icons are used in the gear menu.
Added thirdparty after talking with Vlad.
2023-10-18 22:02:38 -07:00
Aman Agrawal
b542984869
personal_menu: Fix semantics of personal menu HTML structure.
...
Only valid tag inside `ul` is `li`. So, we use `ul > li > ul > li`
structure here.
2023-10-18 22:02:38 -07:00