Vaida
d5517bae36
Delete the old zulip.com "referrals" system.
...
This system hasn't been in active use for several years, and had some
problems with it's design. So it makes sense to just remove it to declutter
the codebase.
Fixes #5655 .
2017-07-07 14:59:18 -07:00
Vishnu Ks
fcd944447e
common.js: Don't set default password quality/length in frontend.
...
The min quality/length values are always available via data
attributes. So there is no point of specefying a default value
in common.js.
2017-07-07 14:48:06 -07:00
Vishnu Ks
f273e83a85
portico: Explain why password is weak to user.
2017-07-07 14:48:06 -07:00
Cory Lynch
75617d07de
search_suggestions: Prioritize recent huddles.
...
Fixes #5612 . What this specifically does is that if you are
typing a group PM, this logic iterates through the possible
search suggestions for the next autocomplete. If that suggestion
contains a group PM that already exists, then prioritize it with
the most recent one on top.
2017-07-07 12:12:30 -07:00
Cory Lynch
7efba29b0c
search_suggestions: Hide own name in huddle suggestions.
2017-07-07 12:12:30 -07:00
Vishnu Ks
9067890120
urls: Use POST for zerver.views.user_settings.set_avatar_backend.
...
The set_avatar_backend is changed from PUT to POST becuase this
is not idempotent.
2017-07-07 10:31:43 -07:00
Vishnu Ks
df5df76961
urls: Use POST for zerver.views.realm_emoji.upload_emoji.
...
The upload_emoji endpoint is changed from PUT to POST because
this endpoint is not idempotent.
2017-07-07 10:31:43 -07:00
Vishnu Ks
cf2dec539f
urls: Use POST for zerver.views.realm_icon.upload_icon.
...
This upload_icon endpoint is changed from PUT to POST becuase
this endpoint is not idempotent.
2017-07-07 10:31:43 -07:00
Aditya Bansal
c7ec7f98d9
compose.js: Use on() instead of deprecated bind().
2017-07-07 07:50:02 -04:00
Jack Zhang
16385db3d7
landing-page.js: Implement fuzzysearch and category filtering.
...
On /integrations.
For scalability and people who type fast, update_integrations is
debounced; the function will postpone its execution until after
50 milliseconds after it was last invoked.
2017-07-06 15:28:50 -07:00
Jack Zhang
3f9bfd2ae2
portico: Create search/catalog visuals in /integrations.
...
Responsive designs for the search bar, categories sidebar,
categories dropdown, and integration tiles.
2017-07-06 15:28:50 -07:00
Aditya Bansal
2b14714e3b
compose.js: Export send_message().
...
We do this in order to have the definition of send_message()
accessible to the outside world. This will help in testing
this function.
2017-07-06 17:44:27 -04:00
Abhijeet Kaur
343cb20d57
bots: Move "Add a new bot" to its own tab in settings UI.
...
"Add a new bot" UI used to be common in "Active bots" and
"Inactive bots". "Add a new bot" UI was below the list of all
active/inactive bots.
If there were more than a few bots was more than four, then the user
had to scroll down the entire list of bots to "Add a new bot", which
was annoying. This new model makes the UI look cleaner as well.
2017-07-06 09:24:28 -07:00
Brock Whittaker
1b616d761e
settings: Fix email input whitespace issue.
...
This fixes the issue where the email has whitespace potentially in the
input due to the HTML formatting.
2017-07-05 17:45:30 -07:00
Harshit Bansal
efc2df168c
subs: Fix the autocomplete suggestions while adding subscribers.
...
Earlier, the autocomplete was also showing the emails of the users who
were already subscribed to the stream.
Fixes : #4028 .
2017-07-05 13:22:07 -07:00
Harshit Bansal
598535717b
emoji_picker: Extract `add_scrollbar()` function.
...
Calling this function with an element will cause a `perfectScrollbar` to
be added to it.
2017-07-05 13:14:40 -07:00
Harshit Bansal
a6cd460f72
emoji: Rename `emoji.realm_emojis` to `emoji.all_realm_emojis`.
2017-07-05 13:02:41 -07:00
Harshit Bansal
29ff36cd2a
reactions: Don't send add/remove requests for deactivated realm emojis.
...
Eventually, we'll want to support unreacting to deactivated realm
emoji, but for now the issues around name conflicts mean we can't
really support that.
2017-07-05 13:02:20 -07:00
Harshit Bansal
c4ec9523fc
frontend: Make sure deactivated emojis don't appear for use anywhere.
...
Deactivated emojis should not appear at any of the following places for
use:
1: Emoji pickers.
2: Composebox autocomplete.
3: Custom emoji settings page.
2017-07-05 13:00:14 -07:00
Harshit Bansal
9e40f063d6
markdown: Use `active_realm_emojis` instead of `realm_emojis`.
...
We should use `active_realm_emojis` instead of manually checking for
deactivated emojis in `realm_emoji` dict.
2017-07-05 12:05:10 -07:00
Harshit Bansal
90f04062e7
emoji.js: Add `active_realm_emojis` dict.
...
This dict will hold all the realm emojis which have not been deactivated.
2017-07-05 12:05:10 -07:00
Vaida Plankyte
9b279072df
notifications.js: Use the singular 'they' pronoun.
2017-07-05 09:27:44 -07:00
Vaida Plankyte
5a3d3ae291
narrow.js: Use the singular 'they' pronoun.
2017-07-05 09:27:43 -07:00
David Coleman
77dc5df56a
uploads: Display year in attachments UI upload timestamp.
...
Modified timerender.js absolute_time() to include the
year in the returned time stamp string.
Fixes #5600 .
2017-07-04 16:13:20 -07:00
Franziska von der Goltz
98847937f4
realm: add mandatory topic setting on org level.
...
Lets organizations require users to specify a topic the discussion.
Fixes : #5164 .
2017-07-04 14:09:21 -07:00
Cory Lynch
b13265d135
util: Remove execute_early.
...
This function was removed in favor of loading everything in
ui_init.js. The asynchronous nature of jQuery 3 document-ready
events may cause an undesirable order in which these are executed.
2017-07-04 13:54:33 -07:00
Cory Lynch
effd7ef41f
server_events: Move initialization to ui_init.js.
2017-07-04 13:54:33 -07:00
Cory Lynch
e33b178054
message_store: Move initialization to ui_init.js.
2017-07-04 13:54:33 -07:00
Cory Lynch
25be3a402d
message_fetch: Move initialization to ui_init.js.
...
This involves modifying a casper test, because now
upon registration, there is one unread message.
2017-07-04 13:54:33 -07:00
Brock Whittaker
7d005919ca
portico: Improve detection of URL in product page JS.
...
The product page JS detects the page to run small bundle functions
but does not work correctly with language prefixes in the pathname,
such as /es/apps, so this properly detects that.
Fixes #5635 .
2017-07-03 10:22:38 -07:00
Harshit Bansal
d3d6712fa3
left-sidebar: Update the size of the scrollbar after narrowing to a stream.
2017-07-03 09:53:41 -07:00
Cory Lynch
30c7629212
Change code block typeahead to only sometimes close fence.
...
Fixes #5556 .
Some tests needed to be moved around to make sure the
stubbing wouldn't break future tests.
2017-07-03 11:05:18 -04:00
Cory Lynch
802ea9abf5
Refactor to delete mousewheel.js.
...
This old third party library added support
for a "mousewheel" event to detect scrolling.
However, it is not compatible with jQuery 3
and is obsolete now that there is a standard
"wheel" event that accomplishes the same thing.
2017-07-03 11:04:20 -04:00
Harshit Bansal
4cb8ac100a
emoji: Fix the title and alt text for unicode emojis.
...
Unicode emojis when rendered should display canonical short name.
Similarly, the alt text should be of the format `:<short_name>:`.
For both of these we currently display the actual unicode symbol.
As some systems don't have the fonts necessary for displaying them
properly, they are rendered as empty square blocks. This commit also
ensures that the markup generated for emoji generated by canonical
name and by an unicode emoji is same.
Fixes : #5555 .
2017-07-01 11:14:24 -07:00
Cory Lynch
8abbb6d781
search: Remove in:all token from suggestions.
2017-07-01 12:19:52 -04:00
Steve Howell
0f4b7496e1
Use _.each to set page_params values for update_dict events.
2017-07-01 08:50:50 -04:00
Aditya Bansal
28ec32d757
compose.js: Use get_subscriber_count in show_all_everyone_warning().
2017-06-30 19:57:14 +05:30
Umair Khan
4f33a650af
i18n: Use double lowdash instead of handlebars.
...
We do not allow handlebars within {{#tr}}{{/tr}}.
2017-06-30 10:12:31 -04:00
Steve Howell
ef815e9e79
Remove unused channel.abort_all().
2017-06-30 09:48:04 -04:00
Aditya Bansal
2be5046144
compose.js: Use stream_data.get_subscriber_count in message mentions.
...
In this commit we basically start using the get_subscriber_count
function from stream data to get subscriber count.
2017-06-29 10:34:47 -04:00
Aditya Bansal
7531a85c4d
stream_data: Add get_subscriber_count() function.
2017-06-29 10:34:47 -04:00
Aditya Bansal
7a0387e0b1
compose.js: Add return true for subscribed streams.
...
This is basically going to fix a regression which was introduced in
89090cd
which made code early return in case of subscribed streams.
2017-06-29 18:02:25 +05:30
Umair Khan
d44c62e894
update_starred: Make the status translatable.
2017-06-29 07:39:20 -04:00
Umair Khan
8921496ccc
message_list_view: Add starred_status to message objs.
...
This starred_status property can be used to provide the context in
the single_message.handlebars template to show the proper tooltip.
2017-06-29 07:39:20 -04:00
Steve Howell
9b75daaa60
Extract reactions.view.remove_reaction().
2017-06-29 07:19:52 -04:00
Steve Howell
e2ae4aeb16
Extract reactions.view.update_existing_reaction().
2017-06-29 07:19:52 -04:00
Steve Howell
8cf6ef95b1
Extract reactions.view.insert_new_reaction().
2017-06-29 07:19:52 -04:00
Steve Howell
791e489938
Use a proper context in insert_new_reaction().
...
Before this change, we were piggybacking fields on to the event
object, which coupled us to any other function that relies on
the event.
2017-06-29 07:19:52 -04:00
Aditya Bansal
84b52661bb
compose.js: Remove small piece of dead code.
...
In this commit we remove a small piece of dead code from
check_stream_for_send() function and also rename it to
check_unsubscribed_stream_for_send() which makes more sense.
2017-06-28 07:45:21 -04:00
Aditya Bansal
89090cd3af
compose.js: Refactor validate_stream_message_address_info().
...
In this commit we just refactor validate_stream_message_address_info
function to early return in case of stream_data.is_subscribed()
returns true.
2017-06-28 07:45:21 -04:00