Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
36,839 Commits 28 Branches 143 Tags 633 MiB
Commit Graph

10001 Commits

Author SHA1 Message Date
Rohitt Vashishtha 4b47d219db settings: Use correct label for signup notifications stream. 
When migrating to dropdown list widget, we incorrectly used the same label
for both realm_notifications_stream and realm_signup_notifications_stream.

This was introduced in b580baf682.
 2020-06-03 12:19:08 -07:00
SiddharthVarshney ecd383b53c css: Use SCSS nesting for `nav`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney ff75ea838f css: Reorder `nav .content` and `nav ul`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 3435396479 css: Reorder `nav .hamburger`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney dcbc4f8630 css: Reorder `nav.white`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney f57a512ab3 css: Use SCSS nesting for `nav li`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 2130c3018e css: Use SCSS nesting for `nav li`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney d4d326c827 css: Use SCSS nesting for `nav ul li`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney de4396661b css: Use SCSS nesting for `nav ul li.active`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney dcc658264c css: Reorder css related to `nav ul`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 948b54e519 css: Use SCSS nesting for `nav .logo`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney d21d13698e css: Reorder css for `nav .logo span`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 756722616e css: Use SCSS nesting for `nav .content`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 5009bedba4 css: Remove redundant css for `nav .logo span`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney e5c1be0584 css: Use SCSS nesting for `nav.white`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 3a81099972 css: Use SCSS nesting for `nav.white ul`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney f4f99e7ca6 css: Use SCSS nesting for `nav.white li`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 96db3fa650 css: Use SCSS nesting for `nav.white .brand.logo`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 70a025d08d css: Reorder `nav.white .hamburder`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney bfad22d128 css: Remove duplicate style. 2020-06-02 17:26:45 -07:00
Siddharth Varshney 1ac597c77e css: Use SCSS nesting for `.silver`. 2020-06-02 17:26:45 -07:00
Siddharth Varshney a10a78736d css: Reorder styles related to `.silver`. 2020-06-02 17:26:45 -07:00
Siddharth Varshney b29b7b8da1 css: Use SCSS nesting for `.float`. 2020-06-02 17:26:45 -07:00
Siddharth Varshney 8317bde30f css: Reorder css related to `h1` and `h2`. 2020-06-02 17:26:45 -07:00
Siddharth Varshney ea704c8c91 css: Use SCSS nesting for `a`. 2020-06-02 17:26:45 -07:00
Siddharth Varshney e520e82b04 css: Use scss nesting for `a.arrow`. 2020-06-02 17:26:45 -07:00
Siddharth Varshney cc71533b21 css: Reorder css for `a` tag. 2020-06-02 17:26:45 -07:00
sahil839 c4d3c03ad4 compose: Fix subscribing the user from mention warning. 
This commit fixes the bug for subscribing the user from mention
warning which was introduced in e52b544.

This is fixed by changing email to be passed as list to
'invite_user_to_stream'.
 2020-06-02 16:25:56 -07:00
Ryan Rehman cfc87e3925 message list: Move the `FetchStatus` object to MessageListData class. 
The reason for this change is that, this is where `Filter` and
actual tracking of what messages are contiguous lives. This
will be beneficial when we will to move to a model where we
cache `MessageListData` objects for a large number of views.
 2020-06-02 15:45:39 -07:00
sahil839 e52b544213 stream settings: Add pills in add subscribers input. 
This commit changes the stream settings UI for adding subscribers to
use our standard user pills in the input box, rather than just
plain-text email addresses.  This is important progress towards
removing display email addresses from the Zulip UI.

It also allows subscribing multiple users at the same time, which is a
nice improvement.
 2020-06-02 15:32:26 -07:00
Sahil Silare c4d0bd6445
settings: Fix last_active sorting in user settings. 
We were incorrectly accessing .id, not .user_id, on the people objects.

Fixes #15165.
 2020-06-02 12:07:09 -07:00
Puneeth Chaganti 788203778d tools: Use the correct logo path to generate bot avatar. 
Integrations can be configured with specific logo paths, which weren't
correctly being used for generating the bot avatars.
 2020-06-01 18:08:23 -07:00
Puneeth Chaganti bb37e4ef00 integrations: Remove corrupted png image in bitbucket docs. 2020-06-01 18:03:06 -07:00
sahil839 da4f80caaa subs: Update hash when unsubscribing from stream settings UI. 
Previously, the unsubscribe logic just called
exports.show_subs_pane.nothing_selected() if one had been viewing the
edit UI for a stream that the user just unsubscribed from, which
clears the selection, but didn't update the hash or do other cleanup
logic.

We should instead be calling stream_edit.open_edit_panel_empty(),
which is the appropriate function for this purpose (and has
exports.show_subs_pane.nothing_selected as a subroutine).
 2020-06-01 15:38:25 -07:00
sahil9001 328caf1ad5 api: Simplify format of realm_emoji author data. 
There's no reason to send data beyond the user `id` of the uploader,
and reason not to, as the previous model was both awkward when
`author=None` and resulted in unecessary parsing complexity for
clients.

Modified by tabbott to add the frontend changes and API documentation.

Fixes #15115.
 2020-05-31 17:44:50 -07:00
sahil839 2ab6767b73 events: Update person dict in event for do_change_user_role to send role. 
This commit changes the person dict in event sent by do_change_user_role
to send role instead of is_admin or is_guest.

This makes things much more straightforward for our upcoming primary
owners feature.
 2020-05-31 17:22:50 -07:00
Clara Dantas 080014abcc settings_users: Fix bot_list_widget not defined. 
Fix error thrown when creating a bot if the bot_list_widget
is not defined.
 2020-05-30 12:23:49 -07:00
sahil839 9fa60672e6 users: Modify update user API endpoint to accept role as parameter. 
This commit changes the update user API endpoint to accept role
as parameter instead of the bool parameters is_guest and is_admin.

User role dropdown in user info modal is also modified to use
"dropdown_options_widget".

Modified by tabbott to document the API change.
 2020-05-29 14:29:17 -07:00
Steve Howell 74c61984df Revert "buddy list: Adjust sizing calc for narrow mode." 
This reverts commit 9f5725d265.

I was trying to fix how we size the buddy list in
narrow mode, which was off by 10px, but my fix worsened
things for regular mode.

Also, somebody reported a traceback related to my fix.
I didn't fully research the traceback,
but I suspect it was related to some media-query settings
for small screens or due to a put-buddy-list-in-left-pane
setting.  (Basically, `$('#right-sidebar').position()` may
be undefined in some cases, and I wasn't handling that.)

After reverting this, we still have the original
off-by-10px bug that I was trying to fix, but I will
attempt to do that more cleanly in a separate commit.

This should make it so that in normal situations where
the buddy list is in the right sidebar, we will be
able to see the "Invite more users" link again.

I am still a little puzzled how I didn't catch this in
testing, but it was toward the end of a long PR, so
it could easily just be simple human error.

Fortunally, this regression was only on master for a
couple days, and users could still invite users via
the gear menu.
 2020-05-29 15:36:42 -04:00
Mateusz Mandera 88d501515e presence: Fix "Last active:" in buddy list when last presence is idle. 
Restored old behavior accidentally removed in
1ae07b93d8 (diff-e353fab8bea58b8746ec68c83aa39b36L48)

The server only remembers the most recent presence status update per
device. Meaning that, for instance, if the user only uses one client and
that client's last status update was IDLE, then the server only knows
that, doesn't know anything about the user's last ACTIVE time. Thus the
"active_timestamp" the server will serve about this user to the webapp
will be "undefined".
The old behavior was that for the sake of the "Last active: x ago"
status in buddy list popover, the latest status timestamp was used,
whether IDLE or ACTIVE.
The change linked about changed that to only pay attention to
ACTIVE. Thus, if the server doesn't remember any ACTIVE statuses, webapp
would show "Last active: More than 2 weeks ago", which was incorrect.

We restore the old behavior and further improvements can be made on top
of this.
 2020-05-29 13:26:34 -04:00
Siddharth Varshney 2666c1a605 css: Use SCSS nesting for `.help` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney caa3b21089 css: Reorder `.help .markdown` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney af505bc647 css: Use SCSS nesting for `.help .sidebar` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 0fa1e5b5f6 css: Use SCSS nesting for `.help .sidebar a` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney c70e53952c css: Use SCSS nesting for `.help .sidebar li` for portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 7040cc6a8a css: Merge `.help .sidebar.slide ul` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 5039b9ede4 css: Use SCSS nesting for `.help .sidebar.slide h2`. 2020-05-28 17:50:12 -07:00
Siddharth Varshney e609561ed4 css: Use SCSS nesting for `.help .sidebar h1`. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 42956cde19 css: Use SCSS nesting for `.help .sidebar h1.home-link`. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 74244a6d5b css: Use SCSS nesting for `.error_page .errorbox`. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 34a9147911 css: Use SCSS nesting for `center-block`. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 5f9d54a028 css: Use SCSS nesting for `.central-block .control-group`. 2020-05-28 17:50:12 -07:00
Siddharth Varshney c6d52afcff css: Use SCSS nesting for `.input-group` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney b1a6f6598b css: Use SCSS nesting for `.input-group.grid` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 4273577457 css: Use SCSS nesting for `.input-group label` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 67c41c88be css: Remove duplicate styles for `.input-group label`. 2020-05-28 17:50:12 -07:00
Siddharth Varshney b8c04c7f5e css: Reorder `.input-group` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney e8d7a590ce css: Use SCSS nesting for `.password-reset` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 10fbdab26c css: Merge `.password-reset` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney af2f9dcf6b css: Use SCSS nesting for `.password-reset .input-group` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 3d39a9d74e css: Reorder `.password-reset` related styles. 2020-05-28 17:50:12 -07:00
Siddharth Varshney f935afeaa6 css: Use SCSS nesting for `.top-links` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney cc4a4a7846 css: Use SCSS nesting for `.top-links a` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 6719835a89 css: Use SCSS nesting for `.footer-navigation` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 68b94bb434 css: Use SCSS nesting for `.main-headline-text` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney f6e70cefdf css: Use SCSS nesting for `.login-form` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 48873669e8 css: Use SCSS nesting for `.login-form, .register-form` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney cdbdffe92d css: Reorder `.login-form` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 51f5475ac8 css: Use SCSS nesting for `.login-page` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 22950a9287 css: Use SCSS nesting for `.history .sponsors` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 3f6ce5ffb1 css: Use SCSS nesting for `.contributors` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 9e4e608460 css: Use SCSS nesting for `.contributors .person` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney b524b09a37 css: Use SCSS nesting for `.team` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney a5b5294c82 css: Use SCSS nesting for `.team input` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 78d8006de5 css: Use SCSS nesting for `.team label` in protico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney f787b9054c css: Use SCSS nesting for `.team .bdfl` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney bfa18da1bf css: Use SCSS nesting for `team .bdfl .profile-picture` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 17197f7537 css: Use SCSS nesting for `.team .profile` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 0bc4760e21 css: Use SCSS nesting for `.portico-header` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney d1da18cd28 css: Use SCSS nesting for `.portico-header .dropdown` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 4bbb468a36 css: Use SCSS nesting for `portico-header .dropdown-pill` in porticos.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 0ccb3a3d02 css: Use SCSS nesting for `.portico-header .dropdown ul` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 6f1def6a29 css: Use SCSS nesting for `.portico-header .dropdown ul li` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney f04bfbed89 css: Use SCSS nesting for `.header-main` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 8670372543 css: Use SCSS nesting for `.header-main .logo` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 7c23da6abc css: Use SCSS nesting for `.footer` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney fb1427bc2f css: Use SCSS nesting for `.footer section` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney d389885fe4 css: Merge css for `.footer` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 83376b49da css: Use SCSS nesting for `.portico-container` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 6158d1e6ea css: Use SCSS nesting for `.landing-page` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 1e7dfdd48a css: Reorder `.landing-page` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney ab5dfdc25f css: Use SCSS nesting for `.api-details` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney f488c03ca1 css: Use SCSS nesting for `.integration` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney be0cd1dfc2 css: Use SCSS nesting for `.show-integral` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney ae3170c05f css: Use SCSS nesting for `a.title` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney 13fd68e749 css: Use SCSS nesting for `.help-box` in portico.scss. 2020-05-28 17:50:12 -07:00
Siddharth Varshney c3b12a41c4 css: Use SCSS nesting for `help-inline` in portico.scss. 2020-05-28 17:50:12 -07:00
Rohitt Vashishtha e509a13db0 minor: Remove outdated comment. 
This was fixed in 30ab261f91.
 2020-05-28 14:56:47 -07:00
Rohitt Vashishtha fba2708bbc settings_bots: Explicitly ignore delete event from live updates. 2020-05-28 17:10:51 -04:00
Rohitt Vashishtha 58b612a4f0 settings-users: Rerender bot rows on data change. 
Previously, we fiddled with the existing HTML to update the
state. Now, we can use list_render.render_item() to render
the complete item properly.
 2020-05-28 17:10:51 -04:00