Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
16,453 Commits 28 Branches 143 Tags 627 MiB
Commit Graph

16453 Commits

Author SHA1 Message Date
Jacob Hurwitz 0a76a609ec Fix bugs with handling of the empty narrow. 
An empty narrow (ie, the home view) can be represented in code as either
`None` or `[]` but we had incorrect handling that failed to fully
properly deal with either case.

(1) In `get_stream_name_from_narrow`, we failed to deal with `None` by
trying to always iterate over `narrow`.
(2) In several other places, we failed to deal with `[]` by explicitly
checking `if narrow is None` or `if narrow is not None`. Changing these
to truthiness checks should work for both the `None` and `[]` cases.
 2017-03-19 11:47:03 -07:00
Daw-Ran Liou f67751d1f0 Add hotkey "l" for opening image in lightbox. 
Open the lightbox in the current selected message. Only the first image
shows in the lightbox.
 2017-03-19 11:43:21 -07:00
Tim Abbott e9f1531fc7 hotkey: Remap v hotkey -> P. 2017-03-19 11:41:02 -07:00
Steve Howell eda046409c Move paging methods into navigate.js. 2017-03-19 11:05:46 -07:00
Steve Howell d026344b37 Extract js/ui_util.js. 2017-03-19 11:05:45 -07:00
Steve Howell 099f401b9b Move mark_subscribed/mark_unsubscribed to stream_events.js. 2017-03-19 11:05:45 -07:00
Steve Howell b98cd55ddb Add ui_report shim. 2017-03-19 11:05:44 -07:00
Steve Howell c67aebf633 Move keep_pointer_in_view() to message_viewport.js. 2017-03-19 10:56:09 -07:00
Steve Howell 1d7d6869c9 Extract stream_events.js 2017-03-19 10:56:09 -07:00
Steve Howell cfd1e8cbc3 Extract stream_muting.js. 2017-03-19 10:56:09 -07:00
Steve Howell 5b2407bb22 Add ui_state.home_tab_obscured() shim. 2017-03-19 10:56:09 -07:00
Steve Howell ab34b5ee9f Extract ui_init.js. 2017-03-19 10:56:09 -07:00
Yago González a5ecb5e5cf docs: Fix minor link formatting. 2017-03-19 09:16:06 -07:00
Akash Kothawale 93a00d9772 docs: Add missing backtick in architecture-overview. 2017-03-19 09:12:14 -07:00
Yago González 30c0023847 docs: Explain Python 2/3 virtualenvs. 2017-03-19 08:56:19 -07:00
Steve Howell 203ced0ee6 minor: Rename var in filter_emojis(). 2017-03-19 06:25:10 -07:00
Steve Howell 6f3f031791 Make visualizer tool scan each file just once. 
Rather than having a bunch of regexes to look for, we just
have a single regex for a function call.  And now we process
line by line, which allows us to more easily ignore comments.
 2017-03-19 06:25:10 -07:00
Cynthia Lin 037eca4d64 Add Pygments syntax highlighting info to *Message formatting* modal. 2017-03-18 20:48:01 -07:00
Cynthia Lin 8241f7b40b user docs: Update *Format your message using markdown* with Pygments. 
Fixes #4081
 2017-03-18 20:48:01 -07:00
Rishi Gupta 6ba11785ea js dependencies: Change hashchange_encode to hash_util_encode in zerver. 
This function formerly replicated the behavior of hashchange.encode, and now
replicates the behavior of hash_util.encode.
 2017-03-18 20:40:34 -07:00
Rishi Gupta 19d8d16126 js dependencies: Split hash_util.js from hashchange.js. 2017-03-18 20:40:34 -07:00
Tim Abbott 767f57ef03 tests: Remove imports of deleted message_ids. 2017-03-18 20:40:34 -07:00
K.Kanakhin 3e397090e1 user-presence: Add client info to aggregated presence status. 
Fixes zulip/zulip-android#454.
 2017-03-18 20:36:41 -07:00
Tim Abbott 4dbb17db64 test_helpers: Remove unused message_ids function. 2017-03-18 19:22:49 -07:00
Elliott Jin 1138057209 test-backend: Raise zerver/views/registration.py test coverage to 100%. 2017-03-18 18:11:59 -07:00
Elliott Jin 25d9aac016 registration.py: Don't catch exception that can't be thrown. 
A previous commit changed a `get` (which can throw `DoesNotExist`) to use an
existing object, but kept the `try` / `except` block:

4bf3ace444

Removing this unused code path allows us to achieve 100% test coverage.
 2017-03-18 18:11:59 -07:00
Elliott Jin 8cfc231d03 tests: Raise zerver/views/registration.py test coverage (part 2). 2017-03-18 18:11:59 -07:00
Jacob Hurwitz 8ab88f5aad Remove hack for old mobile clients 
This FIXME was added in 50d229fe11.
Considering it's been more than 4 years, we can probably safely remove
it now.
 2017-03-18 18:11:17 -07:00
Jonathan Pan ceffe2128d activity: Clear search box after clicking a user in right sidebar. 
Fixes #4105.
 2017-03-18 16:15:14 -07:00
Susan Salituro a2689d6952 message.py: Delete unused function. 2017-03-18 16:08:36 -07:00
Steve Howell 16a37754cf Add recipient() and composing() shims. 2017-03-18 15:52:50 -07:00
Steve Howell 27f37e6378 Add hash_util.encodeHashComponent() shim. 2017-03-18 15:52:50 -07:00
Steve Howell d75efa19db Add compose_state.has_message_content() shim. 2017-03-18 15:52:50 -07:00
Steve Howell 59fd9e4d48 Add compose_actions.cancel() shim. 2017-03-18 15:52:50 -07:00
Steve Howell faa9446e64 Add compose_actions.start() shim. 2017-03-18 15:52:50 -07:00
Steve Howell 35d38d62f3 Add shim.js w/narrow_state global. 2017-03-18 15:52:50 -07:00
Luke W Faraone 68e7a8a824 Show stream properties on subscription in Zephyr. 
On realms with ``should_list_all_streams() == False``, previously, we
would subscribe a user to a stream, but also incorrectly show the stream
creation dialog.

Instead, we act as if the stream was newly created.
 2017-03-18 15:51:27 -07:00
Elliott Jin fde1aa506b tests: Prevent misuse of assert_in_success_response. 
Changing assert_in_success_response to require List[Text] instead of
Iterable[Text] prevents the following misuse:

    self.assert_in_response_success("message", response)

Currently, this will check whether 'm', 'e', 's', 'a', and 'g' separately
appear in the response, which is probably not the intended behavior.  The
correct usage is as follows:

    self.assert_in_response_success(["message"], response)
 2017-03-18 15:49:35 -07:00
Susan Salituro a2d948f2e0 test_messages: Add test for invalid markdown format. 2017-03-18 14:35:53 -07:00
Jeremy Philemon 9e47ec2270 Made the development environment login page nicer. 
- The buttons now have a flat look (dropped the border-radius) with a
white background color.
- The font colors now match the darker green shade of the navbar.
- The border-colors match the lighter green shade of the navbar.
- Green is used for all the normal user buttons, while the admin
buttons are a nice blue.
- I’ve `git grep`d to confirm that changes in .btn-direct only affect
the buttons on login.html

Fixes part of #4106.
 2017-03-18 14:31:19 -07:00
Tim Abbott f67e9a7e5e CSS: Rename #overlay to #lightbox_overlay. 2017-03-18 13:54:11 -07:00
Tim Abbott ed90879602 js: Extract lightbox.js from ui.js. 2017-03-18 13:54:11 -07:00
Steve Howell a51caceea5 refactor: Extract unread_ops.js 
This module mostly contains the mark_* functions that
update the server with info about unread counts.
 2017-03-18 10:35:52 -07:00
Steve Howell 0c6fefba71 Move get_cleaned_pm_recipients() to helper module. 
This break's typeahead_helper's dependency on
composebox_typeahead.
 2017-03-18 10:35:52 -07:00
Steve Howell 7f43c0504b refactor: Rename fields for split_by_subscribers(). 
The old name 'subs' was confusing our tooling, since we have
a module called subs.js.
 2017-03-18 10:35:52 -07:00
Steve Howell 7b1bfd6703 Break typeahead_helper's dependency on compose.js. 
We now have typeahead_helper's callers pass in compose.stream()
when it's needed for sorting purposes.
 2017-03-18 10:35:52 -07:00
Steve Howell 166f149ef9 refactor: Add current_stream parameter to functions. 
This change makes our dependency on compose.stream_name() happen
in sort_recipients, so we compute it only once, and we can
more easily break the circular dependency.
 2017-03-18 10:35:52 -07:00
Jeremy Philemon f6d01c8232 CSS: Make registration form responsive on <495px screen width. 2017-03-18 08:15:28 -07:00
Jeremy Philemon f68529e56c Add exit class to the cancel button in invite_user.html. 
- Previously, in the invite users modal, the click event of Cancel
(button) triggered the submit-invitation event. (Naturally, if the form
is empty, this throws the validators and doesn’t exit the modal).
- This fixes the abnormal action by including the ‘exit’ class to the
cancel button in invite_user.html, line 36.
 2017-03-18 08:12:57 -07:00
adnrs96 d172ea66c6 Clean pygments.css to use 4 space indents. 2017-03-18 08:06:19 -07:00