zulip

Commit Graph

Author	SHA1	Message	Date
Joshua Pan	c4914eeec9	narrow.js: Create narrowed_by_stream_reply(). This function returns if you are narrowed to a stream.	2017-06-27 14:06:59 -04:00
Steve Howell	252d0a6e15	Use stream_data.get_name() in narrow_state.stream(). Using get_name() is more robust for stream name changes. This fixes, for example, the situation where you narrow to a stream, edit it via the sidebar, and then close the modal, and the message redraw logic thinks you have unsubscribed. Fixes #4686.	2017-05-13 21:59:08 -07:00
Steve Howell	8eb86335b9	Extract narrow_state.js. Despite the length of this commit, it is a very straightforward moving of code from narrow.js -> narrow_state.js, and then everything else is just s/narrow.foo()/narrow_state.foo()/ (with a few tiny cleanups to remove some code duplication in certain callers). The only new functions are simple setter/getters that encapsulate the current_filter variable: narrow_state.reset_current_filter() narrow_state.set_current_filter() narrow_state.get_current_filter() We removed narrow.predicate() as part of this, since it was dead code. Also, we removed the shim for narrow_state.set_compose_defaults(), and since that was the last shim, we removed shim.js from the app.	2017-04-25 09:57:32 -07:00

Author

SHA1

Message

Date

Joshua Pan

c4914eeec9

narrow.js: Create narrowed_by_stream_reply().

This function returns if you are narrowed
to a stream.

2017-06-27 14:06:59 -04:00

Steve Howell

252d0a6e15

Use stream_data.get_name() in narrow_state.stream().

Using get_name() is more robust for stream name changes.  This
fixes, for example, the situation where you narrow to a stream,
edit it via the sidebar, and then close the modal, and the message
redraw logic thinks you have unsubscribed.

Fixes #4686.

2017-05-13 21:59:08 -07:00

Steve Howell

8eb86335b9

Extract narrow_state.js.

Despite the length of this commit, it is a very straightforward
moving of code from narrow.js -> narrow_state.js, and then
everything else is just s/narrow.foo()/narrow_state.foo()/
(with a few tiny cleanups to remove some code duplication
in certain callers).

The only new functions are simple setter/getters that
encapsulate the current_filter variable:

    narrow_state.reset_current_filter()
    narrow_state.set_current_filter()
    narrow_state.get_current_filter()

We removed narrow.predicate() as part of this, since it was dead
code.

Also, we removed the shim for narrow_state.set_compose_defaults(),
and since that was the last shim, we removed shim.js from the app.

2017-04-25 09:57:32 -07:00

3 Commits