zulip

Commit Graph

Author	SHA1	Message	Date
Eeshan Garg	31986d1b94	github_webhook: Update "pull_request unassigned" event fixture. The older fixture for this event assumed that the "assignee" key had a value of '{}' if no one was assigned to a PR anymore. However, that is no longer true because testing with requestbin showed that in the latest JSON payload for this event, the key "assignee" now has the value of 'null' (None when converted to Python) when a user is unassigned from a PR. The current code didn't handle this correctly. This commit makes sure it does! Its unclear as to whether the old fixture was simply wrong or whether GitHub changed its payloads in any way.	2017-08-24 16:48:00 -07:00
Eeshan Garg	597db11a98	webhooks: Rename webhook fixtures to only include event type. All webhook fixtures have now been renamed from <webhook_name>/fixtures/<webhook_name>_<event_type>.json to <webhook_name>/fixtures/<event_type>.json.	2017-05-13 20:07:40 -02:30

Author

SHA1

Message

Date

Eeshan Garg

31986d1b94

github_webhook: Update "pull_request unassigned" event fixture.

The older fixture for this event assumed that the "assignee" key
had a value of '{}' if no one was assigned to a PR anymore.
However, that is no longer true because testing with requestbin
showed that in the latest JSON payload for this event, the key
"assignee" now has the value of 'null' (None when converted to
Python) when a user is unassigned from a PR. The current code
didn't handle this correctly. This commit makes sure it does!

Its unclear as to whether the old fixture was simply wrong or
whether GitHub changed its payloads in any way.

2017-08-24 16:48:00 -07:00

Eeshan Garg

597db11a98

webhooks: Rename webhook fixtures to only include event type.

All webhook fixtures have now been renamed from
<webhook_name>/fixtures/<webhook_name>_<event_type>.json to
<webhook_name>/fixtures/<event_type>.json.

2017-05-13 20:07:40 -02:30

2 Commits