zulip

Commit Graph

Author	SHA1	Message	Date
Tim Abbott	5c0730d7ca	reactions: Fix check for valid emoji. The previous logic did not correctly handle the case where there were realm emoji (non-realm emoji would be inaccessible).	2016-12-30 17:51:31 -08:00
Juan Verhook	535ce90272	mypy: Convert zerver/views to use typing.Text.	2016-12-26 13:43:09 -08:00
Arpith Siromoney	226e3cbf02	Reactions backend: make endpoints more REST-ful. Adding a reaction is now a PUT request to /messages/<message_id>/emoji_reactions/<emoji_name> Similarly, removing a reaction is now a DELETE request to /messages/<message_id>/emoji_reactions/<emoji_name> This commit changes the url and updates the views and tests. This commit also adds a test for invalid emoji when removing reaction.	2016-12-07 22:28:02 -08:00
Arpith Siromoney	4491ea8d6b	reactions: Add support for removing emoji reactions. This commit adds support for removing reactions via DELETE requests to the /reactions endpoint with parameters emoji_name and message_id. The reaction is deleted from the database and a reaction event is sent out with 'op' set to 'remove'. Tests are added to check: 1. Removing a reaction that does not exist fails 2. When removing a reaction, the event payload and users are correct	2016-12-02 16:39:53 -08:00
Arpith Siromoney	001847ac5b	Add backend support for emoji reactions. This commit adds the following: 1. A reaction model that consists of a user, a message and an emoji that are unique together (a user cannot react to a particular message more than once with the same emoji) 2. A reaction event that looks like: { 'type': 'reaction', 'op': 'add', 'message_id': 3, 'emoji_name': 'doge', 'user': { 'user_id': 1, 'email': 'hamlet@zulip.com', 'full_name': 'King Hamlet' } } 3. A new API endpoint, /reactions, that accepts POST requests to add a reaction to a message 4. A migration to add the new model to the database 5. Tests that check that (a) Invalid requests cannot be made (b) The reaction event body contains all the info (c) The reaction event is sent to the appropriate users (d) Reacting more than once fails It is still missing important features like removing emoji and fetching them alongside messages.	2016-11-26 18:10:21 -08:00

5 Commits