4 Commits

Author	SHA1	Message	Date
Steve Howell	93471ed3e4	refactor: Extract can_toggle_subscription(sub). ... We don't want to rely so much on calculated fields, and the `should_display_subscription_button` name is a bit misleading in certain contexts.	2021-04-05 09:52:19 -07:00
YashRE42	dc02d4550f	narrow_banner: Refactor first_operand conditionals to use switch/case.	2021-04-01 07:38:39 -07:00
YashRE42	f85f0c4b0b	narrow_banner: Refactor empty banner is: operands to use switch/case.	2021-04-01 07:38:39 -07:00
Steve Howell	c67f82b073	refactor: Extract narrow_banner module. ... This is a mostly verbatim extraction. I re-phrased one line of code to work around a lint false alarm. (Look for `preamble` in the diff.) There are about 8 lines missing coverage here, so the new module might be a good candidate to get 100% line coverage on. Before this change, you would need to remove 74 edges from our dependency graph to make it acyclic. Now it's 72.	2021-03-28 15:55:55 -07:00