Tim Abbott
a64a1de023
lint: Be more permissive with Markdown links.
2017-01-12 16:42:51 -08:00
Tim Abbott
3f8d4193da
lint: Fix % comprehensions being used without a tuple.
2017-01-09 11:45:11 -08:00
sinwar
3f350391ce
docs: Ban the term realm from user documentation.
...
Fixes #3031 .
2017-01-09 10:58:19 -08:00
Tim Abbott
3a64857a4c
lint: Fix long lines not being treated as actual errors.
...
This led to Travis CI not reporting on line-too-long errors.
2017-01-08 22:48:27 -08:00
Tim Abbott
b54f8b3b14
lint: Fix incorrect line length calculations in Python 2.
...
Previously, we would incorrectly be counting bytes in Python 2, which
meant lines with unicode characters in them appeared to the linter to
be far longer than they actually were.
2017-01-08 22:46:02 -08:00
Tim Abbott
a39643da61
lint: Require space after likely ends of sentences in help.
2017-01-06 11:18:45 -08:00
Tim Abbott
1262db40ea
lint: Check for invalid '!!! warning'.
2017-01-05 15:15:19 -08:00
Tim Abbott
8b839c96d4
lint: Check for long lines in all markdown files in general.
...
This has a few excludes for cases involving code blocks where it would
have been difficult to clean up.
2017-01-05 15:06:34 -08:00
Tim Abbott
bc4a9ff722
lint: Enforce no lines longer than 120 characters in help docs.
...
This requires some somewhat messy changes to the all-streams macro.
2017-01-05 14:54:04 -08:00
Tim Abbott
a0f3f3dfa0
lint: Forbid script tags in handlebars templates.
2016-12-30 12:43:56 -08:00
Tim Abbott
39f0ffdedd
Move static/third/gemoji to static/generated/emoji.
...
Fixes #1153 .
2016-12-27 20:16:23 -08:00
Tim Abbott
726e2649b4
lint: Run linters on settings.py files.
...
This finishes clearing unnecessarily excluded items from the global
tools/lint-all exclude list. The remaining items are third-party code
or generated code that doesn't make sense to lint.
Fixes #822 .
2016-12-27 19:53:44 -08:00
Tim Abbott
d47ea7a608
lint: Add comments to EXCLUDED_FILES entries.
2016-12-27 19:48:43 -08:00
Tim Abbott
f46d99ba85
lint: Remove zerver/migrations from main exclude list.
2016-12-27 19:45:33 -08:00
Tim Abbott
ab89664d90
lint: Clean up main exclude list and move to pyflakes.
2016-12-27 19:45:33 -08:00
Tim Abbott
1c5e8cd47b
lint: Check for spelling of organization and fix errors.
2016-12-27 17:25:01 -08:00
Sampriti Panda
c0326d1938
Add lint rule to disallow python calls with versions (e.g: python2, python3)
...
Fixes #2435
2016-12-19 08:00:48 -08:00
Tim Abbott
81dbf8c80a
lint: Enforce no external resources in CSS.
2016-12-15 22:02:10 -08:00
Umair Khan
d85e85c9eb
linter: Add rule to check title attribute for i18n.
...
Fixes #2698
2016-12-15 13:44:13 -08:00
reallyly
94b28e0afb
pep8: Fix E128 violations.
...
With some line-wrapping tweaks by tabbott.
2016-12-13 10:50:14 -08:00
Tim Abbott
90f76c079d
lint: Require space after headings in markdown.
2016-12-07 17:15:53 -08:00
Tim Abbott
279d160f99
lint-all: Fix markdown_whitespace_rules indentation.
2016-12-07 17:15:47 -08:00
bulat22101
a6f91064a2
pep8: Fix E129 violations
2016-12-03 10:56:36 -08:00
bulat22101
adebc75740
pep8: Fix E502 violations
2016-12-03 10:56:36 -08:00
Tim Abbott
8259adaba5
lint: Add custom lint check for console.log statements.
...
This was previously checked for by jslint, and eslint doesn't seem to
have a nice exclude rule for it.
2016-12-02 20:05:18 -08:00
kevv87
1fb9220354
lint: Remove old jslint linter.
...
Now that we're using eslint, jslint is no longer required.
2016-12-02 18:49:42 -08:00
Sidhant Bhavnani
8c0c12c1d9
pep8: Fix E303 violations.
2016-12-02 15:34:11 -08:00
Alex Huang
007b693cc7
pep8: Fix E131.
2016-12-01 23:16:47 -08:00
Alex Huang
c8ddea16c3
pep8: Fix E122.
2016-12-01 23:16:35 -08:00
AZtheAsian
62494eeb97
pep8: fix E201 violations
2016-12-01 23:06:02 -08:00
AZtheAsian
7e14fe65ab
pep8: fix E202 violations
2016-12-01 23:06:02 -08:00
AZtheAsian
1ba150fa85
pep8: Fix E203 violations
2016-12-01 20:37:57 -08:00
AZtheAsian
c23f9e0df7
pep8: Fix E111 violations
2016-12-01 14:18:11 -08:00
AZtheAsian
f7582f0050
pep8: Fix E124 violations
2016-12-01 14:18:11 -08:00
Rafid Aslam
c5316b4002
lint: Fix E127 pep8 violations.
...
Fix pep8: E127 continuation line over-indented for visual indent
style issue.
2016-12-01 10:23:55 -08:00
Vamshi Balanaga
5f60258a85
pep8: Fix E211 violations.
2016-11-30 20:13:10 -08:00
Bickio
6b0df43463
pep8: Fix E125.
2016-11-30 20:03:29 -08:00
Bickio
e009383460
pep8: Fix E231.
2016-11-30 19:59:25 -08:00
Tommy Ip
e4091c6413
pep8: Fix E222 violations.
2016-11-30 21:49:02 +00:00
Tommy Ip
46b7d54b3e
pep8: Fix E701 violations.
2016-11-30 20:45:09 +00:00
Rafid Aslam
41bd88d5ed
pep8: Fix E301 pep8 violations.
...
Fix "E301: expected (1 or 2) blank line" pep8 violations.
2016-11-29 08:51:44 -08:00
Rafid Aslam
7a2282986a
pep8: Fix E225 pep8 violations.
2016-11-28 15:21:15 -08:00
sylvan1
443cf92640
mypy: Change Generator[None, None, None] to Iterator[None].
...
Fixes #1648 .
2016-11-27 10:42:16 -08:00
Tim Abbott
1fcf2ff525
tornado: Move zerver.tornadoviews to zerver.tornado.views.
...
This furthers the overall goal of moving all the Tornado-specific code
to zerver/tornado/.
2016-11-26 22:29:28 -08:00
Tim Abbott
8739f4d9f1
tornado: Move tornado_ioloop_logging to new zerver/tornado tree.
2016-11-26 21:24:05 -08:00
Arpith Siromoney
f0df1db9fb
tools: Remove tools/node and call node directly instead.
...
Previously, we didn't install/pin our own node.js version, and thus
had this wrapper script to manage it. Now that install our own node
via nvm, there's no reason we still need this.
Fixes #2409 .
2016-11-26 12:42:58 -08:00
Steve Howell
8110c3f799
tools: Check provisioning version in lint-all.
2016-11-26 11:36:53 -08:00
Tim Abbott
2abe11e209
lint-all: Fix progress bar from `npm run lint` in linter.
...
Also fixes printing the `eslint` help output in the event that there
are no files to check.
See https://github.com/zulip/zulip/pull/2246#issuecomment-261673662
for details on the original problem.
2016-11-18 16:19:05 -08:00
Arpith Siromoney
497c7702cc
Run eslint in tools/lint-all with npm run --silent lint
...
This commit adds a basic eslintrc that emulates jslint defaults.
Rules that conflict with our existing code have been switched to
warnings instead of errors. Globals have been added to the eslintrc. The
bundled js file (generated by webpack) and blueslip.js are ignored with
.eslintignore.
To display warnings, run npm run lint-loud. This runs eslint without the
--quiet option on static/js and frontend_tests.
npm run --silent lint is run by tools/lint-all (in addition to jslint).
The --silent option is used to suppress the default output from npm run.
Fixes #535 .
2016-11-18 16:15:45 -08:00
Vladislav Manchev
d7e1e4a2c0
Add initial implementation of custom realm filters.
...
This PR was abandoned by Vladislav and then substantially modified by
Igor Tokarev and Tim Abbott to complete it and fix a number of bugs.
Fixes #544 .
2016-11-17 17:11:25 -08:00