0338e8a6f6
send_custom_email: Add support for specifying reply-to.
2019-11-18 17:34:01 -08:00
73cb03b1ea
send_custom_email: Commit the base template.
...
This should have been included in
e266fb4343
2019-11-18 17:27:12 -08:00
f83871c182
corporate: Consistently use delivery_email for billing.
...
This is yet another corner case where EMAIL_ADDRESS_VISIBILITY_ADMINS
broke existing code.
2019-11-18 17:02:57 -08:00
6d17fea076
docs: Document a few management commands around email.
2019-11-18 15:45:21 -08:00
e266fb4343
management: Add command to send a custom email to users.
...
This allows us to email sets of users on a server with a nicely
formatted email similar to our onboarding emails, built off of a
Markdown template.
The code was based on send_password_reset_email, but it doesn't
replace that use case, since one cannot include special values like
password reset tokens in these emails.
2019-11-18 15:35:54 -08:00
39bd565941
test_realm: Automate tests for invalid integer values in Realm.
...
Fixes #13362 .
2019-11-18 15:21:11 -08:00
a890652bfd
realm: Use check_int_in validator for enum format views.
...
This lets us remove some ugly semi-duplicated code.
Modified by tabbott to include some additional endpoints in the
changes.
2019-11-18 15:21:00 -08:00
678c3a89d0
validators: Add check_int_in validator.
...
This is a useful helper for our enum format fields where we want to
only allow a fixed list of integer values.
2019-11-18 15:14:56 -08:00
31558cb8b9
decorator: Extract require_user_group_edit_permission.
...
We move the check that the user is a member or admin inot this
decorator.
This name better communicates that this may do other checks beyond
just verifying the policy.
2019-11-18 15:13:29 -08:00
21ed834101
decorator: Extract OrganizationAdministratorRequired common exception.
...
This eliminates significant code duplication of error messages for
situations where an organization administrator is required.
2019-11-18 15:10:56 -08:00
08103544cc
tests: Remove upload-file from curl test exclude_list.
2019-11-18 12:23:38 -08:00
76c610c953
tests: Remove upload-custom-emoji from curl test exclude_list.
2019-11-18 12:23:38 -08:00
4c5e9e8eb0
tests: Add support for patching requestBody in curl example test.
2019-11-18 12:23:38 -08:00
742de73bde
tests: Remove update-notification-settings from curl test exclude_list.
2019-11-18 12:23:38 -08:00
c4525cceee
tests: Remove get-user-groups from curl test exclude_list.
2019-11-18 12:23:38 -08:00
3468764415
tests: Remove remove-linkifiers from curl test exclude_list.
2019-11-18 12:23:38 -08:00
258089bdc3
tests: Remove add-linkifiers from curl test exclude_list.
2019-11-18 12:23:38 -08:00
ec53b8c574
tests: Unescape the html generated in curl example test.
...
Curl examples generated in test_generated_curl_examples_for_success
used to be html escaped. This commit removes the escaping in the test
since curl examples are not html escaped when run from terminal.
2019-11-18 12:23:38 -08:00
a478e861a2
tests: Remove create-user from curl test exclude_list.
...
The API test client uses an admin client since
0f64fe530667fd3b96a434842b124075dea84300
2019-11-18 12:23:38 -08:00
0f582dfe1f
portico: Add return to login button to password reset end.
...
Previously, we had a "Return to login" button on the previous page of
the password reset flow, but none on the final page.
Note that this button is only shown in the Zulip Electron app.
Fixes #13378 .
2019-11-18 12:21:40 -08:00
8ed57f8897
integrations: Fix BOT_PREFIX in errbot docs.
2019-11-18 12:14:43 -08:00
2e6e187c16
integrations: Deduplicate gogs and gitea integrations.
2019-11-18 12:08:09 -08:00
b88192d5bb
integrations: Add Gitea integration.
...
Gitea integration adopted from Gogs integration with minor
adjusting. More events are now handled.
Fixes #13346
2019-11-18 11:55:24 -08:00
ace1503cb6
integrations: Add missing event handling to Gogs.
...
Issues event where not handled by Gogs integrations.
This added them to supported events.
2019-11-18 11:54:44 -08:00
4e421ebe12
scripts: Move inline-email-css from tools to scripts.
...
We'll be soon documenting a production workflow that involves using
it, and that means it needs to live under scripts/ (since tools/ isn't
present in release tarballs).
2019-11-15 17:39:42 -08:00
f34a40581f
actions: Fix a few references to user_profile.email.
...
The only functional change here is for what is sent to the signups
queue worker, which at present isn't used in production anywhere.
2019-11-15 17:31:41 -08:00
6618cec9db
logging: Switch various logging code paths to use user IDs.
...
This fixes EMAIL_ADDRESS_VISIBILITY_ADMINS support as well as being
more reliable/stable over time.
2019-11-15 17:24:01 -08:00
5edc5ae1fb
create_test_bot: Use delivery_email for login.
...
The `email` field won't actually work if
EMAIL_ADDRESS_VISIBILITY_ADMINS is enabled.
2019-11-15 17:20:23 -08:00
0e317a8773
registration: Use delivery_email in logging code path.
...
This is essentially an assertion failure code path, so it doesn't
really matter, but it seems best to use the value that's the cause of
the problem here.
2019-11-15 17:18:19 -08:00
caf4c7af8f
get_user_by_id: Use delivery_email when finding cross-realm bots.
...
When actually looking for bots, it doesn't matter, but this feels more
consistent with the other lookup code.
2019-11-15 17:17:05 -08:00
b85c9b0810
tornado: Use delivery_email in logging.
...
Eventually, we'll want to replace emails with user IDs here entirely,
but until we make that happen, we should at least use the same email
address present in our other logging.
I think we won't miss updating these in a future migration thanks to
mypy types.
2019-11-15 17:16:05 -08:00
7935b3cbd7
archive: Fix calculation of gravatar URL.
...
This is mostly dead code right now, but in case we revive it, I found
this error in an audit.
2019-11-15 17:14:44 -08:00
993ed9c2b1
tornado: Remove stale user_profile_email field.
...
Since years ago, this field hasn't been used for anything other than
some logging that would be better off logging the user ID anyway.
It existed in the first place simply because we weren't passing the
user_profile_id to Tornado at all.
2019-11-15 17:07:52 -08:00
df90533eef
home: Switch invalid pointer logging to by user ID.
2019-11-15 17:07:52 -08:00
093e9394dd
find_account: Use delivery_email when searching emails.
...
Previously, this code wouldn't work with
EMAIL_ADDRESS_VISIBILITY_ADMINS.
2019-11-15 17:07:52 -08:00
3bc7ba1767
digest: Switch from emails to user IDs for logging.
...
This is better practice.
2019-11-15 17:07:52 -08:00
bb64b0fa4d
queue processors: Switch SignupWorker to logging user IDs.
...
This is a better setup than logging emails, especially with
EMAIL_ADDRESS_VISIBILITY_ADMINS.
2019-11-15 17:07:24 -08:00
b14b18b76f
soft_deactivation: Remove 'email' from logging.
...
The value wasn't correct with EMAIL_ADDRESS_VISIBILITY_ADMINS, and in
any case we really just need the user ID.
2019-11-15 17:06:51 -08:00
8b45756dd2
onboarding: Fix welcome emails not using delivery_email.
...
For organizations with EMAIL_ADDRESS_VISIBILITY_ADMINS, we were using
the wrong email address in the notice telling the user how to login in
the future.
2019-11-15 16:49:28 -08:00
e124837cdc
management commands: Fix incorrect use of user_profile.email.
...
All of these management commands should be interacting with
.delivery_email; this results in buggy behavior with
EMAIL_ADDRESS_VISIBILITY_ADMINS.
2019-11-15 16:43:51 -08:00
0632d26e5e
tests: Remove update-stream from curl test exclude_list.
2019-11-15 15:53:31 -08:00
be49dd4f30
tests: Remove delete-user-group from curl test exclude_list.
2019-11-15 15:53:31 -08:00
ee2d20ff3c
tests: Remove update-user-group from curl test exclude_list.
2019-11-15 15:53:31 -08:00
4b212efba6
tests: Remove create-user-group from curl test exclude_list.
2019-11-15 15:53:31 -08:00
473d178fbc
tests: Remove delete-stream from curl test exclude_list.
2019-11-15 15:53:31 -08:00
4e15dabcfa
tests: Remove remove-subscriptions from curl test exclude_list.
2019-11-15 15:53:31 -08:00
3efe35e35b
tests: Remove delete-message from curl test exclude_list.
2019-11-15 15:53:31 -08:00
00455df7f9
tests: Use admin client for curl examples test.
2019-11-15 15:53:31 -08:00
bb5463b29a
tests: Run test_generated_curl_examples_for_success after test_the_api.
...
Upcoming changes in test_generated_curl_examples_for_success modifies
various data of iago user heavily. So it's much easier to run
test_the_api initially than making various changes in tests of
test_the_api function.
2019-11-15 15:53:31 -08:00
517534777d
export-and-import: Update repo url of Zulip Archive.
2019-11-15 11:39:52 -08:00
Tim Abbott
Matheus Melo
Vishnu Ks
Ivan Mitev
Jan Koscisz
rht