fbe7285af8
left_sidebar: Remove export in deselect_top_left_corner_items.
...
It is safe to remove the export, because
deselect_top_left_corner_items isn't called anywhere else outside the
file.
2024-02-09 15:53:05 -08:00
afe3bcd6c5
left_sidebar: Simplify deselection with deselect_top_left_corner_item.
...
Refactoring to avoid duplication, improve readability, and standardize
deselection logic by converting calls to remove to
deselect_top_left_corner_items.
2024-02-09 15:51:57 -08:00
497bd740e9
web: Replace Zod z.union with z.discriminatedUnion or .nullable.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-09 18:48:20 -05:00
d5281292d5
compose_ui: Clean up placeholder logic.
...
This removes messy indirection through email addresses in passing a
set of users between two modules.
2024-02-09 15:11:17 -08:00
264a9a1057
compose_ui: Convert module to typescript.
2024-02-09 15:11:17 -08:00
91bdcc9596
compose_ui: Use startsWith/endsWith helpers.
...
Suggested by @joydeep2001 in #28725 .
2024-02-09 15:11:17 -08:00
9efce0b16c
create_user: Fix initial unreads ignoring private streams.
...
This logic was apparently missed when we implemented private streams
with shared history; the correct check is to look at whether the user
can access message history in the stream, which used to be equivalent
to whether it's a private stream.
2024-02-09 12:49:30 -08:00
de77521d1a
help: Improve descriptions of custom profile field types.
...
Also reorder as in 60225591dc
2024-02-09 12:28:00 -08:00
54053c1d28
help: Fix Windows offline install instructions for desktop app.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-09 14:42:36 -05:00
db938f5ed2
help: Clean up desktop installation guide.
...
Apply current help center patterns (e.g., tips).
2024-02-09 10:29:50 -08:00
0290642f1d
plans: Use IntersectionObserver to handle subheaders.
2024-02-09 09:20:34 -08:00
7ea313c658
plans: Ensure linked comparison tables scroll into view.
2024-02-09 09:20:34 -08:00
960e29dc5a
plans: Handle table widths in CSS.
2024-02-09 09:20:34 -08:00
5aa3615f4b
plans: Add comparison-switcher logic and styles.
2024-02-09 09:20:34 -08:00
0e3699c3dc
plans: Open up spacing around feature-cell text.
2024-02-09 09:20:34 -08:00
33fd82ead3
plans: Add comparison-tab buttons and icons.
2024-02-09 09:20:34 -08:00
7d2adda31c
plans: Filter table based on active plans tab.
2024-02-09 09:20:34 -08:00
5031d7a06c
plans: Avoid hover effect on header row.
2024-02-09 09:20:34 -08:00
b13f423f07
plans: Structure content and table in anticipation of filters.
2024-02-09 09:20:34 -08:00
28e3c166a8
plans: Consolidate integrated table references.
2024-02-09 09:20:34 -08:00
1eef218830
plans: Prepare integrated table of Zulip Cloud and Self-hosted features.
...
Co-Authored-By: Alya Abbott <alya@zulip.com>
2024-02-09 09:20:34 -08:00
0d25efd4a0
settings: Fix check_property_changed code for user access setting.
...
The proposed_val for "realm_can_access_all_users_group" setting
was always returning NaN value which resulted in the value
being included in request even when it was not changed or disabled
due to org not being on "Plus" plan. This resulted in a bug where
user was not allowed to change the "guest" indicator setting
on orgs without "Plus" plan.
For orgs with "Plus" plan there was no problem in changing the
setting but the save button was visible incorrectly if the setting
was set to the initial value.
This commit fixes both the bugs.
2024-02-08 11:03:47 -08:00
1d5a083869
admin: Remove unnecessary development_environment check.
...
The "Who can access all users" setting is not disabled for
organizations not on "Plus" plans in production because of
the "page_params.development_environment" check.
We do not need that check anymore as the feature is now
enabled in production.
2024-02-08 11:03:47 -08:00
688a9be556
page_params: Remove unused remote.
...
It’s been unused since its introduction in commit
ebdd55814c
2024-02-08 10:08:15 -08:00
c23f6a786d
page_params: Remove unused for_installation.
...
It’s been unused since its introduction in commit
1af7fc7344#9458 ).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-08 10:08:15 -08:00
e79572d0d5
page_params: Remove unused first_in_realm.
...
It’s unused since commit e1843dd1b9#5819 ).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-08 10:08:15 -08:00
b59faf540f
page_params: Remove unused prompt_for_invites.
...
It’s unused since commit ebe959f2b0
2024-02-08 10:08:15 -08:00
0115fa9c60
start-server/restart-server: Drop privileges if necessary.
...
Rather than tell the user to re-run the command as `zulip` instead of
`root`, do the privilege-dropping ourselves.
2024-02-07 12:33:00 -08:00
20d90a6df6
portico: Fix subdomain check flickering with arrow keys.
...
The previous logic would treat navigating with the arrow keys, or
alt-tab, as a reason to clear the subdomain unavailable warning, and
would not necessarily check again immediately. Now just trigger off
changes in the input.
Instead, just trigger off actual changes in the value of the input.
2024-02-07 12:10:00 -08:00
e9b0c7f2c0
name_restrictions: Reserve additional subdomains.
2024-02-07 12:10:00 -08:00
fa6f4cc039
kandra: Skip hostnames which are undef.
...
If zulip.conf is not fully configured, do not error out if one of
the $hostname values is undef.
2024-02-07 10:42:12 -08:00
3d63a87384
kandra: Puppet github.com keys to both root and zulip users.
...
We update to add the ecdsa-sha2-nistp256 key as well.
2024-02-07 10:42:12 -08:00
b1f899512a
pack-local-script: Match mode of file outside of packing.
2024-02-07 10:42:12 -08:00
5672595c2a
push_notifs: Gracefully handle exception when server cant push.
...
The problem was that earlier this was just an uncaught JsonableError,
leading to a full traceback getting spammed to the admins.
The prior commit introduced a clear .code for this error on the bouncer
side, meaning the self-hosted server can now detect that and handle it
nicely, by just logging.error about it and also take the opportunity to
adjust the realm.push_notifications_... flags.
2024-02-07 10:36:33 -08:00
3bda31c48c
zilencer: Improve json error when plan doesn't allow push notifs.
...
This allows the self-hosted server to explicitly test for that exception
and catch and log it nicely.
2024-02-07 10:36:33 -08:00
d29cd04387
integrations: Create incoming webhook for GitHub Sponsors.
...
Creates an incoming webhook integration for Github Sponsors. The
main use case is getting notifications when new sponsors sign up.
Fixes #18320 .
2024-02-07 09:52:03 -08:00
ea89a4c6f7
puppeteer: Disable flaky administrative UI test.
2024-02-07 09:45:27 -08:00
d015a8ca52
typing: Pass the type parameter in typing requests.
...
Not passing this parameter is a deprecated way to do things.
2024-02-07 09:12:49 -08:00
e213d9505b
typing: Convert module to TypeScript.
2024-02-07 09:12:49 -08:00
391e2a8e01
typing_status: Use TypeScript unions for 'Recipient' type.
...
Typing 'Recipient' as union of 'stream' and 'direct' message type will help with upcoming type inference.
2024-02-07 09:12:49 -08:00
b64a9d6ae0
page_params: Add typing notifications constants to type.
2024-02-07 09:12:49 -08:00
94558478df
scheduled_messages_feed_ui: Convert module to TypeScript.
2024-02-06 22:25:55 -08:00
f0b8cc7865
scheduled_messages_feed_ui: Refactor to avoid duplicate function calls.
...
While this logic might seem to be different,
util.same_stream_and_topic would always return false when passed a
topic of undefined.
2024-02-06 22:25:55 -08:00
fc86aca769
scheduled_messages: Make ScheduledMessage type more precise.
...
Typing 'ScheduledMessage' as union of 'private' and 'stream' scheduled
message types will help with upcoming type inference.
2024-02-06 22:25:55 -08:00
3d23b39793
scheduled_messages_feed_ui: Fix false/empty array type confusion.
...
This looks to be a mistake resulting from moving this line out of the
filtering loop just below.
2024-02-06 22:25:55 -08:00
927660a7b6
kandra: Remove munin.
2024-02-06 21:34:56 -08:00
96d237d57e
kandra: Pull in known_hosts to the nagios user.
...
This prevents failures when new hosts are initially added to the
configuration.
2024-02-07 00:02:40 -05:00
2cbd9c2a47
kandra: Update default chrony configuration for 22.04.
2024-02-07 00:02:32 -05:00
2055dfa83e
support: Add support to configure fixed-price plan with pay-by-invoice.
...
* Manually create & send invoice
* Configure a fixed-price plan with sent invoice-id.
* When customer pays, upgrade them to concerned plan.
2024-02-06 18:43:23 -08:00
79a1b3b80e
billing: Show annual data for fixed-price plan, by default.
...
On /upgrade page, we show annual schedule & price for a
fixed-price plan, by default.
This also acts as a prep commit for fixed-price plan
with pay-by-invoice collection method as we only offer
annual plan in such case. So, annual data is shown by default
on /upgrade page.
2024-02-06 18:43:23 -08:00
Rinwaoluwa
Anders Kaseorg
Tim Abbott
Joydeep Bhattacharjee
Alya Abbott
Karl Stolley
Sahil Batra
Alex Vandiver
Mateusz Mandera
David Rosa
Varun Singh
Prakhar Pratyush