84fd0b0974
stream_edit: Remove separate click handlers from notifications checkboxes.
...
Rather than looping on each setting checkbox (except "Mute stream"), we can
attach single click handler to `.sub_setting_checkbox` class.
2020-02-04 13:53:27 -08:00
ceb0879b0d
unread: Add a block comment explaining how it works.
2020-02-04 12:39:58 -08:00
02bc630881
presence: Document why we no longer need suspect_offline.
...
Since it took a lot of effort to debug the original issue that caused
us to introduce suspect_offline, it seems worth writing a comment
explaining why we won't see that issue here.
2020-02-04 12:35:51 -08:00
a672a00677
presence: Add user_id to presence event.
...
In a later commit, we will eliminate email for
clients who have set slim_presence as their
preference.
2020-02-04 12:30:36 -08:00
36aee9e69c
presence: Remove suspect_offline flag.
...
We now use user_ids for presence, so we don't need
to worry about races related to unknown emails
being sent to us. Now we just update the data
structure based on user_id, and
it will be there when we render the presence
widget for that user_id, or else it will
simply be ignored.
It's not clear to me whether we still need
dont_block here, so I didn't touch that code.
Here is the commit that added the suspect_offline
flag, for easy reference:
f207450cdb
2020-02-04 12:30:36 -08:00
bf9144ff69
presence: Add slim_presence flag.
...
This flag affects page_params and the
payload you get back from POSTs to this
url:
users/me/presence
The flag does not yet affect the
presence events that get sent to a
client.
2020-02-04 12:30:34 -08:00
145c17d9d6
presence: Remove obsolete defensive code.
...
If you look at info_for, it clearly never returns
`undefined`, so this defensive code isn't preventing
any bugs.
Also, we are doing a better job now of filtering
user_ids in upstream code.
2020-02-04 12:24:53 -08:00
ef84d47d88
presence: Add warning for missing user_id.
...
This is defensive code for the scenario that we
have a user_id in presence but not people. This is
unlikely to occur by the time that we actually render
the buddy list, which is the context for this code.
We have previously been reporting an error here via
the people code, but we add an additional warning.
Also, we filter the user_id from the result.
2020-02-04 12:24:53 -08:00
4480963f5a
dict: Remove each method.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:03 -08:00
fac2c71776
dict: Replace items method with @@iterator method.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:03 -08:00
9e1343ff8a
dict, lazy_set: Return an iterator from values method.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:03 -08:00
45d3be5449
dict, lazy_set: Return an iterator from keys method.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:03 -08:00
61de2e8192
dict: Remove is_empty method.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:03 -08:00
60fac80c8e
dict, lazy_set: Replace num_items method with size property.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:03 -08:00
da633e953e
lazy_set: Convert LazySet to a real class.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:03 -08:00
fe54e73c77
dict, lazy_set: Rename del method to delete, for consistency with Map.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:03 -08:00
0e657756f1
dict: Make set method return value consistent with Map.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:03 -08:00
ab61222dd5
dict: Reimplement Dict using Map.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:02 -08:00
b16222a38b
dict: Remove setdefault method.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:02 -08:00
8872aca907
dict: Remove clone method.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:02 -08:00
22555f53ad
dict: Remove Dict.from_array.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:02 -08:00
52765796c2
dict: Remove Dict.from.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:02 -08:00
5b824702b4
unread: Replace key_to_bucket Map with Dict/FoldDict/IntDict.
...
This reverts commit d84646f091
2020-02-04 12:21:29 -08:00
252910202b
poll_widget: Convert votes from object to Map.
...
Fixes implicity stringification of the user ID keys.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-03 15:59:26 -08:00
85620df34e
poll_widget: Convert key_to_option from object to Map.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-03 15:59:26 -08:00
849c7f83a0
blueslip_stacktrace: Handle promises in sourceCache.
...
Fixes “TypeError: sourceContent.split is not a function” at
blueslip_stacktrace.ts:60 when there’s another error during page load.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-03 15:58:57 -08:00
aaa30df94c
Hotkeys: Change hotkeys behaviour on dropdown open.
...
Disables message_view_only hotkeys when dropdown menu is opened.
Fixes : #11990
2020-02-03 13:45:07 -08:00
23c5123a55
hotkeys: Change 'q' and 'w' to message_view_only
...
Add message_view_only property to 'q' and 'w' hotkeys
2020-02-03 13:40:48 -08:00
8e733fb513
settings_org: Extract the function to hide or show the element block.
...
This change leads to some de-duplication of repeated code.
2020-02-03 11:37:40 -08:00
dd6e616c9b
settings_org: De-duplicate code to set value of normal dropdowns.
...
In the future, any property which doesn't have any dependent setting can be
added to `simple_dropdown_properties` list, which automates setting the
value of dropdowns on saving.
2020-02-03 11:37:40 -08:00
9f150385bc
design: Fixes height of view stream button.
...
The view stream button had a line-height property which messed up
its height. Fixed it by removing the line-height property.
2020-02-02 21:34:00 -08:00
3dec7f6f6f
design: Fixes poor line wrapping of long stream names using ellipses.
...
Earlier, on narrowing the window to some particular sizes,
long stream names used to overlap with the subscribe and view stream
buttons.
The issue was resolved by cutting the stream name short and putting
ellipses at the end. A title was provided to the stream name div so that
the entire stream name would be visible on hovering over it.
Fixes : #13139
2020-02-02 21:34:00 -08:00
e4259d48a5
dict: Assert that Dict is only used with string keys.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
b41968c4a7
topic_list: Replace active_widgets Dict with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
a7bed2c8a3
stream_list: Replace rows Dict with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
b5cd8dcedd
starred_messages: Replace ids Dict with Set.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
1189747d4c
settings_streams: Replace row_dict Dict with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
90ebaa86e9
settings_sections: Replace is_loaded Dict with loaded_groups Set.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
21b13e656d
recent_senders: Replace topic_senders and stream_senders with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
c4e1357e19
pm_conversations: Replace partners Dict with Set.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
052497de1c
muting: Replace muted_topics Dict with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
e10da9c85f
condense: Replace _message_content_height_cache Dict with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
2f91f583fc
unread: Replace buckets with Set.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
5262ff790e
unread: Replace unread_message_ids with Set.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
6a0de3bb74
unread: Replace unread_mentions_counter with Set.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
a9e28218b2
unread: Replace reverse_lookup Dict with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
d84646f091
unread: Replace key_to_bucket Dict/FoldDict with Map.
...
Fixes type confusion in unread_topic_counter, which uses stream IDs as
keys.
Since unread_topic_counter calls message_store.get now, update the
mocks so that message_store.get knows about our mocked messages.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
fd9557aa0c
unread: Fix {get_msg_ids,num_unread}_for_person type confusion.
...
These methods take a comma-separated string of user IDs; don’t pass a
number.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
df6b90db3c
settings: Fix copy-from-clipboard behavior for bot tokens.
...
We do this by cleaning up the API for generate_zuliprc_content,
allowing us to deduplicate the previously incorrect code.
2020-01-31 15:11:20 -08:00
992b15b86c
echo: Support senders other than ourself in display_recipient logic.
...
we don't have a current use case for this feature, but it better
matches what we mean and thus makes the function more readable.
2020-01-31 12:46:19 -08:00
Pragati Agrawal
Tim Abbott
Steve Howell
Anders Kaseorg
shubhamgupta2956
Vaibhav Raj Singh