Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
38,539 Commits 28 Branches 143 Tags 626 MiB
Commit Graph

38539 Commits

Author SHA1 Message Date
Steve Howell 23e14124aa zjsunit: Only allow functions for overrides. 
There was only one place where we weren't
overriding a function, and the use case there
was fairly unique.

Knowing that we're dealing with only functions
will simplify override and allow us to add
features like detecting spurious stubs.
 2020-07-26 09:25:40 -04:00
Steve Howell b8b2e31463 zjsunit: Require explicit set_global for overrides. 
This forces us to more explicitly document at the
top of the file what dependencies we are stubbing,
plus it's less magical.

Also, we may want to do occasional audits of
set_global to clean up places where we mock
things like stream_data, which are probably just
easier to use the real version of now that we
have cleaner APIs to set up stream data.

The modules most affected by this change are our
dispatch-oriented tests--basically, all the
modules that test handling of Zulip events
plus hotkey.js.
 2020-07-26 09:25:40 -04:00
Steve Howell 128cda6acd zjsunit: Restore functions in with_overrides. 
Before we were making it impossible to reuse
the function again (so we were preventing
leaks), but it's fine to just restore the
original function, especially now that some
of our tests have grown bigger.
 2020-07-26 09:25:40 -04:00
Steve Howell 48bb432e4f dispatch tests: Localize overrides. 2020-07-26 09:25:40 -04:00
Steve Howell 7de8726000 dispatch tests: Remove obsolete noop stubs. 2020-07-26 09:25:40 -04:00
Steve Howell a6a9897abd node fixtures: Clean up user_group data. 2020-07-25 17:55:57 -04:00
Steve Howell 97c21ff4da node fixtures: Add all flags for update_message_flags. 2020-07-25 17:55:57 -04:00
Steve Howell 2462282631 node fixtures: Add users for various settings. 
We should probably remove this field, as it
seems extraneous.
 2020-07-25 17:55:57 -04:00
Steve Howell f22d0b8abe node fixtures: Add op for custom_profile_fields. 2020-07-25 17:55:57 -04:00
Steve Howell b63c7d1cbb node fixtures: Add more realistic data for typing. 2020-07-25 17:55:57 -04:00
Steve Howell b4a4f9d568 node fixtures: Add more realistic data for streams/subs. 2020-07-25 17:55:57 -04:00
Steve Howell 7092cbf6f5 node fixtures: Add more realistic data for user events. 2020-07-25 17:55:57 -04:00
Steve Howell aad98aa6cd node fixtures: Add more realistic data for bots. 2020-07-25 17:55:57 -04:00
Anders Kaseorg 0ed9a0fc58 eslint: Forbid imports from outside shared in shared. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-25 12:29:47 -07:00
Anders Kaseorg 7727dae441 shared: Add missing katex dependency to shared package.json. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-25 12:22:25 -07:00
Vishnu KS 5b0b1efb15 support: Add functionality to approve sponsorship requests. 
This should make it much easier to process these requests.
 2020-07-24 17:55:38 -07:00
Vishnu KS d3834f8b9a emails: Simplify requested by line in sponsorship email. 2020-07-24 17:39:46 -07:00
Vishnu KS 6b9c22b211 support: Add a header for scrub realm section. 2020-07-24 17:37:41 -07:00
Vishnu KS 1a1396d07e support: Show customer plan details in support page. 2020-07-24 17:37:41 -07:00
Vishnu KS f6cbb9177a models: Add plan_name attribute to CustomerPlan. 2020-07-24 17:37:41 -07:00
Alex Vandiver 38d01cd4db puppet: Generalize install-wal-g to be arbitrary tarballs. 2020-07-24 17:24:57 -07:00
Anders Kaseorg b900e38dc6 topic_list: Convert widget to an ES6 class TopicListWidget. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:58:22 -07:00
Anders Kaseorg 4517c48de2 todo_widget: Convert task_data_holder to an ES6 class TaskData. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:58:22 -07:00
Anders Kaseorg c5e397d469 tictactoe_widget: Convert tictactoe_data_holder to an ES6 class. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:58:22 -07:00
Anders Kaseorg cd913b7ebc sent_messages: Convert message_state to an ES6 class MessageState. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:56:28 -07:00
Anders Kaseorg daf5a78e98 search_suggestion: Convert make_attacher to an ES6 class Attacher. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:56:28 -07:00
Anders Kaseorg f96bd3839c user_search: Convert user_search to an ES6 class UserSearch. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:50:23 -07:00
Anders Kaseorg 41778d81d2 unread: Convert unread_topic_counter to an ES6 class UnreadTopicCounter. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:50:23 -07:00
Anders Kaseorg e5ff78e893 unread: Convert unread_pm_counter to an ES6 class UnreadPMCounter. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:50:23 -07:00
Anders Kaseorg 44053eba3f unread: Convert make_bucketer to an ES6 class Bucketer. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:50:23 -07:00
Anders Kaseorg 557e88df77 pm_conversations: Convert recent to an ES6 class RecentPrivateMessages. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:50:23 -07:00
Anders Kaseorg 2bf6731f5a stream_topic_history: Convert per_stream_history to an ES6 class. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:50:23 -07:00
Anders Kaseorg e47fd521e3 stream_list: Convert build_stream_sidebar_row to an ES6 class. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:50:23 -07:00
Anders Kaseorg 2aae92b6e3 stream_list: Convert stream_sidebar to an ES6 class StreamSidebar. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:50:23 -07:00
Anders Kaseorg 0ad8da139e stream_data: Convert BinaryDict to an ES6 class. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:50:23 -07:00
Anders Kaseorg 30e4b51731 stream_create: Convert stream_name_error to an ES6 class. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:50:23 -07:00
Anders Kaseorg 3319848768 stream_create: Convert stream_subscription_error to an ES6 class. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:50:23 -07:00
Anders Kaseorg ba4ef5bf90 blueslip: Convert Logger to an ES6 class. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:40:42 -07:00
Anders Kaseorg 58c84940f4 blueslip: Convert BlueslipError to an ES6 class. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:40:42 -07:00
Anders Kaseorg abe52e2191 filter: Convert Filter to an ES6 class. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:40:42 -07:00
Anders Kaseorg aee95ecf7e util: Convert CachedValue to an ES6 class. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:40:42 -07:00
Anders Kaseorg 4ad00c1aea lightbox_canvas: Remove old-style window.onload handler. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:32:53 -07:00
Anders Kaseorg fc21417d67 lightbox_canvas: Convert LightboxCanvas to an ES6 class. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:32:53 -07:00
Anders Kaseorg d5a0ee612f lightbox_canvas: Make parameter type error fatal. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:32:53 -07:00
Anders Kaseorg c4024e30c2 debug: Convert IterationProfiler to an ES6 class. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 16:32:53 -07:00
Tim Abbott ec9c272165 help: Document process for changing organization URL. 2020-07-24 16:12:56 -07:00
Gittenburg 2922e2cbb1 compose: Use aria-label instead of aria-hidden. 
aria-hidden hides something from the accessiblity tree,
it shouldn't be used for interactive elements.
 2020-07-24 15:31:26 -07:00
Gittenburg 8f99820120 composebox_typeahead: Remove deprecated workaround. 
The Chromium bug[1] was fixed in 2015.

[1]: https://bugs.chromium.org/p/chromium/issues/detail?id=32865
 2020-07-24 15:31:26 -07:00
Steve Howell 21dfe76295 tests: Remove dead print-delay code. 2020-07-24 15:30:17 -07:00
Anders Kaseorg 5f0bd44d58 notifications: Fix incorrectly converted focus method call. 
Commit a9ca5f603b (#15863) incorrectly
converted this; window is quite obviously a DOM element, not a jQuery
element.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 14:48:47 -07:00