Steve Howell
3fc8597119
popovers: Avoid passing message to actions popover template.
...
We instead get the specific fields from message
that we use. This is particularly helpful
for subject -> topic migration; we no longer
have to account for "subject" fields in
client-side templates.
2018-12-29 14:19:18 -08:00
Sumanth V Rao
ccd0badeed
test-documentation: Simplify --skip-external-links code path.
...
The crawler used to be called directly for checking external links.
Now the scrapy command calls the crawl_with_status wrapper.
Crawl_with_status has been modified to pass the external parameter in
the previous commit, so we can now use this simpler approach.
2018-12-29 09:09:18 -08:00
Sumanth V Rao
776b981dde
test-help-documentation: Skips checking external links.
...
This option causes test-help-documentation to verify internal links only.
This prevents documentation from flaking in CI due to links from
external websites having failed in the documentation.
Based on conversation:
https://chat.zulip.org/#narrow/stream/43-automated-testing/subject/quora.20404/near/674997
2018-12-29 20:15:30 +05:30
Rishi Gupta
e7220fd71f
billing: Do subscription management in-house instead of with Stripe Billing.
...
This is a major rewrite of the billing system. It moves subscription
information off of stripe Subscriptions and into a local CustomerPlan
table.
To keep this manageable, it leaves several things unimplemented
(downgrading, etc), and a variety of other TODOs in the code. There are also
some known regressions, e.g. error-handling on /upgrade is broken.
2018-12-22 13:39:30 -08:00
Rishi Gupta
f8720fddd6
emails: Update text of notify_new_login.
2018-12-20 16:26:19 -08:00
Vishnu Ks
f9e4d5d28e
emails: Tag password_reset for translation.
2018-12-19 09:21:09 -08:00
Vishnu Ks
0960e654ab
emails: Tag notify_new_login email for translation.
2018-12-19 09:21:09 -08:00
rht
acbb174100
provision: Add RHEL 7 support.
2018-12-18 17:13:56 -08:00
rht
84c968ab36
provision: Include scripts/lib/setup-* and scripts/lib/build-* for sha1 sum check.
2018-12-18 16:56:27 -08:00
Tim Abbott
dd946fff1f
lint: Improve ui_report.error linter rule.
...
We now allow passing "" as the first argument.
2018-12-18 12:33:15 -08:00
rht
a093d45064
provision: Check for pg_hba.conf existence for doing postgres initdb.
...
Apparently, an empty pg_datadir is initialized after postgresql-10 is
installed.
2018-12-18 12:07:45 -08:00
rht
3060ee9397
provision: Fix typo when checking that vendor is Fedora.
2018-12-18 12:07:03 -08:00
Anders Kaseorg
392175d6e8
Use #!/usr/bin/env for bash shebangs.
...
/bin/sh and /usr/bin/env are the only two binaries that NixOS provides
at a fixed path (outside a buildFHSUserEnv sandbox).
This discussion was split from #11004 .
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-12-17 17:21:08 -08:00
rht
5e12eb8d34
provision: Fix typo in list of services on RedHat.
2018-12-17 16:30:48 -08:00
rht
42cbf2071b
provision: Skip RedHat postgresql initdb if already initialized.
...
We only need to initialize a postgres database once in the lifetime of
a system.
2018-12-17 16:29:50 -08:00
rht
295cbe7b9c
provision: Add build-pgroonga and use it for Fedora.
2018-12-17 16:23:57 -08:00
rht
80ba105be5
provision: Abstract out SYSTEM_DEPENDENCIES.
2018-12-17 16:23:46 -08:00
rht
b732fe819e
provision: Add Fedora support.
2018-12-17 16:23:44 -08:00
Tim Abbott
d469c14d11
docs: Advertise arbitrary org GitHub patterns for linkifiers.
...
Now that we support this, we should make it really obvious that we do.
Also, link to the Help Center article.
2018-12-17 12:58:52 -08:00
rht
2dc1dc8ec2
provision: Replace overwrite_symlink with `sudo ln -sf`.
...
overwrite_symlink doesn't work for a non-root user when accessing root
content.
2018-12-17 11:50:15 -08:00
Tim Abbott
2558f101af
docs: Add documentation for `if False` mypy pattern in scripts.
...
This should help make it clear what's going on with these scripts.
2018-12-17 11:12:53 -08:00
Tim Abbott
209df75ffa
lint: Enforce use of Python 2 style typing in zulint.
...
This is intended to be extracted as an external project that supports
Python 2+3.
2018-12-17 11:00:08 -08:00
Tim Abbott
35901cc955
lint: Fix a tooling test failure in last commit.
...
This is what I get for copy-pasting lint rule blocks.
2018-12-17 10:53:08 -08:00
Tim Abbott
bce90a3340
lint: Add lint rule for scripts importing typing improperly.
...
This is a common bug that users might be tempated to introduce.
And also fix two instances of this bug that were present in our
codebase, including an important one in our upgrade code path.
2018-12-17 10:46:37 -08:00
Tim Abbott
6b69cc0b39
lint: Run mypy as part of main linter.
...
To support this, we add a pass_targets option to the main linter
library, because with current mypy, it's generally counterproductive
to pass the list of files in (can produce spurious errors; isn't
faster).
2018-12-16 21:52:53 -08:00
Tim Abbott
3003517430
docs: Move mypy documentation from contributing to testing.
...
The testing section is more appropriate, since it's fundamentally part
of our CI system.
While we're at it, fix the fact that we were linking to GitHub, not
ReadTheDocs, in the run-mypy output.
2018-12-16 21:52:53 -08:00
Tim Abbott
8637bdeb30
mypy: Provide a clear message when starting daemon.
...
Previously, when the mypy daemon was starting up, it was very unclear
from the linter context what was happening.
2018-12-16 21:52:53 -08:00
Tim Abbott
f3c6d91e69
mypy: Switch default to daemon mode.
...
There isn't any real advantage to running the non-daemon mode at this
point.
2018-12-16 21:37:58 -08:00
Tim Abbott
7485cb2a50
widgets: Rename voting_widget to poll_widget.
...
This ensures greater consistency with our other widgets' naming
convention.
2018-12-16 19:46:48 -08:00
Tim Abbott
adebe1bd4e
js: Extract csrf.js and include in common bundle.
...
This should make it possible to use this AJAX setup code in logged-out
code as well, which is necessary to use blueslip from portico pages.
2018-12-16 16:18:42 -08:00
Tim Abbott
ed9430f3a6
Revert "js: Extract csrf.js and include in common bundle."
...
This reverts commit dbffa66b6d
.
This broke the logged-in app, due to some webpack issue.
2018-12-16 16:16:06 -08:00
Tim Abbott
dbffa66b6d
js: Extract csrf.js and include in common bundle.
...
This should make it possible to use this AJAX setup code in logged-out
code as well, which is necessary to use blueslip from portico pages.
2018-12-16 15:35:54 -08:00
Tim Abbott
9059c4d223
provision: Make apt/yum retry logic more coherent.
...
This changes a few things:
* Deplicates deps_to_install logic.
* Has a retry flag, under which we can guard the apt retry print statements.
* Makes the install_system_deps flow more parallel.
2018-12-16 13:41:12 -08:00
rht
c6cde1cf5c
provision: Rename install_apt_deps to a more generic install_system_deps.
2018-12-16 13:39:00 -08:00
rht
389c46b4e5
provision: Extract yum-specific part of install_apt_deps.
2018-12-16 13:39:00 -08:00
rht
2be3065249
provision.py: Abstract out postgres version for CentOS.
2018-12-16 13:26:28 -08:00
rht
43bedc0909
provision: Use vendored pg_hba.conf on CentOS.
2018-12-16 13:21:54 -08:00
Tim Abbott
f2173bc2a7
check-capitalization: Add a few exclude rules for new strings.
2018-12-16 11:34:31 -08:00
rht
022e926d64
provision: Setup services for CentOS.
2018-12-16 10:14:51 -08:00
rht
9c776f4fcf
provision: Provide tsearch stopwords path for CentOS.
2018-12-16 10:14:08 -08:00
rht
8b5a86b992
provision: Initialize Postgres db on CentOS.
2018-12-16 10:11:55 -08:00
rht
41a5f6a49d
provision: Create symlink for pg_* on CentOS.
2018-12-16 10:11:54 -08:00
rht
10786375db
provision: Do not use apt-specific retry when a failure happens.
2018-12-16 10:04:27 -08:00
rht
25a8dbef11
provision: Build tsearch_extras from source for CentOS support.
2018-12-16 10:04:27 -08:00
rht
448303b3f0
provision: Initialize setup-yum-repo.
2018-12-16 10:04:27 -08:00
rht
85b2627191
provision: Add experimental support for CentOS.
2018-12-16 10:04:27 -08:00
rht
79bcb4af47
provision: Remove unused comment.
2018-12-16 10:04:27 -08:00
Steve Howell
d75ff80eb2
muting: Add stream_id to markup for mute settings.
...
We also prefer `attr` over `data` (it's more greppable).
2018-12-14 16:05:35 -08:00
Steve Howell
bf6f5e7bc5
muting: Pass stream_id to muting_ui.mute and unmute.
...
We temporarily allow settings_muting to have
incomplete line coverage--we will fix this soon.
2018-12-14 16:02:48 -08:00
rht
501ae0c3d6
provision: Add centos7 postgresql dependencies.
2018-12-14 04:59:48 +00:00