4 Commits

Author	SHA1	Message	Date
Tim Abbott	8faa854267	Revert "message_flags: Filter msgs having (or not) the flag before updating." ... This reverts commit 40fcf5a633. This commit triggers bug that we haven't fully tracked down, where web app clients will continually send `update_message_flags` requests, that then send out via the events system "0 messages were marked as read" notices, eventually leading to a load spike. The Tornado part can likely be fixed by checking if updated_message_ids is empty, but we need to track down the frontend bug as well.	2022-07-21 14:29:54 -07:00
Aman Agrawal	40fcf5a633	message_flags: Filter msgs having (or not) the flag before updating. ... We were blindly adding / removing flag from UserMessages without check if they even need to be updated. This caused server to repeatedly update flags for messages which already had been updated, creating a confusion for other clients like mobile. Fixes #22164	2022-07-07 10:52:36 -07:00
Alex Vandiver	803982e872	message_flags: Short-circuit if no messages changed. ... Omit sending an event, and updating the database, if there are no matching messages.	2022-05-12 21:57:55 -07:00
Anders Kaseorg	eb4e9fe1e7	actions: Split out zerver.actions.message_flags. ... Signed-off-by: Anders Kaseorg <anders@zulip.com>	2022-04-14 17:14:36 -07:00