1ceaedb2c5
docs: Remove html_unescape.py.
...
This was just for 1-time use exported the original Zulip documentation.
2017-10-08 15:41:41 -07:00
fbd24669a4
Cleanup: Remove shebang and executable flag from these files.
2017-10-08 15:38:15 -07:00
de30400fc5
pg_backup_and_purge.py: Remove .py extension.
2017-10-08 15:32:43 -07:00
ec080aed6b
mypy: Workaround lxml annotations being busted.
2017-10-08 12:38:20 -07:00
d215ea1e37
actions: Rename all_subs_by_stream to all_subscribers_by_stream.
...
The previous name sounded a bit too much like they were subcription
objects.
2017-10-08 12:33:53 -07:00
3e6bfe1b23
Use user_ids, not emails, for bulk stream operations.
...
We now return user_ids for subscribers to streams in add-stream
events. This allows us to eliminate the UserLite class for
both bulk adds and bulk removes. It also simplifies some JS
code that already wanted to use user_ids, not emails.
Fixes #6898
2017-10-08 12:31:12 -07:00
3c434f0d86
notifications: Switch to use `make_links_absolute()` from lxml library.
...
Instead of using custom regexes for converting relative URLs to
absolute URLs switch to using `make_links_absolute()` function
from lxml library.
2017-10-08 12:15:30 -07:00
810532641e
activity.js: Extract get_filtered_and_sorted_user_ids().
...
This function was extracted from build_user_sidebar(). We
also slightly streamlined it to not unnecessarily call
filter() when the filter text was blank. This extraction
also eliminated the need for us to have the two-line
filter_and_sort() function.
Also, we get to 100% coverage in this commit.
2017-10-08 12:01:59 -07:00
6888255153
Add people.get_realm_user_ids().
...
This saves us from doing an unnecessary map() in
activity.js.
2017-10-08 12:01:59 -07:00
943eefb7c0
activity.js: Extract get_filter_text().
...
We were using slightly different logic to get the filter
text in various places. Now we're consistent, and it's
easier to test the edge-case behavior.
2017-10-08 12:01:59 -07:00
3ef2df363b
activity.js: Consolidate initialization code.
...
We now intialize user-list-filter within activity.initialize(),
which gives us more control to set the module variable
`meta.$user_list_filter` before we build the user sidebar,
while setting up its handlers after we build the sidebar.
2017-10-08 12:01:59 -07:00
662b5ffbba
activity.js: Remove inaccurate comment.
...
The comment removed here doesn't make sense, since meta
is not exported.
2017-10-08 12:01:59 -07:00
86d372f9ce
lint: Prevent "userid" in code.
...
We should always use user_id for consistency sake.
2017-10-07 12:16:45 -07:00
10a30bece1
Rename presence_idle_userids -> presence_idle_user_ids.
2017-10-07 12:16:45 -07:00
e3ee0245c4
Change userid -> user_id in people.js.
2017-10-07 12:16:45 -07:00
fbaef43ac3
Rename bot_owner_userids -> bot_owner_user_ids.
2017-10-07 12:16:45 -07:00
aa4104a5af
logging: Add option to show the PID in each log message.
2017-10-06 19:21:40 -07:00
9cf44a77da
lint: Narrow the space-around-% patterns, remove exclusions.
...
This lint rule has bitten me a couple of times in working on logging.
These regex rules will inevitably be heuristic, but we can make it a bit more
specific so that the heuristic mainly means it could occasionally miss
something, rather than get in the way with an obviously wrong complaint.
2017-10-06 19:21:40 -07:00
4d33e66496
/terms/: Convert "terms" page to be styled like why/for pages.
...
This styles it to be like the why/for landing pages and have the new
small hero.
2017-10-06 17:01:34 -07:00
887b4d9fa8
/why-zulip/: Change "why" page to use smaller hero.
2017-10-06 17:01:34 -07:00
8d3ebd8b47
/for/*: Add ".small" version of why-page hero.
...
This adds a small version that has 130px less padding than the
original header.
2017-10-06 17:01:34 -07:00
057f9bafb0
Restyle privacy page to look like /for/ and "why" pages.
...
This restyles the privacy page from an older style to a new
updated style with the mini-hero and naturally readable width
text.
2017-10-06 17:01:34 -07:00
7b88e3eea7
tests: Add a test suite for verifying the mobile push notifs content.
...
This test suite works by using the expected_output and new text_output
fields in the bugdown test cases to verify that each syntax is
correctly translated by this new function.
Some of these translations, like strikethrough, are kinda poor; but
this framework should make it easy to iterate on the formatting.
Fixes : #6720 .
2017-10-06 16:47:27 -07:00
5a6584890d
push_notifications: Start using `get_mobile_push_content()` function.
2017-10-06 16:47:25 -07:00
28628eeaeb
push_notifications: Add `truncate_content()` function.
...
This function truncates the textual content at correct length.
(It will be updated later to handle corner cases of unicode
combining characters and tags when we start supporting them.)
2017-10-06 16:44:19 -07:00
b5a1aacfb3
push_notifications: Add `get_mobile_push_content()` function.
...
Given the rendered content of a message, this function strips
all the markup replacing emojis with their corresponding unicode
representation.
2017-10-06 16:44:18 -07:00
2b7dd8e437
requirements: Add 'lxml' as a dependency required for parsing HTML.
...
We need to parse rendered HTML content of messages while preparing
content for mobile push notifications and for doing so we need to
use lxml's HTML parser.
2017-10-06 16:37:17 -07:00
47c5aae5b2
log2zulip: Enforce using python 3 in cron job.
...
We aren't guaranteed to have the Zulip dependencies installed on
Python 2.
2017-10-06 16:37:17 -07:00
a197b82eb5
requirements: Upgrade mypy to version 0.530.
2017-10-06 15:55:11 -07:00
234f7960a1
tests: Add @slow decorator to various methods needing it.
...
Also, fix the test_message_editing test having way too many cases.
Fixes #1478 .
2017-10-06 15:45:04 -07:00
0d7617721c
test_messages: Clean up some slow tests.
...
One isn't actually slow; the other was doing something wasteful.
2017-10-06 15:44:17 -07:00
d5c2508858
tests: Remove unnecessary @slow decorators.
...
This is part of addressing #1478 .
2017-10-06 15:17:34 -07:00
9202777d7f
tests: Provide more useful output in assert_length().
2017-10-06 14:30:30 -07:00
d2966ae5d4
minor: Fix missing "not" in comment.
2017-10-06 14:08:41 -07:00
630037967f
docs: Stop linking to removed whitespace section of style guide.
...
We should probably just encourage linting for this.
2017-10-06 14:02:32 -07:00
73e1c26c15
test_events: Add missing nocoverage tag on debugging code.
2017-10-06 13:59:26 -07:00
ad521a0e07
minor: Add debugging statement to test.
...
This test is flaky for some unknown reason, so we print
out the loop index in case the test fails.
2017-10-06 13:56:37 -07:00
a99574ebf0
tests: Make apply-events tests easier to debug.
...
It's fairly difficult to debug tests that use
EventsRegisterTest.do_test, and when they fail on
Travis, it's particularly challengning. Now we make
the main diff less noisy, and we also include
the events that were applied.
2017-10-06 13:56:36 -07:00
0ac78cb14d
code-style: Simplify discussion of third-party code.
2017-10-06 13:28:45 -07:00
a632c8471d
code-style: Improve state and logs discussion.
2017-10-06 13:26:13 -07:00
e660faa225
docs: Remove code style section on jQuery global state.
...
I don't think anyone has tried to do this for a long time, since the
channel module makes it pretty clear how to do an ajax call.
2017-10-06 13:24:26 -07:00
0054fa17f1
docs: Simplify javascript var discussion.
...
We don't need as much as before, since it's enforced by the linter.
2017-10-06 13:24:06 -07:00
a9a22a3651
lint: Use new exclude_pattern system to clean up inline style lint.
2017-10-06 13:16:32 -07:00
7ff697d053
linter: Add rule against using `pk` instead of `id`.
...
There's one exception here, for model._meta.pk. To support this
nicely, we added this exclude-pattern feature.
2017-10-06 12:56:26 -07:00
747c283180
lint: Replace `pk` with `id` where they are equivalent.
2017-10-06 12:52:12 -07:00
64b8930225
linter: Add rules against improper shebangs.
2017-10-06 12:46:19 -07:00
71159fe19a
code style guide: Remove obsolete space-around-bracket rule.
...
For .py files, our pep8 linter enforces this rule.
For .js files, eslint enforces this rule.
2017-10-06 12:46:12 -07:00
cf3d035edf
eslint: Set array-bracket-spacing rule and clean project.
2017-10-06 12:43:12 -07:00
82b708b721
eslint: Add and enforce space-in-parens lint rule.
2017-10-06 12:36:59 -07:00
0c44310009
tests: Don't use caching session engine in tests.
...
Because we run tests in parallel, the caching session engine can lead
to nondeterministic failures.
2017-10-06 12:22:20 -07:00
Tim Abbott
rht
Steve Howell
Harshit Bansal
Greg Price
Brock Whittaker
derAnfaenger