Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
40,639 Commits 28 Branches 143 Tags 605 MiB
Commit Graph

490 Commits

Author SHA1 Message Date
Alex Vandiver 289b5bc100 lint: Re-enable imperative-mood checking. 
This was mistakenly disabled in e1f943913a.  Re-enable it.
 2021-02-23 14:54:07 -08:00
Alex Vandiver 12ade4c49d lint: Rely on core gitlint skipping of revert commits. 
gitlint 0.13.0 and above skip revert commits[1].  This obviates the
need for a custom rule.

[1] https://jorisroovers.com/gitlint/configuration/#ignore-revert-commits
 2021-02-23 14:28:09 -08:00
Anders Kaseorg 279c4b0e24 puppeteer_tests: Port to TypeScript. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-22 16:03:10 -08:00
Wesley Aptekar-Cassels 4173070b3d notifications: Fix composebox notification escaping 
The "Narrow to PM with" notification above the composebox was
double-escaped, mangling names with single quotes in them. This removes
the escaping in i18next, causing the name to be escaped only in
handlebars.
 2021-02-17 14:04:30 -08:00
Anders Kaseorg 6e4c3e41dc python: Normalize quotes with Black. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-12 13:11:19 -08:00
Anders Kaseorg 11741543da python: Reformat with Black, except quotes. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-12 13:11:19 -08:00
Anders Kaseorg 5028c081cb python: Merge concatenated string literals that Black would uglify. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-12 13:11:19 -08:00
aryanshridhar f92f99d92d dependencies: Replace moment.js with date-fns. 
Replaced methods/functions of moment.js with date-fns library.
The motive was to replace it with a smaller frontend timezone library.

Date-fns ~ 11.51 kb
moment.js ~ 217.87 kb

Some of the format strings change because date-fns encodes them
differently from how moment did.

Fixes #16373.
 2021-02-05 11:04:32 -08:00
Ganesh Pawar 7eeca9da46 provision: Add provision support for Ubuntu 20.10(Groovy). 
PostgreSQL 13 is used when os_version is 20.10.
 2021-02-05 09:30:34 -08:00
aditya-mitra b8f57fa6bb provision: Add provision support for KDE Neon 20.04. 
PostgreSQL 12 is used for Neon 20.04, which is a fork of Ubuntu 20.04.
 2021-02-03 11:51:05 -08:00
Sutou Kouhei 0d3f9fc855 install: Use PGroonga packages built for PostgreSQL packages by PGDG 
Because we always use PostgreSQL packages by PGDG since Zulip 3.0.

Fixes #16058.
 2020-12-18 15:38:21 -08:00
Anders Kaseorg 9359dee75b test_settings: Use TEST_EXTERNAL_HOST to override ‘testserver’ default. 
This allows test-backend to work even if the user has EXTERNAL_HOST
set to something else.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-17 13:07:59 -08:00
Anders Kaseorg d0d8c358b3 lint: Migrate typing.Text check to semgrep. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-11-16 18:17:41 -08:00
Alex Vandiver c1201bd69c provision: Rename variables to postgresql. 2020-10-28 11:57:03 -07:00
Alex Vandiver 2b0bbbb882 tools: Rename postgres to postgresql in tool names. 2020-10-28 11:57:02 -07:00
Alex Vandiver 1f7132f50d docs: Standardize on PostgreSQL, not Postgres. 2020-10-28 11:55:16 -07:00
Anders Kaseorg 31d0141a30 python: Close opened files. 
Fixes various instances of ‘ResourceWarning: unclosed file’ with
python -Wd.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-26 12:31:30 -07:00
Anders Kaseorg 72d6ff3c3b docs: Fix more capitalization issues. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-23 11:46:55 -07:00
Anders Kaseorg 5c6202ca97 notifications: Use a dynamic SVG favicon for unread counts. 
Closes #2304.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-21 07:43:00 -07:00
Anders Kaseorg 6099612a15 lint: Add shfmt as a linter. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-15 15:16:00 -07:00
Anders Kaseorg dd48dbd912 docs: Add spaces to “check out”, “log in”, “set up”, “sign up” as verbs. 
“Checkout”, “login”, “setup”, and “signup” are nouns, not verbs.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-13 15:47:13 -07:00
Anders Kaseorg 7f69c1d3d5 python: Catch specific exceptions from requests. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-11 16:11:41 -07:00
Anders Kaseorg 1c7db528bd test_server: Wait for run-dev after terminating it. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:15:19 -07:00
Alex Vandiver ece0aaa6cc tests: Remove use_db flag from test_server_running. 
It was only ever true, since 2563f93d46.
 2020-09-18 15:13:40 -07:00
Alex Vandiver 922940e223 tornado: Be more explicit about tornado configuration in testing. 
Passing this through the environment needlessly complicates the logic.
 2020-09-18 15:13:40 -07:00
Anders Kaseorg 3b301f522b python: Tweak some magic trailing commas to avoid Black bugs. 
https://github.com/psf/black/issues/1658
https://github.com/psf/black/issues/1671

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-03 17:51:09 -07:00
Anders Kaseorg f91d287447 python: Pre-fix a few spots for better Black formatting. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-03 17:51:09 -07:00
Anders Kaseorg 75c59a820d python: Convert subprocess.Popen.communicate to run or check_output. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-03 17:42:35 -07:00
Anders Kaseorg b4597a8ca8 python: Elide default for store_{true,false} argparse arguments. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-03 16:17:14 -07:00
Anders Kaseorg d751e0cece puppet: Don’t install netcat. 
It’s been unused since commit 0af22dad18
(#13239).

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-03 10:33:47 -07:00
Anders Kaseorg 0682d5c0f3 provision: Convert "".format to Python 3.6 f-strings. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-02 17:27:14 -07:00
Anders Kaseorg 424b441bb1 provision: Check for old Ubuntu or Python before starting Python. 
This unblocks us from being able to use Python 3.6 syntax in
provision.py and its dependencies.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-02 17:27:14 -07:00
Anders Kaseorg 1ded51aa9d python: Replace list literal concatenation with * unpacking. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-02 11:15:41 -07:00
Anders Kaseorg a5dbab8fb0 python: Remove redundant dest for argparse arguments. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-02 11:04:10 -07:00
Priyank Patel c1ba648b4f dependencies: Add xvfb dependency. 
The node package allow use to control xvfb apt package in puppeteer
tests. This help us create a fake display so we can run puppeteer in
headful (headless: false) mode, which is required to use the chrome
extension desktop capture API.
 2020-08-30 23:38:52 -07:00
Tim Abbott 2f5f5d7749 dependencies: Remove PhantomJS from development environment. 2020-08-30 17:16:02 -07:00
Anders Kaseorg 42aa916967 sanity_check: Test for the virtualenv by its path. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-08-11 12:30:26 -07:00
Anders Kaseorg 61d0417e75 python: Replace ujson with orjson. 
Fixes #6507.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-08-11 10:55:12 -07:00
Anders Kaseorg 768f9f93cd docs: Capitalize Markdown consistently. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-08-11 10:23:06 -07:00
Anders Kaseorg 18dcb86de5 Revert "provision: Fix missing <sasl/sasl.h> headers during provision." 
This reverts commit cc9dc07b07.  It was
merged with no review and has various issues (see #16086).

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-08-10 12:09:37 -07:00
Aman cc9dc07b07 provision: Fix missing <sasl/sasl.h> headers during provision. 
This fixes the error of missing sasl.h when compiling python-ldap
from source during provision.
 2020-08-09 23:21:13 -07:00
Anders Kaseorg d35b5027bb semgrep: Upgrade semgrep to 0.17.0. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-30 15:12:22 -07:00
Tim Abbott b350c6ffb7 lint: Add DevAuthBackend to capitalized strings. 2020-07-21 13:23:58 -07:00
Anders Kaseorg 6189e4d0c1 python: Convert more percent formatting to "".format. 
Semgrep has gotten a little more clever at applying the percent
formatting rule.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-13 13:16:38 -07:00
Priyank Patel e834439d82 provision: Do service <service-name> start instead of restart. 
Doing service memcached start instead of restart fixed an issue on
focal build in GitHub actions, where it exits with code 1 when it
is done twice.It is done first in Install Dependencies step and then
again in last step where we call tools/ci/setup-backend again which
runs provision.

Furthermore, I don't belive there is a technical reason we use
restart over start; rather I think it was just a random choice with
the intend to just start the services in CI. I traced the code back
to commit 1f2f497cab if it helps.
Looking at the source code of memcached, the step that's failing is:
  start-stop-daemon --stop --quiet --oknodo --pidfile $PIDFILE
which is equivilent to: service memcached stop, we can rule out the
service memcache start since it works. Ideally, we do figure out and
solve the issue of why memcached fails when executing service
memcached stop but I am not equipped with debugging it. And this
workaround seems reasonable rather than a "hacky" solution.

For the relevant code in memcached see:
https://github.com/memcached/memcached/blob/master/scripts/memcached-init.

Finally, the change to the rest of services is for consistency.
 2020-07-06 18:09:15 -07:00
Anders Kaseorg 8a03f8a070 html_branches: Fix strict_optional errors. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-06 11:25:48 -07:00
Priyank Patel b1c0c13008 provision: Include check for GitHub Action along with CircleCI. 2020-06-29 16:31:43 -07:00
Vishnu KS ce6203906f i18n: Mark notification bot message in notify_new_user for translation. 2020-06-26 14:57:16 -07:00
Felix a389c7390d calls: Add Big Blue Button as a Video Call Provider. 
Big Blue Button needs an API secret so communication to creating a
room has to be done server side.

Fixes #14763.
 2020-06-22 16:19:07 -07:00
Priyank Patel 89619767cd test_server: Double the timeout amount to avoid flakes. 
These timeout flakes, when running puppeteer test, have been fairly
frequent in CI, so increase the timeout.
 2020-06-22 12:30:32 -07:00