Aman Agrawal
80268c52df
ci: Notify in zulip when a build fails in GitHub Actions.
...
We use the circleci integration which already has a nice setup
for sending messages when triggered to send the build failure
notification.
2021-02-26 08:29:56 -08:00
shanukun
4b67946605
refactor: Make acting_user a mandatory kwarg for do_create_user.
2021-02-25 17:58:00 -08:00
Alex Vandiver
289b5bc100
lint: Re-enable imperative-mood checking.
...
This was mistakenly disabled in e1f943913a
. Re-enable it.
2021-02-23 14:54:07 -08:00
Alex Vandiver
12ade4c49d
lint: Rely on core gitlint skipping of revert commits.
...
gitlint 0.13.0 and above skip revert commits[1]. This obviates the
need for a custom rule.
[1] https://jorisroovers.com/gitlint/configuration/#ignore-revert-commits
2021-02-23 14:28:09 -08:00
Anders Kaseorg
279c4b0e24
puppeteer_tests: Port to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 16:03:10 -08:00
Anders Kaseorg
42f4156b36
test-js-with-puppeteer: Error on unhandled promise rejections.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 16:03:10 -08:00
Anders Kaseorg
ca0b01033d
lint: Remove custom whitespace rules already enforced by Black.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-17 22:21:42 -08:00
Wesley Aptekar-Cassels
4173070b3d
notifications: Fix composebox notification escaping
...
The "Narrow to PM with" notification above the composebox was
double-escaped, mangling names with single quotes in them. This removes
the escaping in i18next, causing the name to be escaped only in
handlebars.
2021-02-17 14:04:30 -08:00
Anders Kaseorg
57f2b8760a
shared: Format our one Flow file with Prettier.
...
Why not.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-14 07:03:32 -05:00
Anders Kaseorg
f21fbea7c7
lint: Replace (most of) pycodestyle with Black.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 13:11:19 -08:00
Anders Kaseorg
6e4c3e41dc
python: Normalize quotes with Black.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 13:11:19 -08:00
Anders Kaseorg
11741543da
python: Reformat with Black, except quotes.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 13:11:19 -08:00
Anders Kaseorg
5028c081cb
python: Merge concatenated string literals that Black would uglify.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 13:11:19 -08:00
Anders Kaseorg
1a4f70f1bc
lint: Convert sudo exclusion to double quotes.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:34:43 -08:00
Anders Kaseorg
fc2900c004
js: Convert static/js/settings_config.js to ES6 module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-10 10:27:14 -08:00
Anders Kaseorg
bbf7bd949b
eslint: Enable lines-around-directive.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-10 10:27:14 -08:00
aryanshridhar
f92f99d92d
dependencies: Replace moment.js with date-fns.
...
Replaced methods/functions of moment.js with date-fns library.
The motive was to replace it with a smaller frontend timezone library.
Date-fns ~ 11.51 kb
moment.js ~ 217.87 kb
Some of the format strings change because date-fns encodes them
differently from how moment did.
Fixes #16373 .
2021-02-05 11:04:32 -08:00
Ganesh Pawar
7eeca9da46
provision: Add provision support for Ubuntu 20.10(Groovy).
...
PostgreSQL 13 is used when os_version is 20.10.
2021-02-05 09:30:34 -08:00
Anders Kaseorg
aa650a4c88
js: Escape strings interpolated into CSS selectors with CSS.escape.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-04 11:00:06 -08:00
Anders Kaseorg
4bcf7131c1
push-to-pull-request: Wait for GitHub background update before merge.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-03 14:55:08 -08:00
aditya-mitra
b8f57fa6bb
provision: Add provision support for KDE Neon 20.04.
...
PostgreSQL 12 is used for Neon 20.04, which is a fork of Ubuntu 20.04.
2021-02-03 11:51:05 -08:00
Ganesh Pawar
5802bbfb98
ui_report: Add ui_report.client_error.
2021-01-30 07:48:44 -08:00
Riken Shah
baae227efb
run-dev: Fix dev url showing extra port.
...
This commit fixes the issue of `run-dev.py`
showing the development URL with an
extra port when EXTERNAL_HOST
is specified.
Fixes : #17054
2021-01-27 11:37:26 -08:00
Anders Kaseorg
2db2f2d6cd
dependencies: Upgrade JavaScript dependencies.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-01-25 14:53:19 -08:00
Aman Agrawal
599b86241f
postcss-simple-vars: Add media query breakpoint variables.
2021-01-25 14:49:32 -08:00
Ganesh Pawar
eefa687832
run-dev: Suppress the notices made by third-party tools.
...
This limits the `run-dev.py` startup output.
And made the terminal message a bit more clear about
accessing the server.
Fixes #16846
2021-01-22 18:00:30 -08:00
Anders Kaseorg
50121cce5e
push-to-pull-request: Add --merge option.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-01-22 18:00:25 -08:00
Anders Kaseorg
26a7b7196c
push-to-pull-request: Use getopt.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-01-22 18:00:25 -08:00
Steve Howell
c693ae8982
event tests: Cover do_update_user_status better.
...
We often send only one field (away or status_text)
to be updated.
So we have to make our schema support optional
keys.
As a result of the more flexible schema, we no
longer need to exempt the node fixtures from
our schema checks.
2021-01-20 13:17:32 -08:00
Steve Howell
09ff0c400d
tools: Rename tool to check-schemas.
2021-01-20 13:17:32 -08:00
Aman Agrawal
c685d36821
hipchat_import: Remove tool from codebase.
...
Remove functions and scripts used by HipChat import tool and
those which will no longer be required in future.
2020-12-23 08:28:49 -08:00
Anders Kaseorg
0c4239e387
js: Convert Object.assign({…}, …) to spread syntax.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-21 15:37:36 -08:00
Mateusz Mandera
160cc5120a
api: Require can_create_users permission to create users via API.
...
Allowing any admins to create arbitrary users is not ideal because it
can lead to abuse issues. We should require something stronger that
requires the server operator's approval and thus we add a new
can_create_users permission.
2020-12-21 13:20:21 -08:00
Tim Abbott
eca67135d1
run-dev: Simplify output and colorize link users should click.
2020-12-20 12:11:16 -08:00
Tim Abbott
47d513240c
run-dev: Clean up unnecessary memcached output, and document flush.
2020-12-20 12:11:16 -08:00
Tim Abbott
38ffaad325
django: Add custom runserver wrapper to limit startup logging.
...
This helps considerably in avoiding the `run-dev.py` startup output
confusing developers.
2020-12-20 12:11:16 -08:00
Sutou Kouhei
0d3f9fc855
install: Use PGroonga packages built for PostgreSQL packages by PGDG
...
Because we always use PostgreSQL packages by PGDG since Zulip 3.0.
Fixes #16058 .
2020-12-18 15:38:21 -08:00
Anders Kaseorg
9359dee75b
test_settings: Use TEST_EXTERNAL_HOST to override ‘testserver’ default.
...
This allows test-backend to work even if the user has EXTERNAL_HOST
set to something else.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-17 13:07:59 -08:00
Vishnu KS
9b6d92d322
docs check: Check only the file and directory GitHub urls of zulip/zulip.
...
f82cc4ed06
started checking all
zulip/zulip GitHub links in CI. Instead, it should have checked only
zulip/zulip file and directory links since checking other
links require making requests to GitHub servers.
2020-12-16 15:13:25 -08:00
Vishnu KS
0d7a290893
docs check: Improve the names of GitHub url variables.
2020-12-16 15:13:25 -08:00
ryanreh99
10559c05ee
build_pygments_data: Include zulip specific data in langs.
...
This fixes a bug where the typeahead did not include the
zulip specific langs (such a `quote`, `spoiler` and `math`)
as these weren't passed to the typeahead's source.
Introduced in af64c52166
.
Fixes #16862 .
2020-12-15 16:41:19 -08:00
Tim Abbott
90354c4e5f
tools: Fix running test-js-with-node from arbitrary paths.
2020-12-15 12:18:23 -08:00
Anders Kaseorg
c7a6902fe3
eslint: Remove and prohibit unused eslint-disable directives.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-10 18:08:45 -08:00
Anders Kaseorg
b3aa44c914
install-shfmt: Upgrade shfmt from 3.1.2 to 3.2.1.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-09 23:07:40 -08:00
Anders Kaseorg
bfd9999cf8
desktop_integration: Handle logout et al. events from desktop app.
...
I added these hooks in Zulip Desktop 5.5.0; handling these events in
the frontend will let us remove the janky desktop-side fallback code
that uses fake click events on menu items with specific indexes.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-08 16:39:17 -08:00
Isaac Evans
88a1204ce0
semgrep: Update rule syntax documentation URL.
2020-12-03 17:30:11 -08:00
Dinesh
85d7cdbf50
puppeteer: Add clear success message at end of a test run.
...
Also makes the failure message more noticeable.
2020-11-29 18:08:20 -08:00
Anders Kaseorg
af64c52166
build_pygments_data: Build langs without incorrect mutation.
...
The previous loop generated broken entries for duplicated language
aliases:
"juttle": {"priority": {"priority": 0, "pretty_name": "Juttle"}, "pretty_name": "Juttle"}
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-11-16 18:51:37 -08:00
Anders Kaseorg
d0d8c358b3
lint: Migrate typing.Text check to semgrep.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-11-16 18:17:41 -08:00
Anders Kaseorg
8115f8417b
build_pygments_data: Don’t recompute the name we already have.
...
This speeds up build_pygments_data from 6 seconds to 0.5 seconds.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-11-16 17:01:55 -08:00