Commit Graph

27 Commits

Author SHA1 Message Date
Zev Benjamin d610f2511f Fix search highlighting
The handlebars "../" syntax is the worst.

(imported from commit eadc9fbd47e384b618c06b30ab979b1c372649ff)
2013-11-13 17:28:48 -05:00
Steve Howell cb11780ded Remove whitespace from message template to make tests pass.
(imported from commit f577bae7651aab096e35ff9cb384a17fdc10fd97)
2013-11-12 16:47:32 -05:00
Waseem Daher 632ec1db47 Don't bold sender status when you use /me.
(imported from commit a88628bb5354f4be3db31e161e744d349e15c570)
2013-11-12 14:36:52 -05:00
Steve Howell 56c39728ba Support /me syntax.
If a user types "/me runs to the store", we put "runs to the store"
in bold after their name.

(imported from commit fbc11e99244e1c8fa1c03e4753e706957fcd449e)
2013-11-12 10:49:10 -05:00
Steve Howell e2213eae9a Fix indentation in message.handlebars
(imported from commit 186bd9506aa6a7d3052f1f96e8af05a22812a636)
2013-10-09 17:18:26 -04:00
Steve Howell a78a1ec36c Use <a> tags for links in the recipient/summary bars.
The main user-facing feature here is that users can open narrows
in new tabs or windows. Internally, it makes the HTML more semantic.

One consequence of making these elements into actual anchor tags
is that clicking on them no longer triggers this logic to
close the compose box when you click outside of it:

        // Unfocus our compose area if we click out of it. Don't let exits out
        // of modals or selecting text (for copy+paste) trigger cancelling.
        if (compose.composing() && !$(e.target).is("a") &&
            ($(e.target).closest(".modal").length === 0) &&
            window.getSelection().toString() === "") {
            compose.cancel();
        }

Instead of patching the above code, I elected to just call
compose.cancel() explicitly in the click handlers for the links
themselves.

We are gonna try to clean up the compose-box behavior globally soon.

(imported from commit c9a01916f1714fe3dd495d25c78cd5e5532105ef)
2013-10-09 17:09:10 -04:00
Steve Howell ffaa8c4d76 Fix bad tags in message.handlebars
(imported from commit 507d5ce1666e66f613ccef8932c0a51ce3c94aa8)
2013-10-08 17:21:48 -04:00
Steve Howell dfcc974d5f Add </a> closing tags for exterior topic links
(imported from commit c54615088faf712cc5ccaa982c5091b54ccf634d)
2013-10-08 11:39:03 -04:00
Steve Howell 28aefb7a3a Add whitespace/comments to message.handlebars.
I added comments to the section of the template that generates
recipient bars for stream/topic messages.

(imported from commit a7ea9353dc5db20db3410b9566f5e0d670eff31f)
2013-10-08 11:39:02 -04:00
Steve Howell 8d67fc2775 Add semantic classes for expanding/collapsing messages
(imported from commit 9d71fd46667058ba92d941b79d6e2c822c721efe)
2013-09-11 14:42:25 -04:00
Steve Howell 04a0e88724 Add recipient bar features to summary bar.
The summary bar now has the following features:
  * invite-only locks
  * narrowing links to stream/topic/person
  * exterior topic links

(imported from commit ddb987b8e04e7dfc2d602c958270b7bc0e37fb5f)
2013-08-27 15:46:33 -04:00
Scott Feeney bee38a43f0 Fix incorrect use of self-closing tags
<td /> is not valid HTML.

(imported from commit e7914f88a7eedde887a8f6751d7516de1ccf99bf)
2013-08-27 15:32:20 -04:00
Steve Howell 8c1f20a8be Fix topic highlighting in search result
(imported from commit 8ef6575eeb69314c37033ee63af550104608efc8)
2013-08-26 17:06:16 -04:00
Steve Howell 5ef5d98a99 Fix hover for collapsible recipient bars
(imported from commit 75f93c705fd7e9b3433c4adb374df47ba5b585b4)
2013-08-26 16:38:34 -04:00
Steve Howell 7fb99761e1 You can only expand rows by clicking on [+].
(imported from commit 23a52feca13232bf36038cd7f59c520f9106ee2c)
2013-08-26 16:38:34 -04:00
Steve Howell 4a7bab9a6f Allow collapsing of recipient sections.
This is experimental, for staging only.  There might be a better
way to model this than dueling force_expand/force_collapse flags,
but it works for now.  The code in collapse_recipient_group()
could also be DRYed up relative to expand_summary_row().

(imported from commit 107151d1ecd640970fb7700d41278a003bd1abaa)
2013-08-23 15:57:31 -04:00
Steve Howell 9662594bf4 Add data-messages attribute to recipient rows.
This is to set up collapsing, but I think they could be useful
in general, so I'm keeping this is a separate commit.

(imported from commit 0da2b8ef246649f678c7cb6664ee78bf36aca076)
2013-08-23 15:57:31 -04:00
Steve Howell 795248a1d0 Mute any topic named "muted" on zulip.com.
This change will allow us to test the muting feature on
staging.  Any topic named "muted" will automatically be
muted.  You can also mute any other topic on the console:

    muting.mute_topic('devel', 'ios');
    current_msg_list.rerender();

More UI around this experiment will be coming soon, as well
as support for muting entire streams.

The muting module keeps track of which topics are muted, but a
user can expand muted messages, and once that happens, the
messages are marked with the "force_expand" flag that gets
persisted to the back end.

Muted messages are rendered in similar fashion to the summarized
rows, and as part of unifying some of that code, we have
made it so that expanding a summarized section doesn't remove
individual flags related to summaries; instead, the messages
get the force_expand flag set.

(imported from commit acee4190e63813d46850415c41ff8ebfae4a6953)
2013-08-23 12:10:27 -04:00
acrefoot 395aaae994 Allow anyone to edit a "no topic" message
This change would allow anyone in the realm to set a topic for a "no topic"
message. As soon as the message topic is set, only the sender can change it again.

(imported from commit 0a91a93b8fd14549965cedc79f45ffd869d82307)
2013-08-19 16:29:30 -04:00
Steve Howell 6ba256d57d Fix search highlighting regression. (#1658)
If you search for "hello", then the word "hello" will once again
be highlighted yellow in the messages.

(imported from commit 172a40f1e288f9947ab3bfbff82b4a2f5ba5cecb)
2013-08-09 15:46:47 -04:00
Kevin Mehall 5d65de9b82 summarize-experiment: Fix an uncommon case that breaks rows.get().
One of the ugly parts of message_list.js is how it re-uses the message objects
from the server to hold handlebars template parameters. These objects are
shared between different message lists and re-renders, but are mutated by the
rendering process. The `dom_id` attribute is normally unset on summary rows,
and should not be used in the template. But when a message comes in with a
`dom_id` from another render, it can end up on the summary row, breaking
`rows.get()`.

(imported from commit ef6af65d5e995dffbd7234547786d6ea861920da)
2013-08-08 17:54:52 -04:00
Kevin Mehall 9be559858e Summarization style improvements
(imported from commit 4029d96d60cae0c6856067a696a842c39f4248e3)
2013-08-08 13:04:01 -04:00
Kevin Mehall 2664002dec Make summary rows selectable.
We represent summary rows by the ID of their first message for
for selection purposes.

(imported from commit 9f3c4d23f6b1295b117d5197e214de983bb2cc20)
2013-08-08 13:04:01 -04:00
Waseem Daher 7517cd8ad8 Slightly more compact "summarized messages" format.
(imported from commit 3870be2bc88145ea07c8bdb54309df201d617237)
2013-08-08 11:36:27 -04:00
Kevin Mehall eac6463031 Implement message summarization experiment.
When you read messages in a narrow and then un-narrow, collapse
adjacent messages read in the narrow into a summary row that can
be clicked to expand those messages.

Scoped to staging with feature flags.

The implementation of this within our current MessageList is rather ugly.

(imported from commit bcb3a39d8c0c334136fe86318f18ead03f0f50bf)
2013-08-07 10:24:03 -04:00
Waseem Daher d7da9d8bad Switch to using Font Awesome everywhere.
(imported from commit 406ac9e8e24066e45833a71adcdd95b26b5cfb9b)
2013-08-02 14:49:28 -04:00
Tim Abbott 3bba0cc927 Move zephyr/static to just static.
It's not really a part of the server (aka the rest of zephyr/).

(imported from commit 27f6b6b064938ad927075a68d873e4b68710d279)
2013-07-29 12:11:26 -04:00