7ee3484b7b
portico-styles: Rename to portico_styles.css.
2020-10-19 11:50:39 -07:00
51f82ad839
right_sidebar: Rename .css file to right_sidebar.css.
...
This changes the file name to existing conventions, it does not,
however, change the actual `.right_sidebar` tag used in the
app.
2020-10-18 14:09:47 -07:00
bd72ba76f3
left-sidebar: Rename .css file to left_sidebar.css.
...
This changes the file name to existing conventions, it does not,
however, change the actual `.left_sidebar` tag used in the
app.
2020-10-18 14:09:47 -07:00
46a74d3e08
informational-overlays: Rename .css file to informational_overlays.
...
This changes the file name to existing conventions, it does not,
however, change the actual `.informational-overlay` tag used in the
app.
2020-10-18 14:09:47 -07:00
1e5873df9e
text-error-css: Use same color as used by bootstrap for text-error.
2020-10-18 14:06:20 -07:00
1849ca41d2
login: Top right align error message.
...
Fixes the alignment issues and this better indicates the field to
which error message belongs to.
2020-10-18 14:06:20 -07:00
8297121050
Revert "login: Fix alignment of error message in login form."
...
This reverts commit 6fe82620df
2020-10-18 14:06:20 -07:00
178e0b7d47
navbar: Use location.href instead of location.replace.
...
As per https://stackoverflow.com/questions/1865837/ location.href
should be preferred to location.replace in some places due to the
fact that location.replace violates browser history and breaks back key.
2020-10-18 14:05:45 -07:00
fbf7cb82a7
web_public_guest: Rename to web_public_visitor for clarity.
...
Using web_public_guest for anonymous users is confusing since
'guest' is actually a logged-in user compared to
web_public_guest which is not logged-in and has only
read access to messages. So, we rename it to
web_public_visitor.
2020-10-13 16:59:52 -07:00
dd48dbd912
docs: Add spaces to “check out”, “log in”, “set up”, “sign up” as verbs.
...
“Checkout”, “login”, “setup”, and “signup” are nouns, not verbs.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-13 15:47:13 -07:00
111ba564ae
popover: Show normal popover for the `stream_subscription_info` users.
...
This shows the normal popover instead of extended profile.
We use the standard event handler attached to the body element in
`popovers.js` instead of attaching a new one.
2020-10-12 17:42:52 -07:00
264bf1fc2a
css: Hide bottom-right resizable box in view-source textarea.
2020-10-08 17:13:50 -07:00
adfe4cacc6
css: Add vertical scrollbar styling for view-source textarea.
...
This styles the vertical scrollbar similar to the horizontal
one for <pre/> (which can be seen in narrow windows). Strictly
speaking, this change shouldn't go in rendered_markdown.scss, but
placing it there helps unify the two scrollbar stylings rather than
duplicating them.
2020-10-08 17:13:50 -07:00
ab9a011f89
css: Modify button styling to adjust for svg size change.
...
This builds on the previous commit and adds final touches to
both the button positioning and style.
2020-10-08 17:13:50 -07:00
b0c37713e5
templates: Extract and tweak copy_to_clipboard_svg from both buttons.
...
Since both the original button svg's have their own individual height
and width, this commit tweaks it to values height=20 and width=16 which
works well for both buttons.
2020-10-08 17:13:50 -07:00
413df1881e
templates: Extract and tweak copy_message_button from message_edit_form.
...
Small tweak in the extracted text which adds aria-lable to the button.
2020-10-08 17:13:50 -07:00
792029cbb8
css: Refactor copy_message button to use copy_button_base class styling.
...
Z-index is added to the base class. This doesn't affect copy_code_button
in any way.
Attributes dropped/changed:
- background-color
- Base class on-hover property is now used.
- height, width, padding is now the base classes.
We can also remove the TODO now.
2020-10-08 17:13:50 -07:00
26ff6db751
css: Extract copy_button_base from copy_codeblock class.
...
The base class will contain common styling which is used by both
copy_codeblock and copy_message buttons. This sets us up nicely
for following commit(s) which aims to unify the two button styling.
2020-10-08 17:13:50 -07:00
623fb63406
recent_topics: Go to topic if user clicks anywhere in topic col.
2020-10-08 17:05:06 -07:00
d3f4f64b0e
timerender: Extract func to calculate days_old from time.
2020-10-08 17:05:06 -07:00
c7d66421f9
sidebars: Fill search boxes to full width.
...
After our bootstrap upgrade, search boxes were not full width on
when sidebars acted as popovers on small widths.
2020-10-08 17:03:56 -07:00
8b419c93e4
message_send: Fix old guests being treated as full members.
...
For streams in which only full members are allowed to post,
we block guest users from posting there.
Guests users were blocked from posting to admin only streams
already. So now, guest users can only post to
STREAM_POST_POLICY_EVERYONE streams.
This is not a new feature but a bugfix which should have
happened when implementing full member stream policy / guest users.
2020-10-08 11:30:11 -07:00
6fe82620df
login: Fix alignment of error message in login form.
2020-10-07 16:18:54 -07:00
81d21068b5
eslint: Fix no-useless-concat.
...
https://eslint.org/docs/rules/no-useless-concat
And add some escaping to static/js/markdown.js while I’m here.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
5c8117a426
eslint: Fix no-implicit-coercion.
...
https://eslint.org/docs/rules/no-implicit-coercion
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
0042cf51c1
eslint: Fix unicorn/better-regex.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/better-regex.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
65f86274b2
eslint: Fix unicorn/prefer-dataset.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-dataset.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
e68595a3fc
eslint: Fix unicorn/no-reduce.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-reduce.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
62dfee4930
eslint: Fix unicorn/prefer-node-append and unicorn/prefer-node-remove.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-node-append.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-node-remove.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
8098acb63c
eslint: Fix unicorn/prefer-trim-start-end.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-trim-start-end.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
78ccb15d9e
eslint: Fix unicorn/no-zero-fractions.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-zero-fractions.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
0d4af4f8e7
eslint: Fix unicorn/prefer-type-error.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-type-error.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
e0b1daa96d
eslint: Fix unicorn/prefer-add-event-listener.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
2694f5caed
eslint: Fix unicorn/prefer-array-find.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-array-find.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
72cc78dfa3
js: Optimize out unnecessary jQuery filter calls.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
fd11c9c666
eslint: Fix unicorn/prefer-includes.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-includes.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
b178fc6069
eslint: Fix unicorn/prefer-set-has.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-set-has.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
de791b82b6
eslint: Fix unicorn/no-for-loop.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-for-loop.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
73a14bee6f
eslint: Fix unicorn/escape-case and unicorn/no-hex-escape.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/escape-case.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-hex-escape.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
f92224c744
eslint: Fix unicorn/catch-error-name.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/catch-error-name.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
d654992164
eslint: Fix unicorn/prefer-optional-catch-binding.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-optional-catch-binding.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
70a0260ac1
eslint: Fix unicorn/prefer-text-content.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-text-content.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
bd05f1c9f8
eslint: Fix unicorn/prefer-query-selector.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-query-selector.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
c7cbdba257
eslint: Fix unicorn/{new-for-builtins,throw-new-error,error-message}.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/new-for-builtins.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/throw-new-error.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/error-message.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
48f5e5179a
eslint: Fix unicorn/prefer-string-slice.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-string-slice.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
fb233bd994
eslint: Fix unicorn/prefer-number-properties.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-number-properties.md
MDN says these were added to Number for modularization of globals.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
98529564ae
reactions: Handle missing realm emojis.
...
For the lines of code that I changed here, we were
getting field reports that the below code
was getting `undefined`:
emoji.all_realm_emojis.get(r.emoji_code)
It's not really clear to me how this could happen,
but we definitely should fail softly here. We
still report it as an error, but we let the function
return and don't trigger a TypeError.
If there's a legitimate reason for realms to delete
realm emojis, we should either downgrade this to a
warning or consider a strategy of back-fixing messages
when realm emojis get deleted.
2020-10-06 17:22:54 -07:00
90dccbf7c3
i18n: Fix quotes in mute setting help message.
2020-10-02 15:01:48 -07:00
55a67ee7c5
message_edit: Display Formatting button as "Help".
...
Match the compose change b245e1e49a
2020-10-02 14:54:14 -07:00
d99c3c0b55
message_edit: Reorder buttons to match compose.
...
Match the compose change 0c6df114f6
2020-10-02 14:54:14 -07:00
YashRE42
Aman Agrawal
Anders Kaseorg
ryanreh99
Sumanth V Rao
Steve Howell
Vishnu KS
Gittenburg