zulip

Commit Graph

Author	SHA1	Message	Date
Steve Howell	a0712ab798	minor: Consolidate vars for max topics. The two vars here got split apart for temporary logistical reasons during a recent refactoring. Now they're just both at the top of topic_list_data.	2020-01-30 12:15:40 -08:00
Steve Howell	fa82d12525	topic list: Extract topic_list_data.js. This is mostly for tactical reasons. It's hard to get 100% test coverage on topic_list.js, but it should be easy to get 100% test coverage on this very important function. I considered just moving this code into topic_data.js, but it just didn't feel quite right. I feel like this is a pretty core piece of code that's nice to be by itself and not be near other complicated code that does stuff like build widgets or talk to servers. (And, again, it's not just the actual code here, which is pretty small, it's the unit tests, which are inherently verbose to exercise all the edge cases.)	2020-01-22 14:31:33 -08:00

Author

SHA1

Message

Date

Steve Howell

a0712ab798

minor: Consolidate vars for max topics.

The two vars here got split apart for temporary
logistical reasons during a recent refactoring.

Now they're just both at the top of
topic_list_data.

2020-01-30 12:15:40 -08:00

Steve Howell

fa82d12525

topic list: Extract topic_list_data.js.

This is mostly for tactical reasons.  It's hard to
get 100% test coverage on topic_list.js, but it
should be easy to get 100% test coverage on this
very important function.

I considered just moving this code into topic_data.js,
but it just didn't feel quite right.  I feel like
this is a pretty core piece of code that's nice
to be by itself and not be near other complicated
code that does stuff like build widgets or talk
to servers.  (And, again, it's not just the actual
code here, which is pretty small, it's the unit
tests, which are inherently verbose to exercise
all the edge cases.)

2020-01-22 14:31:33 -08:00

2 Commits