8430674aee
popovers: Remove unused popover-content class.
...
Fixes #26821
2023-10-09 11:39:12 -07:00
a04117b6d3
user_group_info_popover: Remove bootstrap popover classes.
...
Added a `group-info-content` inplace of them and added the required
CSS.
2023-10-09 11:39:12 -07:00
04c4b6e8b8
giphy: Move `popover-content` styles to `giphy-scrolling-container`.
2023-10-09 11:39:12 -07:00
094ac010fb
user_card_popover: Remove popover content class.
...
Added CSS styles that were removed due to this back. No visual
changes.
2023-10-09 11:39:12 -07:00
ce656da8d7
emoji_popover: Remove popover-content div.
...
`popover-content` class had no effect on emoji popover since
it was resetting `padding: 0` and background color was
already applied by tippy theme.
In short, removing `popover-content` had no visual changes.
2023-10-09 11:39:12 -07:00
5cd2b0ed86
giphy: Remove old comment.
...
Destroying popover_instance is now part of how tippy popovers work.
2023-10-09 11:39:12 -07:00
0976b9006e
popover-title: Remove class.
...
Remove bootstrap-tooltip class `popover-title` from code.
It was only used in user_card_popover for showing user avatar,
so cleaned up properties that were duplicated or not required.
2023-10-09 11:39:12 -07:00
b9fe1947f8
navigate: Move scroll_to_selected to message_viewport.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 11:32:16 -07:00
18bdfde9e7
recent_view_ui: Cut import of unread_ops.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 11:32:16 -07:00
95785739ac
navbar_alerts: Move resize_app to resize.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 11:32:16 -07:00
7ffdeecd86
styles: Remove CSS for ".modal-header".
...
We do not use "modal-header" on any elements now, so
we can remove the redundant CSS rules defined for it.
2023-10-09 11:25:26 -07:00
747b62d050
bootstrap: Remove code for bootstrap modals.
...
We use micromodal library for all the modals now and thus
we no longer require the bootstrap modal code.
2023-10-09 11:25:26 -07:00
37d12250ed
modal: Re-add required bootstrap CSS for ".modal-body".
...
This commit adds the required bootstrap CSS rules for
".modal-body" elements to modal.css so that we can remove
them from bootstrap.css.
2023-10-09 11:25:26 -07:00
5e263fc4ed
subscriptions: Re-add bootstrap CSS for modal-footer elements.
...
We use "modal-footer" class in stream and user group creation form
and this commit adds bootstrap CSS rules for it to subscriptions.css
so that we can remove the CSS from bootstrap.css.
2023-10-09 11:25:26 -07:00
5b7014e7d6
server_history: Prevent concurrent requests for the same stream_id.
...
This commit updates the 'get_server_history' function to return
early if a request is already in progress for a given stream_id,
thus preventing concurrent requests for a single stream_id.
We maintain a set 'request_pending_stream_ids', which contains all
the stream IDs for whom requests are in progress.
Using this set, we return early.
Fixes #26915 .
2023-10-09 11:17:03 -07:00
0cdb54cf65
compose: Ensure cursor is scrolled into view after content is inserted.
...
This fixes the bug where on pressing enter after the last line in a
textarea, the cursor would go to the new line but the textarea would
not scroll it into view unless more was typed. This was observed on
chromium browsers.
A new function `insert_and_scroll_into_view` is added to `compose_ui.js`
which blurs and refocuses the textarea after inserting the content, then
autosizes the textarea.
2023-10-09 11:13:53 -07:00
acdae9eae2
reload: Don't reload on 403 error for spectators.
...
Fixes #26280
2023-10-09 11:00:33 -07:00
8299506e7a
reload: Handle early attempts at reload when loading the app.
...
Trying to preserve state when app modules like message_lists
haven't been init results in errors.
2023-10-09 11:00:33 -07:00
5327bcc5ac
user_group_settings_ui: Merge into user_group_edit.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 10:58:50 -07:00
63b4e74cea
views_util: Cut import of narrow.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 10:54:00 -07:00
e8ced3e74a
hello: Fix google analytics not working.
...
Since GA was only imported in portico bundle which we don't use
in hello page due to bootstrap, GA was not loaded.
2023-10-08 17:30:02 -07:00
70748181da
recent_view_ui: Cut import of user_card_popover.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 19:45:13 -07:00
27991bd5b0
topic_zoom: Merge into stream_list.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 19:43:55 -07:00
a43ea3efaa
pm_list: Cut import of topic_zoom.
...
topic_zoom.is_zoomed_in() can’t be true in pm_list.zoom_in, because
“more conversations” would not be visible in that state. And it can’t
be true when pm_list.handle_narrow_activated calls pm_list.expand,
because “more topics” would not be visible in an all-DM view. So the
only non-inert call is via click_handlers; move it there.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 19:43:55 -07:00
564e91f3a8
narrow: Cut import of hashchange.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 19:41:59 -07:00
4adfd57378
message_fetch: Rename batch size constants to specify narrow views.
...
This is in preparation for introducing a batch size constant for
the recent view.
2023-10-06 17:30:33 -07:00
ba1895cb1c
notifications: Rename to desktop_notifications.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 16:22:40 -07:00
fcaf1fe7d5
notifications: Split out audible_notifications module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 16:22:40 -07:00
6ef08873d8
notifications: Split out compose_notifications module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 16:22:40 -07:00
db20fd12e0
notifications: Split out message_notifications module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 16:22:40 -07:00
e48771993b
widgetize: Move widget registration to new widgets module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 13:17:51 -07:00
0c991d813f
sent_messages: Lift event loop restarting to transmit.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 13:17:51 -07:00
339b1351f8
echo: Pass transmit.send_message as a callback.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 13:17:51 -07:00
b9dd4a14c9
hello: Write better variable names.
2023-10-06 12:51:57 -07:00
cbb09f4ee6
hello: Fix client logos not changing on hello page.
...
Since `zulip.com` doesn't has `/hello` in URL, the JS code
for hello page events was not running. We extract it to a new
file and just always run it.
2023-10-06 12:51:57 -07:00
b274169ccc
util: Fix the 'find_wildcard_mentions' function.
...
The function considers @**all**, @**everyone**, @**stream**,
and @**topic** as wildcard mentions.
Earlier, the function didn't have a check to match @**topic**
in the message_content.
2023-10-06 11:38:37 -07:00
1a867a43a7
left_sidebar_inbox_popover: Move to new popovers folder.
2023-10-06 11:24:40 -07:00
115de0e847
inbox_ui: Fix unable to insert new stream.
...
There were 2 issues:
* Wrong format for creating new Map object used.
* Use of `topic_dict` instead of `topics_dict`, which resulted
in `stream_key` being present in `topics_dict` even after stream
has been marked as read. This made inbox believe that the
stream was already rendered even though it was not.
2023-10-06 10:50:34 -07:00
9dc1e8ed17
sent_messages: Finish .received → .saw_event rename.
...
Commit 3cc2adcd3b#25423 ) missed this
in the rename, resulting in extra creation of no-op timers.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 10:49:42 -07:00
4e9c1293e2
compose: Only save as draft when the compose state is about to change.
...
Up until now, we unconditionally saved any message content as a draft
whenever the composebox was `start`ed. This led to a lot of unnecessary
saving of drafts even when the composebox stayed undisturbed.
To fix this, now we only save the draft when the compose state is about
to be overidden, which is by either changing the recipient narrow or by
restoring another draft.
Fixes : #26976 .
2023-10-06 09:22:41 -07:00
895439ad83
register: Move style to css file.
2023-10-06 09:19:01 -07:00
e1b22a04e7
register: Fix for small widths.
2023-10-06 09:19:01 -07:00
15e837ff25
org_registration: Fix page for mobile widths.
2023-10-06 09:19:01 -07:00
f19d7e36ee
recipient-row: Remove logic for floating recipient bar.
...
In #23900 , the floating recipient bar was replaced with a sticky
recipient bar. The logic in `id_for_recipient_row` was not updated
for that change, so we update that function to just get the first
message in the group and return that message ID.
2023-10-06 09:13:27 -07:00
971a003180
compose_actions: Extract compose_reply module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 09:07:43 -07:00
f85f904fc1
user_profile: Remove redundant call to popovers.hide_all.
...
`show_user_profile` is only triggered by clicks. Even `enter`
keypress is triggers a click via
`popover_items_handle_keyboard_with_overrides`.
2023-10-06 09:03:46 -07:00
6cfb7239c8
popover_menus: Remove hide_all from on_show functions.
...
Since popovers only open after a click, all popovers hide already
if the clicks were outside them.
2023-10-06 09:03:46 -07:00
4e4daf2ce5
overlays: Call open and close hooks for modals too.
...
Right now, the hooks only have a popovers.hide_all call but this
may need to audited when used in future. Added a comment to
that effect.
2023-10-06 09:03:46 -07:00
3cbfe6f31f
tests: Remove unnecessary mocks of recent_view_util.
...
Since is_visible was refactored to use a variable, these mocks
are not required.
Also, since is_visible return `false` by default, mocking it
to return false is not required.
2023-10-06 08:35:21 -07:00
c56f784489
compose: Move update_email to compose_state.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 08:34:39 -07:00
833a15e121
compose: Move call button display functions to compose_call_ui.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 08:34:39 -07:00
9c70f92514
reload: Move initialize to new reload_setup module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 08:34:39 -07:00
c4d338a6ab
drafts: Extract drafts_overlay_ui module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 08:30:31 -07:00
d5064fc7b2
narrow: Extract narrow_title module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 16:26:45 -07:00
f2a00c7b9d
inbox: Render rows in sorted order.
...
Fixes #26962
We sort topic and dm data by latest_msg_id and render them.
For updates, we remove rows which for which latest_msg_id was
changed and them insert them again at the correct index.
2023-10-05 15:52:02 -07:00
1d126078a2
unread: Add option to include max msg id in unread topic/dm data.
2023-10-05 15:52:02 -07:00
57c1c56028
inbox: Migrate data objects to use Map.
...
Since Map store values in insertion order, it will be required
to show rows sorted by time.
This is not pretty but can be improved when
https://github.com/handlebars-lang/handlebars.js/pull/1996
is released.
2023-10-05 15:52:02 -07:00
ab1eb78c21
inbox: Fix incorrect dict being accessed.
...
topics_dict[stream_key] is a dict of topics and doesn't have
is_hidden property. We actually want to access streams_dict
here.
2023-10-05 15:52:02 -07:00
dd584ba8a9
stream_settings_ui: Move set_color to stream_settings_api.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 15:32:04 -07:00
62015a0b48
portico: Remove now-unnecessary twitter-tweet CSS and JS.
...
The content that this affected was removed in acd0c5568a
2023-10-05 15:06:10 -07:00
c4221332cd
stream_color: Add missing $ prefix to set_colorpicker_color parameter.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 14:52:13 -07:00
e8a2a5ce36
compose: Move initialize to new compose_setup module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 14:42:19 -07:00
6e725f0d17
compose: Move call link insertion to new compose_call_ui module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 14:42:19 -07:00
13e1a389b0
help: Fix missing icons in "Stream permissions".
...
This brings back the icons in the legend for the Stream permissions
tables that disappeared somehow.
2023-10-05 12:11:51 -07:00
c54ca567a9
typeahead: Only return early from blur if parentElement is specified.
...
From a bug reported here:
https://chat.zulip.org/#narrow/stream/9-issues/topic/Typeahead.20fails.20to.20automatically.20close/near/1655321
2023-10-05 11:51:42 -07:00
3d804ef186
pm_list: Rename handle_narrow_deactivated.
...
It did the same thing as handle_narrow_activated when passed the
home_msg_list filter.
We still leave a renamed version for use by the inbox/recent views.
2023-10-05 10:31:23 -07:00
0a189119aa
stream_list: Rename handle_narrow_deactivated.
...
It did the same thing as handle_narrow_activated when passed the
home_msg_list filter.
We still leave a renamed version for use by the inbox/recent views.
2023-10-05 10:31:23 -07:00
20b2323c67
left_sidebar: Deduplicate handle_narrow_deactivated.
...
handle_narrow_activated did the same thing is passed the home_msg_list
filter.
2023-10-05 10:31:23 -07:00
246139e1d0
narrow: Extract handle_post_view_change.
2023-10-05 10:31:23 -07:00
62fe1dcad1
narrow: Simplify compute_narrow_title for All messages.
...
filter.get_title() already returns "All messages" for the filter we
now pass in, which is the "in:home" operator defined by that view.
2023-10-05 10:31:23 -07:00
4465262bcb
narrow: Pass a msg_list to handle_post_narrow_deactivate_processes.
2023-10-05 10:31:23 -07:00
ab15462669
hashchange: Remove duplicate handle_narrow_deactivated call.
...
narrow.deactivate calls this directly.
2023-10-05 10:31:23 -07:00
f88715cb2c
signup: Use portico_modals module to handle modal on signup page.
...
This does not results in any behavioral or UI change, we just
use portico_modals module to open and close the modal instead
of directly calling functions like Micromodal.open and
Micromodal.close. This change also solves a bug where the
modal was not closed previously on clicking anywhere outside
the modal.
2023-10-05 09:28:27 -07:00
2df26f3d27
bootstrap-btn: Remove bootstrap CSS for ".btn-success" elements.
...
We used "btn-success" class only in user profile modal subscribe
widget and the CSS rules applied by bootstrap on this class were
overridden by other CSS. We also remove the btn-success class
since this is a bootstrap-specific class and we no longer
need it.
2023-10-05 09:28:27 -07:00
cfc9dccb2a
bootstrap-btn: Remove bootstrap CSS for ".btn-primary" elements.
...
We used "btn-primary" class only in integrations dev panel page
and this commit re-adds the CSS applied by this class in
integrations_dev_panel.css. We also remove the btn-primary class
since this is a bootstrap-specific class and we no longer
need it.
2023-10-05 09:28:27 -07:00
cc4a6d08e7
development: Update modal in emails page to use micromodal.
...
We now use micromodal in the modal on dev server emails page to
make it consistent with other modals in the app and this is
preparatory work for moving away from bootstrap as well.
2023-10-05 09:28:27 -07:00
8710feb5dd
billing: Update modal shown on license increase to use micromodal.
...
We now use micromodal in the license update modal on billing page
to make it consistent with other modals in the app and this is
preparatory work for moving away from bootstrap as well.
2023-10-05 09:28:27 -07:00
866b6cd632
portico: Add portico_modals.ts module.
...
This commit adds portico_modals.ts module which contains functions
for supporting modals in portico pages. The new module basically
contains code from functions in overlays.ts without the code
that is not needed currently for modals in portico pages.
2023-10-05 09:28:27 -07:00
ac8436d46c
resize: Move handler to new resize_handler module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 09:26:59 -07:00
c2c1f1ac6d
inbox: Add icon in search box to clear any text.
2023-10-05 08:57:44 -07:00
b494424ffa
inbox: Change hover / focus styles of search box.
...
This is to make search box less noticeable when focus is given / taken
away from it.
2023-10-05 08:57:44 -07:00
5142f1279a
popovers: Refactor show popovers as overlay on mobile widths.
...
This also fixes user_card_popover not being displayed as overlay
on mobile widths.
2023-10-05 08:29:12 -07:00
13d1241eed
activity: Extract new activity_ui module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 08:27:30 -07:00
69ceff4995
settings_notifications: Cut import of stream_edit.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 08:22:56 -07:00
4ec78ee2d4
compose_recipient: Move selected_recipient_id to compose_state.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 08:21:33 -07:00
75826d8409
handlebars: Move popover handlebars to a new popovers folder.
...
Organize related handlebars in a new folder together.
2023-10-05 08:19:49 -07:00
95ee178d1a
user_card_popover_content: Rename to remove `_content`.
2023-10-05 08:19:49 -07:00
a6f864a9a4
user_card_popover: Rename function name to avoid conflict.
...
This function name would have conflicted with
`render_user_card_popover_content` variable name once
we remove `_content` from it.
2023-10-05 08:19:49 -07:00
3415a6898c
user_card_popover: Rename `_title` suffix to `_avatar`.
2023-10-05 08:19:49 -07:00
78543a7f12
emoji_picker: Merge templates.
...
Merge `emoji_popover.hbs` and `emoji_popover_content.hbs`.
2023-10-05 08:19:49 -07:00
54233f0363
playground_links_popover: Rename to remove `_content`.
2023-10-05 08:19:49 -07:00
ecba66e613
compose_popovers: Rename to remove `_content`.
2023-10-05 08:19:49 -07:00
acd584c336
actions_popover: Rename template to remove `_content`.
2023-10-05 08:19:49 -07:00
4c11f49627
settings_notifications: Fix stream_settings_api namespace import name.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-04 23:57:16 -07:00
eb6ac7bd98
settings_ui: Fix type and $ prefix of status_element argument.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-04 23:51:50 -07:00
2ed1465b04
css: Display status emoji along with overflowing sender names.
...
Even if sender name overflows the available space, we should
show status emoji along with sender name by hiding the overflowing
part of sender name.
2023-10-04 16:49:39 -07:00
8d217847db
stream_edit: Move can_remove_subscribers_group_widget to settings_org.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-04 16:35:24 -07:00
278bd52b4e
stream_edit: Move get_request_data_for_stream_privacy to settings_data.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-04 16:35:24 -07:00
d17c0dabc8
stream_data: Move stream_*_policy_values to settings_config.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-04 16:35:24 -07:00
0f0fd3f07d
tests: Remove sub_store mock from recent_view test.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-04 16:35:24 -07:00
Aman Agrawal
Anders Kaseorg
Sahil Batra
Prakhar Pratyush
N-Shar-ma
evykassirer
Prakhar Pratyush
Lauryn Menard
Alex Vandiver
David Rosa
Tim Abbott