rht
32650c8fdc
zerver/management: Remove print_function.
2017-09-27 18:05:45 -07:00
rht
e239e97351
zerver/management: Remove absolute_import.
2017-09-27 10:00:39 -07:00
Greg Price
7737326cf0
mypy: Add an Optional in fix_unreads command.
2017-09-26 13:49:01 -07:00
Steve Howell
69203c1c81
fix_unreads: Remove commit() call in fix().
...
The commit() call in fix() breaks migrations and tests (unless you
mock) due to outer transactions.
We now explicitly call commit() from the management command.
2017-09-07 07:06:03 -07:00
Steve Howell
8cc8e87daf
fix_unreads: Use logging instead of print.
2017-09-07 07:06:03 -07:00
Steve Howell
a2fe4178be
Extract zerver/lib/fix_unreads.py.
...
This is a pure code move.
2017-09-07 07:06:03 -07:00
Steve Howell
4ac6bc46c7
Add MutedTopic model.
...
This commit completely switches us over to using a
dedicated model called MutedTopic to track which topics
a user has muted.
This includes the necessary migrations to create the
table and populate it from legacy data in UserProfile.
A subsequent commit will actually remove the old field
in UserProfile.
2017-09-02 09:19:51 -07:00
Steve Howell
828459a24b
Extract build_topic_mute_checker into topic_mutes.py.
...
We had two duplicate versions of this function, and one
of them was broken with respect to case insensitivity.
2017-08-29 16:53:38 -04:00
Tim Abbott
8cbdaca9f5
fix_unreads: Fix handling of muted_topics on missing streams.
...
If the stream no longer exists, we can just ignored the muted_topics
entry.
2017-08-23 18:14:11 -07:00
Tim Abbott
7918551fa9
fix_unreads: Help postgres figure out the most efficient query.
...
In theory, this shouldn't make a difference, but in practice, this
helps postgres make better use of our unread messages index.
2017-08-23 18:00:33 -07:00
Tim Abbott
75d9f66bf0
fix_unreads: Fix error handling with no recipient_ids.
...
Previously, this would send an invalid database query to postgres.
2017-08-23 17:15:33 -07:00
Steve Howell
bc61fae6d2
fix_unreads: Actually update pre-pointer unread counts.
...
This fixes an oversight in the original version. (We have only
used this in controlled experiments.)
2017-08-23 13:13:23 -07:00
Tim Abbott
669b1b8adb
mypy: Fix an annotation.
2017-08-22 17:39:24 -07:00
Steve Howell
110cfcb640
Support --all options in fix_unreads.
...
(We also changed the email metavar to accept multiple emails.)
2017-08-22 20:06:30 -04:00
Steve Howell
752bf14443
fix_unreads: Improve cursor handling.
...
Before adding the context manager, we were leaking cursors, which
was a non-issue for updating individual users, but it's easy to
fix.
2017-08-22 20:06:26 -04:00
Steve Howell
c5e083857b
fix_unreads: Mark pre-pointer messages as unread (unless muted).
2017-08-22 20:03:18 -04:00
Steve Howell
8b16c6060c
Split out fix_unreads management command.
...
Most of the code in show_unreads is for diagnosising unread
counts issues, and we may not use that often.
We're creating a dedicated fix_unreads management command with
less clutter.
2017-08-22 19:38:44 -04:00