c8f53e55db
websocket_client: Use get_system_bot.
...
This messy code is used only for our websocket Nagios tests, so using
get_system_bot makes sense.
2017-08-24 23:16:18 -07:00
e915fa058a
test_classes: Stop using get_realm_by_email_domain.
...
get_realm_by_email_domain was intended to be registration flow code
not used in other code, but it was leaked to a few places. This
removes one of the main remaining references to it outside the
registration code path.
2017-08-24 21:38:02 -07:00
95ed00bade
tests: Remove now-unused subscribe_to_stream helper.
2017-08-24 21:38:02 -07:00
69059dcac8
tests: Clean up subscribing from webhook tests.
2017-08-24 21:37:57 -07:00
5fa7c3e0b2
test_classes: Clean up API for unsubscribing.
...
The old API required test authors to unnecessarily repeat themselves.
2017-08-24 21:37:57 -07:00
eb720485c5
tests: Add and use new self.subscribe.
...
This new method cleans up the API for subscribing to something from a
test case.
2017-08-24 21:37:57 -07:00
4069b166ea
run-casper: Fix a mypy annotation error.
2017-08-24 21:02:32 -07:00
60105fe38a
registration: Remove accounts_home_with_realm_str.
...
This was the old mechanism for logging into a specific realm on a
server with more than one not using REALMS_HAVE_SUBDOMAINS.
2017-08-24 20:44:52 -07:00
0148338a05
casper: Always use REALMS_HAVE_SUBDOMAINS.
...
This is preparation for setting REALMS_HAVE_SUBDOMAINS to be
permanently True.
2017-08-24 20:44:37 -07:00
522562f68f
outgoing_webhook: Stop using get_realm_by_email_domain.
...
There was no reason to do a complicated lookup to get the realm here.
2017-08-24 20:27:00 -07:00
80458945c7
tests: Remove unnecessary use of get_realm_by_email_domain.
...
That function was primarily intended for some limited registration
code paths, not the generic usage it was getting.
2017-08-24 20:22:56 -07:00
1c9521a8d6
docs: Fix buggy relative documentation link.
2017-08-24 19:59:59 -07:00
6a2c83f051
notifications: Group messages by (recipient, sender) for PM's.
...
This fixes a issue with multiple PM's being clubbed into a single
missed message email.
Fixes #6224 .
2017-08-24 19:58:55 -07:00
0693656b89
register: Allow the empty string as a subdomain.
...
This is conditioned on the server being configured with
ROOT_DOMAIN_LANDING_PAGE=True.
2017-08-24 19:39:40 -07:00
3d4893d906
settings: Rename SUBDOMAINS_HOMEPAGE to ROOT_DOMAIN_LANDING_PAGE.
...
This new setting name is a lot more readable.
2017-08-24 19:32:16 -07:00
ab61fe5922
auth: Fix Google auth to not assume SUBDOMAINS_HOMEPAGE.
...
Previously, Google auth would redirect you back to the login page on
this code path.
2017-08-24 19:03:42 -07:00
eb781de78d
settings: Fix buggy use of JavaScript regular expressions.
...
Using weird characters when filtering options items in these various
settings pages would throw exceptions whenever they didn't form a
valid regular expression.
2017-08-24 18:32:01 -07:00
d2a4afeacf
Change message click => message long-tap event on mobile.
...
Previously on mobile, clicking on a message would make the compose
box open, but this is a relatively finnicky event whenever scrolling
so we realistically want to open the compose box on long-tap (with
a 750ms delay) to prevent false clicks and provide a closer-to-native
experience.
2017-08-24 16:52:18 -07:00
31986d1b94
github_webhook: Update "pull_request unassigned" event fixture.
...
The older fixture for this event assumed that the "assignee" key
had a value of '{}' if no one was assigned to a PR anymore.
However, that is no longer true because testing with requestbin
showed that in the latest JSON payload for this event, the key
"assignee" now has the value of 'null' (None when converted to
Python) when a user is unassigned from a PR. The current code
didn't handle this correctly. This commit makes sure it does!
Its unclear as to whether the old fixture was simply wrong or
whether GitHub changed its payloads in any way.
2017-08-24 16:48:00 -07:00
8b0c0c33b5
login: Fix logging for login/register actions.
...
Previously, Zulip's server logs would not show which user or client
was involved in login or user registration actions, which made
debugging more annoying than it needed to be.
2017-08-24 16:29:27 -07:00
a570a57fd5
login: Log which user was authenticated in mobile flows.
2017-08-24 16:29:27 -07:00
5206dad373
decorator: Fix is_browser_view handling of e.g. mobile apps.
...
We may end up with some endpoints that could be the browser or the
mobile apps, and we want the right default to happen here.
2017-08-24 16:26:57 -07:00
7ffc107061
decorator: Rename is_json_view to is_browser_view.
...
This improves clarity, now that we're planning to start logging in the
login/registration pages, which aren't browser views.
2017-08-24 16:25:08 -07:00
a3bc041894
send_password_reset_email: Simplify argument parsing.
2017-08-24 14:41:45 -07:00
2b076ef822
management: Move all_users option to ZulipBaseCommand.
2017-08-24 14:35:18 -07:00
9d043e7fb0
management: Use self.style attribute for colored output.
2017-08-24 14:29:32 -07:00
f4df74d968
management: Use add_user_list_args in send_password_reset_email.
2017-08-24 14:29:32 -07:00
65a20b3b99
management: Use add_user_list_args in remove_users_from_stream.
2017-08-24 14:29:32 -07:00
0949924ea3
management: Use add_user_list_args in add_users_to_streams.
2017-08-24 14:29:32 -07:00
a82b3f1ea5
management: Use add_user_list_args in turn_off_digests.
2017-08-24 14:29:32 -07:00
f9a6dffe1a
management: Add add_user_list_args function to ZulipBaseCommand.
2017-08-24 14:29:32 -07:00
87c4961597
Add zerver/lib/topic_mutes.py
...
This is mostly pure code extraction.
It also removes some dead code in update_muted_topic, where
were updating muted_topics spuriously before calling
do_update_muted_topic.
2017-08-24 14:20:35 -07:00
624f1bb151
Restyle checkboxes to be less visually abrasive.
...
This restyles the checkboxes to be more subtle in their rest and
unchecked state so they don't create too much visual noise on the
page.
2017-08-24 14:19:49 -07:00
3e2e24f4cd
Lighten subscriptions settings grey boxes.
...
This increases the luminosity of the subscriptions settings boxes
from 93% to 97%.
2017-08-24 14:19:49 -07:00
cac4aeaa5f
Clean up "Stream accessibility" section.
...
This cleans up the "Stream accessibility" section by putting the
radio boxes in a container along with fixing the margins around
various things.
2017-08-24 14:19:49 -07:00
74f48ed5ba
Make stream creation titles more consistent in size.
...
This brings down the number of stream creation title sizes from
4 (!!) to 1.
2017-08-24 14:19:47 -07:00
b73f5c9770
Fix responsive issue with stream filter search.
...
This fixes the search input collapsing to a second line in between
1024px and 1033px width views.
2017-08-24 13:59:40 -07:00
9e3ba52c66
portico: Fix upper-left link for non-help-center pages.
2017-08-24 13:44:55 -07:00
44636051e4
Make /help/ sidebar more discoverable on mobile/narrow.
...
This makes the /help/ sidebar more discoverable at windows less
than 1000px in width because it makes it stick out a bit when it
is closed with the hamburger menu at the top.
Fixes : #6038 .
2017-08-24 13:38:22 -07:00
321074856e
/integrations/: Focus search bar on page load.
...
This focuses the search bar on initial page load.
2017-08-24 11:38:13 -07:00
380dd38fc7
assets: Add email illustration SVGs to assets folder.
2017-08-24 11:37:24 -07:00
3ceba5ef1e
test-backend: Require coverage on most webhook integrations.
2017-08-24 11:33:14 -07:00
18a080cd6c
Don't handle json payload key errors inside webhooks.
...
Fixes first part of #6213 .
2017-08-24 11:33:14 -07:00
ecb428100f
features: Update hero text.
2017-08-24 09:58:47 -07:00
93fb6a1688
models: Add support for using the root subdomain.
...
Previously, realm.uri and realm.host didn't support using a subdomain
of the empty string (""), aka using the root domain.
Also, since we're already accessing self.subdomain, we don't need to
check REALMS_HAVE_SUBDOMAINS again.
2017-08-23 23:19:19 -07:00
f46f3871b4
integrations: Add support for using root subdomain.
...
This fixes up the URL/link construction to make the root subdomain work.
2017-08-23 23:18:36 -07:00
d44ac5c320
auth: Clean up google_oauth2_test arguments.
2017-08-23 20:50:03 -07:00
30e1aada42
docs: Stop documenting how to create multiple organizations.
...
This documentation wasn't super helpful, since users will want
REALMS_HAVE_SUBDOMAINS.
2017-08-23 20:07:17 -07:00
d3e3c704d4
do_create_realm: Remove unnecessary second return value.
...
Unlike creating a stream, there's really no reason one would want to
call the function to create a realm while uncertain whether that realm
already existed.
2017-08-23 20:07:17 -07:00
8a65fdce49
subdomains: Fix over-aggressive redirect to find_my_team.
...
If the root domain is a valid subdomain, we don't want to redirect
everyone away from it.
2017-08-23 20:07:17 -07:00
Tim Abbott
Aditya Bansal
Brock Whittaker
Eeshan Garg
Vishnu Ks
Steve Howell
Vaida Plankyte
Robert Hönig
Rishi Gupta