Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
44,746 Commits 28 Branches 142 Tags 698 MiB
Commit Graph

498 Commits

Author SHA1 Message Date
Anders Kaseorg 0ef5cb4813 eslint: Enable @typescript-eslint/recommended-requiring-type-checking. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-09-22 18:06:06 -07:00
Priyank Patel c862c673af ts: Convert blueslip module to TypeScript. 
We turn off the eslint no-use-before-define for TypeScript files
because it does not work correctly for types. There is already
a typescript-eslint version of it that is enabled for TS.

We also update the error handler on window to use instanceof check
for ErrorEvent instead of checking the error property.
 2021-06-22 09:09:36 -07:00
Anders Kaseorg a9f6764d8c eslint: Add eslint-plugin-formatjs. 
This guards against various mistakes, such as setting defaultMessage
to a computed expression that can’t be extracted.

https://formatjs.io/docs/tooling/linter/

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-06-13 22:32:40 -07:00
Anders Kaseorg ad7466a2bf dependencies: Upgrade JavaScript dependencies. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-06-08 10:15:52 -07:00
Priyank Patel 7999d52400 ts: Convert keydown_util to TypeScript. 
We also add JQuery to globals which is a global type.
 2021-05-27 23:33:21 -07:00
Priyank Patel 6ab66ea17a keydown_util: Use Event.key instead of deprecated properties. 
The Event.which and Event.keyCode are deprecated as pointed out by
TypeScript intellisense based on the jQuery types. We use Event.key
instead which behaves similarly to Event.which & Event.keyCode for
our use case.

The only difference in functionality by this change is that the vim
keys won't work when Caps Lock is on. This is because, in this case,
the key property will be "J" instead of 'j'. We can fix this by
adding a mapping for this, however, I think we don't want to handle
this case so I left this change out. Tested by trying out the
everywhere keydown_util is used.

Finally, we also turn off the new-cap rule for tests since I think
it fine to only enforce it on real code and exempting test code is
fine.
 2021-05-27 23:33:17 -07:00
Anders Kaseorg 5ca763fc24 eslint: Fix unicorn/prefer-switch. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-05-10 19:26:41 -07:00
Anders Kaseorg a284299b85 eslint: Fix unicorn/prefer-array-flat. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-05-10 18:07:13 -07:00
Anders Kaseorg 42abc1b635 dependencies: Upgrade JavaScript dependencies. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-05-10 18:07:13 -07:00
Anders Kaseorg bf056c8990 js: Extract password_quality module; remove zxcvbn from globals. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-24 13:08:52 -07:00
Anders Kaseorg 6dc783e562 eslint: Enable sort-imports for member sorting. 
This sorts the members imported within each individual declaration; we
use import/order for sorting multiple declarations.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-03 15:54:14 -07:00
Anders Kaseorg d43ac7357a js: Move current_msg_list, home_msg_list to ES6 module message_lists. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-29 18:23:47 -07:00
Anders Kaseorg 7f89cb9535 eslint: Enable spaced-comment rule. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-26 16:32:25 -07:00
Anders Kaseorg a05899f1b5 js: Convert static/js/csrf.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-26 10:17:56 -07:00
Anders Kaseorg 38ffd47b90 js: Convert static/js/page_params.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-26 10:17:56 -07:00
Anders Kaseorg bb1b2048bd js: Convert static/js/i18n.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-26 10:17:56 -07:00
Anders Kaseorg 72085c7bd8 eslint: Remove unused location global for node_tests. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-26 10:17:56 -07:00
Anders Kaseorg 9553f11387 eslint: Forbid CommonJS variables in ES6 modules. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-23 01:42:43 -07:00
Anders Kaseorg 0d218a4b76 eslint: Enable @typescript-eslint/consistent-type-imports. 
TypeScript type-only imports will probably become important eventually
for reducing our circular import problem.

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-18 17:26:19 -07:00
Anders Kaseorg 3ef6f6e2e2 js: Convert static/js/blueslip.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-17 08:47:15 -04:00
Anders Kaseorg ea9ca6b7d0 js: Use jQuery as a module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-12 10:08:25 -08:00
Anders Kaseorg 31e865d9ed eslint: Re-enable no-undef for TypeScript. 
@typescript-eslint/recommended disables no-undef on the theory that
TypeScript knows which globals are in scope.  However, some TypeScript
definitions include declarations for globals that may or may not
actually be available depending on the environment.  So we will need
to prohibit some globals that TypeScript knows about, and enforce that
they are properly imported.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-11 21:17:19 -08:00
Anders Kaseorg 9613c66560 dependencies: Upgrade JavaScript dependencies. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-03 21:46:42 -08:00
Anders Kaseorg a58e832884 eslint: Remove unneeded globals. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg 099e8fb00e js: Convert static/js/settings_profile_fields.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg 7ec8b8980f js: Convert static/js/dropdown_list_widget.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg 9e613b1487 js: Convert static/js/message_events.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg d8c793f791 js: Convert static/js/composebox_typeahead.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg 5cc1f8d289 js: Convert static/js/ui.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg 8dbaf2d680 js: Convert static/js/subs.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg 0e90f3be6d js: Convert static/js/compose_actions.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg e74598da17 js: Convert static/js/narrow.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg 7a67c06581 js: Convert static/js/message_list.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg 68872f44f6 js: Convert static/js/widgetize.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg 3e8ddc229b js: Convert static/js/stream_list.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg 727208b84c js: Convert static/js/unread.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg 9997e13032 js: Convert static/js/unread_ops.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg 7ec3fc38fa js: Convert static/js/input_pill.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg 79ac5c25b5 zulip_test: Re-export internal functions used by Puppeteer tests. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Anders Kaseorg d8ad63126d js: Convert static/js/billing/helpers.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-28 14:23:00 -08:00
Anders Kaseorg 2a49ce1b6c js: Convert static/js/search_pill_widget.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-28 14:23:00 -08:00
Anders Kaseorg 1a8422b152 js: Convert static/js/recent_topics.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-28 14:23:00 -08:00
Anders Kaseorg 934d4e4e10 js: Convert static/js/panels.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-28 14:23:00 -08:00
Anders Kaseorg dc95f06b62 js: Convert static/js/compose_ui.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-28 14:23:00 -08:00
Anders Kaseorg 8191915e57 js: Convert static/js/emoji_picker.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-28 14:23:00 -08:00
Anders Kaseorg b9e1d320e8 js: Convert static/js/typing_events.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-28 14:23:00 -08:00
Anders Kaseorg e382389797 js: Convert static/js/reactions.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-28 14:23:00 -08:00
Anders Kaseorg a0caabe6c7 js: Convert static/js/bot_data.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-28 14:23:00 -08:00
Anders Kaseorg 5438a04b84 js: Convert static/js/message_view_header.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-28 14:23:00 -08:00
Anders Kaseorg d36c6f23f6 js: Convert static/js/admin.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-28 14:23:00 -08:00