kb0rg
e672ec62c1
Add test for encode_email_address with empty Gateway.
2017-05-23 21:38:07 -07:00
kb0rg
d625cca2f8
minor: Rename test class -> TestEmptyGatewaySetting.
2017-05-23 21:38:07 -07:00
vaibhav
f94c321567
Outgoing Webhook System: Add support for personal message triggers.
2017-05-23 21:35:09 -07:00
Lech Kaiel
6b49e667ef
tests: Replaced @zulip.com references with self.example_ functions.
...
This cleans up the excessive use of @zulip.com emails in the tests.
2017-05-23 20:59:50 -07:00
ron-s
e5d4e0f0eb
Test: Add test_notify_of_new_user_internally.
2017-05-23 20:27:37 -07:00
Steve Howell
036f66aba3
Add test_get_avatar_url_with_user_profile_lookup test.
2017-05-23 18:35:45 -07:00
Vishnu Ks
b5c4a95ef1
test_bots.py: Use example_email instead of using the emails directly.
2017-05-23 18:31:43 -07:00
Vishnu Ks
dbdc0220b9
test_presence.py: Remove unused get_user_profile_by_email import.
2017-05-23 18:31:43 -07:00
Vishnu Ks
2b36df6b8f
test_sessions.py: Use helpers instead of get_user_profile_by_email.
2017-05-23 15:27:21 -07:00
Vishnu Ks
dafa89d52b
test_outgoing_webhook_system.py: Replace get_user_profile_by_email with example_user.
2017-05-23 15:27:21 -07:00
Vishnu Ks
075b0cae70
test_bugdown.py: Remove unused get_user_profile_by_email import.
2017-05-23 15:27:21 -07:00
Vishnu Ks
7950f5242a
test_unread.py: Replace get_user_profile_by_email with get_user.
2017-05-23 15:27:21 -07:00
Tim Abbott
a833fa39b8
test_messages: Fix tests failing due to error message change.
2017-05-23 15:27:21 -07:00
Matt Long
19363b2b77
notification_settings: Refactor notification preference settings.
...
Previously, all notification preference setting had a dedicated test
and setter. Now, all are handled through a modular function using the
property_types framework.
2017-05-23 14:47:46 -07:00
Rick Chern
70d68f7e71
Refactoring: Replace get_user_profile_by_email() in lib/upload.py
2017-05-23 12:37:49 -07:00
Steve Howell
484f32646b
Rename file to test_new_users.py.
...
The old file name of test_send_login_emails was
overly specific, and we want to add some tests
related to other parts of the signup process.
2017-05-23 12:34:44 -07:00
vaibhav
287aaa21b6
Outgoing Webhook System: Add outgoing webhook queue worker.
2017-05-23 08:21:08 -07:00
vaibhav
53a8b2ac87
Outgoing Webhook System: Add DoRestCall and helper functions
2017-05-23 08:19:16 -07:00
Vishnu Ks
820dc9dd9a
Replace espuser@mit.edu with mit_user('espuser').
2017-05-22 19:02:42 -07:00
Vishnu Ks
99fc0e9e62
Replace starnine@mit.edu with mit_user('starnine').
2017-05-22 19:02:42 -07:00
Vishnu Ks
c680c5f1e8
Replace sipbtest@mit.edu with mit_user('sipbtest').
2017-05-22 19:02:42 -07:00
Vishnu Ks
05951074be
Make MITNameTest use ZulipTestCase instead of TestCase.
2017-05-22 19:02:42 -07:00
Lukasz Prasol
5eaccc550a
rate_limit: Make retry-after data machine-readable.
...
Fixes #4831 .
2017-05-22 17:35:12 -07:00
umkay
510b7a0489
mypy: Add ignore type for dynamically added field on LogRecord.
...
mypy will error because of the attribute "request" on the LogRecord
object. Since this field is added in our tests dynamically and is not
on the base object, for now we will ignore the type.
2017-05-22 14:38:39 -07:00
Tim Abbott
040067b2a2
invite: Remove obsolete bulk_invite_users endpoint.
2017-05-17 17:30:15 -07:00
Aditya Bansal
57bc847874
pep8: Add compliance with rule E261 to test_urls.py.
2017-05-18 03:00:32 +05:30
Umair Khan
38ecc35cd9
push_notifications: Catch IOError while pushing to GCM.
2017-05-17 12:14:32 -07:00
Umair Khan
7e8f4ca4e8
push_notifications: Include GCM in end-to-end test.
2017-05-17 08:09:19 -07:00
Tim Abbott
cab908b664
api: Move notifications_stream into the register_ret API.
...
While we're at it, we at least fix the API to use a stream ID, not a
stream name, to refer to the notifications stream.
2017-05-16 18:57:14 -07:00
Tim Abbott
9d63a5ab3a
push_notification: Delete obsolete DBX_IOS_APP_ID code.
...
I'm not sure that this was ever actually used, but it's definitely
just clutter for Zulip today.
2017-05-16 12:26:55 -07:00
Umair Khan
fa5c66c439
push_notifications: Add num_push_devices_for_user tests.
2017-05-16 12:26:55 -07:00
Umair Khan
88f5d29e19
push_notifications: Add send_to_push_bouncer tests.
2017-05-16 12:26:55 -07:00
Umair Khan
af27ad607a
push_notifications: Add handle_push_notification tests.
2017-05-16 12:26:55 -07:00
Umair Khan
8a6498f55d
push_notifications: Create BouncerTestCase.
...
Adds bounce_request method to simulate a bounce.
2017-05-16 12:26:55 -07:00
Umair Khan
5907877038
push_notifications: Add test for send_notifications_to_bouncer.
2017-05-16 12:26:55 -07:00
Umair Khan
fab4249893
push_notifications: Add get_gcm_payload tests.
2017-05-16 12:26:55 -07:00
Umair Khan
136a950041
push_notifications: Add test for APNs payload.
2017-05-16 12:26:55 -07:00
Umair Khan
47d0f7d996
push_notifications: Add tests for get_alert_from_message.
2017-05-16 12:26:55 -07:00
Umair Khan
df0d29aaff
push_notifications: Add response_listener tests.
2017-05-16 12:26:55 -07:00
Steve Howell
e6cc0ffcdd
Eliminate PMs to non-subscribers when creating streams.
...
This should make stream creation relatively fast again, since we
will no longer send O(N) PMs out to tell folks the stream was
created.
2017-05-16 10:43:27 -07:00
Steve Howell
bbd8c1c49b
Do not send PMs to subscribers when creating streams.
...
When we create a stream, we usually send a welcome message on the
stream itself as well as an announcement on the announcement stream,
but we no longer PM the individual users. Hopefully this will be
more pleasant for users (less spammy), and it also will make creating a
stream a lot faster.
We still send notifications when we add subscribers to an existing
stream.
2017-05-16 08:58:17 -07:00
Steve Howell
e2732dabf3
Send welcome messages as part of /create_realm flow.
...
We now pre-populate the streams in DEFAULT_NEW_REALM_STREAMS
(social/general/zulip, unless somebody changes settings.py) with
welcome messages. This makes the streams appear to be active
right away, and it also gives the Zulip realm less of a
blank-slate feeling when you create it.
This change only affects the normal web-based create-realm flow.
It doesn't impact the management commands for creating realms
or setting default streams.
2017-05-15 20:38:08 -07:00
Tim Abbott
97abaae9af
home: Remove now-unnecessary page_params_core_fields duplication.
...
Also, we update the documentation to make the overall system a bit
clearer.
Fixes #4628 .
2017-05-13 22:58:18 -07:00
Tim Abbott
acb3c1e7ff
test_templates: Fix errors from compare.html template.
2017-05-13 14:57:06 -07:00
Tim Abbott
51978d0f89
tests: Fix failing login tests.
...
Apparently I missed these when updating
4d2bb0dec8
.
2017-05-13 13:05:15 -07:00
Tim Abbott
4d2bb0dec8
templates: Clean up visuals for account-not-found SSO flow.
...
Also, clarify that the account that isn't found is your Zulip account,
not a GitHub/Google Oauth account.
2017-05-13 12:46:05 -07:00
Tim Abbott
72abd4f12d
mentions: Fix subject line and sender for missed-message mentions.
...
This fixes 2 issues:
* The term "@-mentioned" is simplified to "mentioned".
* We would incorrectly list other people who sent context messages as
among the people who mentioned you.
2017-05-12 13:50:25 -07:00
James Rowan
0facaa0797
Changes sender and subject lines for missed message emails.
...
Now, in the event of messages between two other members of a huddle,
the missed message emails are threaded in "Group PMs with name1 and
name2" and not in separate threads by sender.
Also, now the order of recipients in get_display_recipient consistent
with the order of names that appears in the list of personal messages
on the left sidebar.
Fixes most of #4553 .
2017-05-12 13:29:43 -07:00
Tim Abbott
13a37f74a1
users: Ban names shorter than 3 characters.
...
The empty string is not a reasonable name.
2017-05-11 19:21:51 -07:00
Cory Lynch
68e5898a07
emoji.py: Add restriction that realm emoji must be lowercase.
...
Raises error if emoji name has an uppercase letter in it.
2017-05-11 19:10:21 -07:00
Tim Abbott
223624be25
settings: Add support for longer, markdown-powered realm descriptions.
...
This makes it possible to create much prettier login pages.
Further work on styling may be necessary.
2017-05-11 13:59:46 -07:00
Umair Khan
dc2a9a4c5b
github: Add sign up button on registration page.
2017-05-10 17:49:08 -07:00
Umair Khan
d56db0a3b4
auth.py: Add confirmation handlers for signup.
...
These handlers will kick into action when is_signup is False. In case
the account exists, the user will be logged in, otherwise, user will
be asked if they want to proceed to registration.
2017-05-10 17:20:34 -07:00
Tim Abbott
e8eaec0a18
mypy: Fix various errors caught by removing cache_with_key.
2017-05-10 14:37:20 -07:00
Tim Abbott
a0a50d410c
test_docs: Add tests to ensure all integrations present.
2017-05-10 11:30:32 -07:00
Tim Abbott
232592cc9f
test_sessions: Extends tests to reach 100% coverage of sessions.py.
...
Fixes #3980 .
2017-05-10 10:12:21 -07:00
andrewallen00
53f1f75fcb
Add tests for zerver/lib/sessions.py.
2017-05-10 10:12:14 -07:00
Tim Abbott
9f7236eec1
message: Remove unused old gravatar_hash field from message dicts.
...
This was deprecated and replaced some 4 years ago.
2017-05-09 22:33:27 -07:00
Tim Abbott
bd3e338c35
templates: Fix URL coverage for new files.
2017-05-09 18:42:24 -07:00
Tim Abbott
fc24a56fc5
test_docs: Fix expected text in /hello page.
2017-05-09 17:23:38 -07:00
Tim Abbott
df6dba9673
test_home: Fix expected text in /hello page.
2017-05-09 16:59:33 -07:00
Tim Abbott
2d97db3518
streams: Add endpoint for modifying properties of a single stream.
...
This is likely to be the more common endpoint for API clients like the
mobile apps to interact with when modifying streams.
2017-05-09 13:42:34 -07:00
kunall17
e087bc24f8
streams: Migrate stream property changes to new REST endpoint.
...
This is one of the last major endpoints that were still done in the
pre-REST style.
While we're at it, we change the endpoint to expect a stream ID, not a
stream name.
2017-05-09 13:39:23 -07:00
Rohitt Vashishtha
0414ac6df5
bugdown: Convert GitHub image-preview urls to image urls.
...
This makes inline image previews work for links to image files' pages
on GitHub.
Fixes #4658 .
2017-05-09 11:22:37 -07:00
Steve Howell
b609911656
Remove unused get_user_profile_by_email() imports.
2017-05-08 11:57:38 -07:00
Steve Howell
3b2a3601c1
tests: Add ZulipTestCase.notification_bot().
2017-05-08 11:57:38 -07:00
Steve Howell
3a031f6814
test: Use example_user() in more places.
...
This commit replaces calls to get_user_profile_by_email() with
calls to self.example_user() by introducing a local variable.
2017-05-08 11:57:38 -07:00
Steve Howell
7f9057ba99
tests: Use example_user() in more places.
2017-05-08 11:57:38 -07:00
Steve Howell
6bc8424c71
Use self.example_user() in more places.
...
This fixes most cases where we were assigning a user to
the var email and then calling get_user_profile_by_email with
that var.
(This was fixed mostly with a script.)
2017-05-08 11:57:38 -07:00
Steve Howell
942db9b6c5
tests: Added ZulipTestCase.example_user() function.
...
The example_user() function is specifically designed for
AARON, hamlet, cordelia, and friends, and it allows a concise
way of using their built-in user profiles. Eventually, the
widespread use of example_user() should help us with refactorings
such as moving the tests users out of the "zulip.com" realm
and deprecating get_user_profile_by_email.
2017-05-08 11:57:38 -07:00
Aditya Bansal
b48f07ebc0
pep8: Add compliance with rule E261 to test_users.py.
2017-05-07 23:21:50 -07:00
Aditya Bansal
feb332920c
pep8: Add compliance with rule E261 to test_typing.py.
2017-05-07 23:21:50 -07:00
Aditya Bansal
191fead5a3
pep8: Add compliance with rule E261 to test_type_debug.py.
2017-05-07 23:21:50 -07:00
Aditya Bansal
fcb1e4d4f1
pep8: Add compliance with rule E261 to test_report.py.
2017-05-07 23:21:50 -07:00
Aditya Bansal
2b1c6f7749
pep8: Add compliance with rule E261 to test_queue_worker.py.
2017-05-07 23:21:50 -07:00
Aditya Bansal
fd4ac33073
pep8: Add compliance with rule E261 to test_push_notifications.py.
2017-05-07 23:21:50 -07:00
Aditya Bansal
0478a9d7f3
pep8: Add compliance with rule E261 to test_export.py.
2017-05-07 23:21:50 -07:00
Aditya Bansal
7f5f4a511a
pep8: Add compliance with rule E261 to test_decorators.py.
2017-05-07 23:21:50 -07:00
Aditya Bansal
ce2790aae2
pep8: Add compliance with rule E261 to test_bots.py.
2017-05-07 23:21:50 -07:00
Umair Khan
b8afd249e4
testing: Make test_hit_ratelimits deterministic.
...
On slower systems or virtual environments, when you are running
tests in parallel mode, sometimes the time taken to send messages
in this test exceeds 1 second which resets the limit.
2017-05-06 17:28:16 +05:00
Rishi Gupta
962b56efbd
settings: Change example NOREPLY_EMAIL_ADDRESS to have a display name.
...
We used to use constructions like
from_email = "Zulip <%s>" % (settings.NOREPLY_EMAIL_ADDRESS,)
but no longer do. All references to settings.NOREPLY_EMAIL_ADDRESS in the
codebase now do not append a display name.
2017-05-05 14:38:25 -07:00
Rishi Gupta
8321bd3f92
notifications: Refactor missed message queue to use send_email.
...
This commit also changes the sender from "Zulip <NOREPLY_EMAIL_ADDRESS>" to
NOREPLY_EMAIL_ADDRESS when it is not set explicitly.
2017-05-05 14:38:25 -07:00
Rishi Gupta
6a8ed81439
send_email: Remove tags argument from send_future_email.
...
The tags argument was only being used by the Mandrill pathway, which is no
longer around.
2017-05-05 14:38:25 -07:00
Rishi Gupta
6b9f25a58a
Remove duplicated code between send_future_email and send_email pathway.
...
Note that this change restricts the context for any template that uses
send_future_email to be jsonable.
2017-05-05 14:38:25 -07:00
Rishi Gupta
72ee5e5159
email: Make context for invitation_reminder template jsonable.
...
We are about to change send_future_email in a way that will require all
callers to use jsonable context.
2017-05-05 14:38:25 -07:00
Rishi Gupta
68c172192b
email.py: Change recipients argument of send_future_email to to_email.
2017-05-05 14:38:25 -07:00
Rishi Gupta
0d4c1b0467
notifications: Move send_future_email to zerver/lib/send_email.py.
2017-05-05 14:38:25 -07:00
Rishi Gupta
d70e09b41d
notifications: Change sender arg of send_future_email to from_email.
...
This commit is a step towards the goal of replacing most of the
send_future_email pathway with a call to send_email.
Note that this commit changes the default value of sender from "Zulip
<NOREPLY_EMAIL_ADDRESS>" to "NOREPLY_EMAIL_ADDRESS". NOREPLY_EMAIL_ADDRESS
will soon be changed to have the Zulip in front.
2017-05-05 14:38:25 -07:00
Rishi Gupta
7741e099fc
notifications.py: Merge send_local_email_template_with_delay into callers.
...
Note that the correctness of this commit relies on the fact that
send_future_email also sets the sender to settings.NOREPLY_EMAIL_ADDRESS by
default (in the body of the function).
2017-05-05 14:20:32 -07:00
Rishi Gupta
a413b0dbad
notifications: Change send_future_email to take a template_prefix.
...
Also reorders the arguments a bit to better match
zerver.lib.send_email.send_email.
2017-05-05 14:20:32 -07:00
Rishi Gupta
cf38fd156b
digest.py: Merge send_digest_email into its callers.
...
Most of the functionality of send_digest_email is being standardized in
zerver.lib.notifications.send_future_email.
2017-05-05 14:20:32 -07:00
Rishi Gupta
55a7aa4f9d
test_signup: Add dnslookup patch for mirror_dummy_user registration test.
...
Fixes regression introduced in 326f9a85
. The test indirectly makes a call to
email_is_not_mit_mailing_list, which then calls
DNS.dnslookup("%s.pobox.ns.athena.mit.edu" % username, DNS.Type.TXT).
2017-05-05 14:20:32 -07:00
Rohitt Vashishtha
a2c1e10986
bugdown: Add domain-name to relative image-url in open graph data.
...
fixes #4608 .
2017-05-04 16:54:10 -07:00
hackerkid
af612a7e1d
Extend test_user_default_language to include timezone test.
...
This renames the function to test_user_default_language_and_timezone.
2017-05-04 16:37:00 -07:00
Rishi Gupta
26ac344b19
email: Move and rename invitation_reminder_email templates.
2017-05-03 23:26:14 -07:00
Rishi Gupta
975d5bd8c0
email: Move and rename notify_change_in_email templates.
2017-05-03 20:54:40 -07:00
Rishi Gupta
4e779c3e6f
email: Move and rename mituser_invite_email templates.
2017-05-03 20:54:40 -07:00
Rishi Gupta
aa21012783
email: Move and rename mituser_confirmation_email templates.
2017-05-03 20:54:40 -07:00
Rishi Gupta
235abe0b72
email: Move and rename emailchangestatus_confirmation_email templates.
2017-05-03 20:54:40 -07:00
Rishi Gupta
0a32d9efa3
email: Fix filenames of notify_change_in_email templates.
2017-05-03 20:54:40 -07:00