Tim Abbott
594451707d
check_capped_string: Clean up corner case.
...
We were rejecting strings of length equal to the max.
While we're at it, fix the unnecessary period in the error message,
which doesn't align with similar validators.
2018-05-03 14:30:03 -07:00
Angelika Serwa
f4f64243dd
custom_profile_fields: Support changing the sort order of the fields.
...
Tweaked by tabbott for variable naming and the URL.
Closes #8879 .
2018-04-30 18:17:41 -07:00
Tim Abbott
de30474ddd
test_custom_profile_data: Don't do a database query on import.
...
This is a general code cleanlyness improvement.
While we're at it, we combine together two test classes that didn't
have a particularly good reason for existing.
2018-04-30 10:57:23 -07:00
Yashashvi Dave
0a9fbe2ce6
zerver/tests/test_custom_profile_data.py: Refactor tests.
...
Refactor tests to include generic function for invalid
assertion and remove repetitive assertion code.
2018-04-30 10:53:23 -07:00
Yashashvi Dave
a97a00a4c6
custom fields: Replace field id with field name in error message.
2018-04-30 10:53:23 -07:00
Yashashvi Dave
0d7d94d0db
custom fields: Add support for custom URL field type.
2018-04-30 10:53:23 -07:00
Yashashvi Dave
4033f210af
custom fields: Add support for custom date field type.
2018-04-30 23:04:25 +05:30
Yashashvi Dave
94d787aa2e
zerver/test/test_custom_profile_data.py: Remove hard-coded field no's.
2018-04-30 23:04:25 +05:30
Tim Abbott
976e61d687
validators: Improve error messages for check_capped_string.
2018-04-30 10:07:06 -07:00
Umair Khan
cf2f6b38dd
profile: Add choice field.
...
Fixes part of #8878
2018-04-26 00:35:51 -07:00
Umair Khan
0420b89468
profile: Add hint attribute to custom profile fields.
...
This is the model for #8876 .
2018-04-19 11:32:35 -07:00
Umair Khan
1d4b74482c
check_short_string: Change max_length to 50.
2018-04-02 09:51:09 -07:00
Umair Khan
c30a282dd9
profile: Remove integer and float fields.
2018-04-02 09:46:21 -07:00
YJDave
6ac687790c
populate_db: Remove the `test_suite` check for custom profile fields.
...
To ensure that we have some basic data for custom profile settings,
in the `populate_db` data set, remove `options['test_suite']` check
for adding intial custom profile data.
2018-03-21 16:05:31 -07:00
Tim Abbott
e2a6541133
i18n: Fix use of 'realm administrator' in translated strings.
...
These are user-facing and thus should refer to being an "organization
administrator".
2018-03-07 17:15:29 -08:00
rht
4f5b1c0a5a
zerver/tests: Use python 3 syntax for typing in most files.
2017-11-16 21:52:01 -08:00
rht
1e87a4b68c
zerver/tests: Remove absolute_import.
2017-09-27 10:00:39 -07:00
Yago González
2f4091b38d
api: Fix caps in JSON validation error message.
2017-06-27 08:33:56 -04:00
Andrew Archer
6c3f89af1c
tests: Remove get_user_profile_by_email from numerous tests.
2017-05-24 15:19:20 -07:00
Tim Abbott
e8eaec0a18
mypy: Fix various errors caught by removing cache_with_key.
2017-05-10 14:37:20 -07:00
Steve Howell
942db9b6c5
tests: Added ZulipTestCase.example_user() function.
...
The example_user() function is specifically designed for
AARON, hamlet, cordelia, and friends, and it allows a concise
way of using their built-in user profiles. Eventually, the
widespread use of example_user() should help us with refactorings
such as moving the tests users out of the "zulip.com" realm
and deprecating get_user_profile_by_email.
2017-05-08 11:57:38 -07:00
Umair Khan
8f5dfffe39
testing: Fix test_update_invalid_value.
...
This test was using hardcoded field id which made it order dependent.
2017-04-18 21:46:14 -07:00
Umair Khan
cf3b6c6ca9
profile: Support custom profile data.
...
Implements backend for #1760 .
2017-04-18 15:20:59 -07:00