Commit Graph

28422 Commits

Author SHA1 Message Date
Shubham Padia 6bfa29b8e6 notifications: Fix soft-deactivated users don't get push notifications.
Fixes the urgent part of #10397.

It was discovered that soft-deactivated users don't get mobile push
notifications for messages on private streams that they have configured
to send push notifications.

Reason: `handle_push_notification` calls `access_message`, and that
logic assumes that a user who is a recipient of a message has an
associated UserMessage row. Those UserMessage rows are created
lazily for soft-deactivated users, so they might not exist (yet)
until the user comes back.

Solution: Ensure that userMessage row is created for
stream_push_user_ids and stream_email_user_ids in create_user_messages.
2018-09-21 12:06:18 -07:00
Tim Abbott d152b84ccc trello: Clarify more what's going on with Trello's API.
I think this makes it a lot more clear what is happening here.
2018-09-21 11:24:13 -07:00
Eeshan Garg 0012e76123 webhooks/trello/doc: Require users to download Trello script.
We now have a standalone zulip_trello.py script that can be run
on Python2 and Python3 without having to install the `zulip`
package.
2018-09-21 11:12:13 -07:00
Adam Birds bd6a5ed7af integrations: Add Ansible Tower Webhook. 2018-09-21 11:05:36 -07:00
Luis Silva 5cc0fb5c40 auth: Add example using django LDAPSearchUnion function.
This makes it clear how to do a union search, without having to look
anything up.
2018-09-21 11:04:40 -07:00
Akash Nimare 0a7b487617 hotkey: Update test for hotkey deprecation.
This commit adds a test for hotkey deprecation since
we need to test the 'CMD' hotkey on macOS.
2018-09-21 10:59:55 -07:00
Akash Nimare dbb2d28ad6 hotkey: Update deprecation notice for '*' hotkey.
This PR updates the shortcut of the deprecation notice
for '*' hotkey. On macOS, it should be 'Cmd + s' instead
of 'Ctrl'.
2018-09-21 10:59:55 -07:00
Tim Abbott a0451b692f import: Move zerver_client import before realm import.
This table is independent of the realm/stream table dance, and moving
it here helps makes the flow read more clearly.
2018-09-21 10:58:24 -07:00
Rishi Gupta b470cef864 import: Set Realm.plan_type to SELF_HOSTED on import.
Tweaked by tabbott to avoid an unnecessary .save().
2018-09-21 10:57:22 -07:00
Robert Spier f4c82a1153 emails: Add detection for ChromeOS User-Agents. 2018-09-21 10:41:05 -07:00
Tim Abbott 75376a3fc5 email_mirror: Limit message length using defined constants.
Previously, we had the somewhat arbitrary limit of 2K characters
(which some users complained about), as well as the constant 60 for
the topic.
2018-09-21 10:39:57 -07:00
Rishi Gupta 89fccb8c4e user docs: Fix broken link to enable-enter-to-send.
Fixes regression from 976b560.
2018-09-20 23:29:31 -07:00
Tim Abbott feee76eb23 export: Fix exporting files with S3 upload backend.
At some point as part of the process of supporting renumbering data,
we changed the structure of our file uploads to expect `path` to match
`s3_path`, with both having the relative path within the overall
hierarchy (including the realm ID).  This change updates the more
rarely-used S3 export code path to use that model, fixing a crash when
messages reference an Attachment object with a rewritten path_id.
2018-09-20 20:14:19 -07:00
Tim Abbott e2bd03365e import: Fix handling of recipient IDs for welcome bot.
If any user had sent the reply to the welcome bot recommended by our
tutorial, then the Zulip export/import process didn't work properly,
because we weren't including (and then remapping) the recipient ID for
sending PMs to the cross-realm bots.  This commit fixes that gap, by
recording the necessary data on the export side, and doing the
appropriate remapping on the import side.
2018-09-20 17:55:17 -07:00
Tim Abbott c9189439de import: Handle signup_notifications_stream_id.
Previously, our realm import logic only did the special remapping
logic for the original notifications_stream_id; when we added the new
signup_notifications_stream_id field, we neglected to handle it in the
same way.
2018-09-20 17:41:55 -07:00
Tim Abbott 165078b484 queue_processors: Fix bug in handling removed push notifications.
Apparently, we were falling through to the "add" case after correctly
processing the "remove" case, throwing a 500.
2018-09-20 17:36:54 -07:00
Rishi Gupta 7acd640f6a user docs: Update format-your-messages-using-markdown.
I used line-height: 22px and font-size: 16px in .message-content to take the
screenshots. Requires some additional fiddling for the LaTeX picture, inline
code block, and maybe a few others.
2018-09-19 17:09:28 -07:00
Rishi Gupta f2b4357d67 user docs: Remove link to #status-messages from left sidebar. 2018-09-18 14:48:17 -07:00
Rishi Gupta 74628ccfa6 user docs: Update at-mention-a-team-member. 2018-09-18 14:47:37 -07:00
Rishi Gupta 669c2fd752 user docs: Update verify-your-message-was-successfully-sent. 2018-09-18 14:47:33 -07:00
Eeshan Garg 0817905480 api docs: Use Markdown extension for tabbed sections. 2018-09-18 13:49:34 -07:00
Eeshan Garg 2443919a7e user docs: Use tabbed instructions on desktop-app-install-guide.
Note that the correct tab is automatically activated depending on
the user's OS.
2018-09-18 13:49:34 -07:00
Eeshan Garg ecd4f821be user docs: Automatically activate correct tab for OS-specific instructions. 2018-09-18 13:49:34 -07:00
Eeshan Garg 4c7762f696 user docs: Use tabbed instructions on logging-out. 2018-09-18 13:49:34 -07:00
Eeshan Garg 4f366daec0 markdown: Add extension for creating tabbed sections on /help and /api. 2018-09-18 13:49:34 -07:00
Akash Nimare 2385b3d1d3 notification: Add a space in narrow to message content.
We have a space for this kind of texts in other places but somehow we
missed this case. This PR fixes the same.
2018-09-17 13:58:29 -04:00
Eeshan Garg 1a3a791e0b rest-endpoints.md: Remove duplicate heading. 2018-09-17 13:28:30 -04:00
Rishi Gupta 976b5603ce user docs: Update enable-enter-to-send. 2018-09-16 18:03:10 -07:00
Rishi Gupta f56a76b53d user docs: Update manage-your-uploaded-files.
Eventually this should probably just be a document on deleting files.
2018-09-16 18:03:10 -07:00
Rishi Gupta 5b839a90ab user docs: Update upload-and-share-files. 2018-09-16 18:03:09 -07:00
Rishi Gupta 6557764373 user docs: Update preview-your-message-before-sending. 2018-09-16 18:03:09 -07:00
Rishi Gupta 5fcd96b8a1 user docs: Update add-emoji. 2018-09-16 18:03:09 -07:00
Rishi Gupta 0eba0dfdc8 user docs: Remove send-a-message-in-a-different-language.
A valiant effort, but there are too many operating systems to do this
well.
2018-09-16 18:01:18 -07:00
Rishi Gupta e46d3705de user docs: Remove several "send a message" docs.
These are now subsumed by compose-and-reply. Probably we'll want to write a
"PMs and Group PMs" doc at some point so that we have something if people
search for whether Zulip has Group PMs.
2018-09-16 15:04:05 -07:00
Rishi Gupta 7f2e428541 user docs: Add macro for opening the compose box. 2018-09-16 15:04:05 -07:00
Rishi Gupta 02be6c1530 user docs: Add compose-and-reply. 2018-09-16 14:54:42 -07:00
Rishi Gupta 957b4af81f user docs: Remove the-zulip-browser-window.
This is one of the earliest user docs we wrote (Jan 2017), and no longer
fits with our current docs strategy.
2018-09-16 10:33:39 -07:00
Rishi Gupta 556a8494c3 user docs: Add relative link to review-your-organization-settings. 2018-09-16 10:27:40 -07:00
Rishi Gupta 91c58987bf user docs: Update change-your-settings. 2018-09-16 10:26:40 -07:00
Rishi Gupta ed3500f1e2 user docs: Add related articles to view-the-markdown-source-of-a-message. 2018-09-16 10:13:43 -07:00
Rishi Gupta 0c481bab40 user docs: Update view-the-exact-time-a-message-was-sent. 2018-09-16 10:13:43 -07:00
Rishi Gupta 4fdd575a6b user docs: Update collapse-a-message. 2018-09-16 10:13:43 -07:00
Rishi Gupta 48fdeb2f97 user docs: Update star-a-message. 2018-09-16 10:13:43 -07:00
Rishi Gupta 404f4e3560 user docs: Update emoji-reactions. 2018-09-16 10:13:43 -07:00
Rishi Gupta cd57a8ede4 user docs: Update share-a-message-or-conversation. 2018-09-16 10:13:43 -07:00
Rishi Gupta 4c7bafd886 user docs: Remove the down-chevron macro. 2018-09-16 08:36:41 -07:00
Rishi Gupta 655820c13d user docs: Update the message-actions macro. 2018-09-16 08:36:41 -07:00
Rishi Gupta da759d60f8 user docs: Add the message-actions-menu macro. 2018-09-16 08:36:41 -07:00
Rishi Gupta 4000da687b user docs: Update view-a-messages-edit-history. 2018-09-16 08:36:41 -07:00
Rishi Gupta 7f1e159a45 user docs: Remove a few articles from Reading messages.
This content would be most useful in some sort of guide, perhaps an article
like "navigation and unread counts".
2018-09-16 08:24:28 -07:00