302da832fa
lint: Enforce whitespace between : and value in dicts.
2016-04-27 22:23:40 -07:00
8a278cbe3a
Switch to using a Zulip version of @login_required.
...
Currently the code is the unmodified Django upstream implementation;
this commit is preparation for modifying it.
2016-04-21 14:59:39 -07:00
9c56027627
lint: Add CSS lint rule for whitespace after {.
2016-04-20 11:50:01 -07:00
a46b5d7bbe
Add lint check for missing whitespace after =.
2016-04-20 11:37:03 -07:00
a72385246e
Fix missing whitespace after '=' in python/js code.
2016-04-20 11:36:14 -07:00
a2b59b8b51
lint: Check whitespace rules for txt files.
2016-04-14 14:36:29 -07:00
39950b8f4f
lint: Check whitespace rules in markdown files too.
2016-04-14 14:30:29 -07:00
2b76f6223e
Make 'no newline at end of file' lint error more actionable.
...
There's a handy sed command to fix this, so we might as well document
it.
2016-04-14 10:55:06 -07:00
e71d8bb4b6
lint-all: Require newlines at end of JSON files.
2016-04-14 10:49:12 -07:00
9584ae1ab8
Add CSS linter for missing space after : in rules.
2016-04-08 21:04:43 -07:00
209e6ef7a1
Run trailing whitespace linter on bash files.
2016-04-08 11:52:11 -07:00
caba24b2af
Fix existing trailing whitespace in bash scripts.
2016-04-08 11:52:11 -07:00
4fa63c29ca
Run whitespace linters on html files.
2016-04-08 11:52:11 -07:00
d670e902a9
Run whitespace linters on handlebars templates.
2016-04-08 11:52:11 -07:00
c6d01ab76b
Run whitespace linters on CSS files.
2016-04-08 11:47:10 -07:00
1b84617771
Don't skip running python custom linters inside comments.
...
This fixes an issue where we weren't checking for trailing whitespace
in comments.
2016-04-08 11:47:10 -07:00
14b5e265c2
Remove unuseful suspicious code lint check.
2016-04-08 11:47:10 -07:00
efd14e7ad9
Revert "Exclude 'from typing import *' from linter."
...
This reverts commit d936bf61f9
2016-04-07 14:12:18 -07:00
78e289f904
Exclude puppet-common tests from puppet linter.
2016-04-04 17:08:29 -07:00
81fdeae0ea
Remove '.'s from extensions in lister.py interface and lint-all.
...
In lint-all, change occurences of '.py', '.js', ... to 'py', 'js', ....
2016-04-01 15:27:16 -07:00
ad4c20a3e6
Migrate lint-all to lister.py for getting files.
...
This has the side effect of making lint-all check all shell scripts,
not just those under scripts/, tools/, and bin/.
[commit message expanded by tabbott]
2016-04-01 15:24:43 -07:00
d936bf61f9
Exclude 'from typing import *' from linter.
2016-03-30 21:50:31 -07:00
f9222de83e
Auto-load commonly used modules in manage.py shell.
...
This automatically loads settings, zerver.models.* and
zerver.lib.actions.* when you start `manage.py shell`, which should
save a bit of time basically every time someone uses it.
Fixes #275 .
2016-03-19 11:32:49 -07:00
72033069ed
Extend lint-all to check for newlines at the end of files.
2016-03-17 23:03:56 -07:00
3a46bae542
Fix shell script list computation to exclude files not in git.
...
This fixes an issue where the next commit's no-newline-and-end-of-file
check was incorrectly firing on tools/phantomjs.
2016-03-17 23:03:56 -07:00
aa505b0d55
Apply Python 3 futurize transform libmodernize.fixes.fix_map
...
Refer to #256
2016-03-10 22:03:44 -08:00
def027a1ec
Apply Python 3 futurize transform libmodernize.fixes.fix_filter
...
Refer to #256
2016-03-10 22:03:06 -08:00
c59185e119
Apply Python 3 futurize transform libfuturize.fixes.fix_print_with_import
...
Refer #256
2016-03-10 22:02:17 -08:00
aad3bff193
Harden style rule for % comprehensions and fix existing errors.
2016-02-02 23:08:19 -08:00
700055c194
Apply modernize transform libmodernize.fixes.fix_file.
...
This replaces use of file() with open() which is python 3 compatible,
and also adds it to our python 3 support test suite.
2016-01-26 21:09:42 -08:00
df4d1b3c14
Add linting code for detecting shebang bashisms.
...
This will prevent regressions in OpenBSD compatibility, since OpenBSD
doesn't support passing arguments in the #! line.
2016-01-21 22:33:55 -08:00
0fe819eb57
lint: Tighten lint rules around whitespace around '%' comprehensions.
2015-12-05 15:29:42 -08:00
69b6b60017
lint: Clean up whitespace_rules.
...
Several of these rules only apply to one of Python and Javascript, and
this simplifies the logic and should make our linter code more readable.
In the process, we add support for per-rule/file pair exclusions to
handle the tab exception for codehilite.py.
2015-12-05 15:29:42 -08:00
a712954c59
lint: Rewrite custom checks to use a more consistent framework.
2015-12-05 15:29:42 -08:00
8a18e78a65
Add lint rules checking for our % comprehension style.
2015-12-05 15:29:42 -08:00
b81ecc4064
Add whitespace lint rules checking for missing spaces before {.
2015-11-10 10:06:47 -08:00
f1074aa491
Move frontend tests out of zerver/tests/.
...
This fixes an unfortunate bug where the backend tests in
zerver/tests.py were not being run automatically, and also makes these
a bit easier to find.
2015-10-28 10:11:47 -07:00
d5435fad1d
Consistently use /usr/bin/env python2.7 in shebangs and commands.
2015-10-21 22:58:21 +00:00
232de3015a
Add lint checks for tab-based whitespace.
...
We exclude the one file we have with issues that comes from a
third-party vendor.
(imported from commit 47e097b39440aea8e4d7468892176ffce4818b5f)
2015-09-19 23:23:02 -07:00
c25d9679a5
Utility for unescaping HTML entities leftover from MediaWiki->rST conversion
...
(imported from commit 2f2507f299c3d09c67bfd26d6c11fab47431d935)
2015-08-18 17:31:33 -07:00
1136d399ca
Add a check for blueslip.warning to perform_extra_js_checks
...
(imported from commit 92872542c4a97c31d7864137b759abb8bf26a551)
2014-02-05 10:43:55 -05:00
de522029d5
Switch to DiscoverRunner from DjangoTestSuiteRunner
...
(imported from commit 77dd694b20509bfdc7327186e0524d686f0415f7)
2014-01-29 11:34:31 -05:00
582f7eb24d
Extract test_hooks.py.
...
These classes are in test_hooks.py now. They still run as part of
the regular suite, so this is just to make it easier to navigate the
files.
JiraHookTests
BeanstalkHookTests
GithubV1HookTests
GithubV2HookTests
PivotalV3HookTests
PivotalV5HookTests
NewRelicHookTests
StashHookTests
FreshdeskHookTests
ZenDeskHookTests
(imported from commit 26a9572dd5170f9516e739d587a119bd1f87959a)
2014-01-29 10:56:00 -05:00
a8825e1c5d
Fix linting for zerver/lib/tornado_ioloop_logging.py with older pyflakes.
...
(imported from commit 998d95df05acdc610336bf6da48fafd8c129e52e)
2014-01-14 11:43:06 -05:00
ea49e9d1b0
Rename check-handlebar-templates to check-templates.
...
(It's been checking Django templates too.)
(imported from commit e1a92210d07dfd68666a8c93642c4eb8d5ff081f)
2013-12-17 12:44:59 -05:00
1fb9c09f02
Don't import bugdown in models.py headings.
...
This allows us to avoid a circular import when importing models.py
from inside bugdown for the realm-filters-from-database branch.
(imported from commit 7de85b54243132ade6818b080abdc8c5e8ad84f5)
2013-12-11 14:39:09 -05:00
5ada0ab93e
Exclude git_p4 from the linter, not our code.
...
(imported from commit 221a7947f1679dde888198f6d1da2d5bdf8f6ba4)
2013-12-06 11:54:38 -05:00
3e51ac2f3d
Add -m to lint-all to check modified files.
...
This uses git ls-files -m, which will show modified and added files,
but it doesn't seem to show staged files, so buyer beware.
(imported from commit 6ecc1d5ee628deae17197addf5586f1f6bcd4b9c)
2013-12-02 16:14:06 -05:00
72e2fbd725
Allow specific files to be checked by lint-all.
...
(imported from commit a17800e3ab079e95033243bc82446737dc456b68)
2013-12-02 16:14:06 -05:00
95320b7369
DRY up forking code in lint-all.
...
(imported from commit f4c52596c9e9cf0a1be5d4bea26f9793c67f93d5)
2013-12-02 16:14:06 -05:00
Tim Abbott
Eklavya Sharma
Varshit
Vladislav Manchev
Steven Oud
Tim Abbott
Yoyo Zhou
Jason Michalski
Steve Howell
Luke Faraone