a9235a74f4
Split the group merging logic form the DOM update logic
...
The goal is to have a more data centric piece that can be unit tested.
We also try to minimise the number of one off jQuery DOM updates and
rerender handlebars fragments instead. This will prevent the
message_group and DOM from drifting apart and not being able to rerender
correctly.
(imported from commit 03f09803f2bc0c3b8187f76f2cfe90be9f7512a3)
2014-03-14 20:48:59 -04:00
4f6ee6744d
Split out group creation from rendering
...
To make the rendering process a bit simpler to read this commit is
refactoring the message group creation into its own function.
(imported from commit b53ce96ed8fee3064d7cf891fc248d0c3d821d1a)
2014-03-14 20:48:59 -04:00
16faed0a83
Create copy_and_paste.js (with code from ui.js).
...
(imported from commit 37a06af5489e7da5196e5710f384d1f5a7ee7578)
2014-03-14 20:48:59 -04:00
fa440d0be2
Only empty the message list DOM on reload
...
We are seeing error on CUSTOMER4 when clearing the DOM on reload. So
now we will only clear the message list.
(imported from commit f5d8d7d36cd1018f7def73ff9eda414387fcec5c)
2014-03-14 20:48:58 -04:00
c5993c2d2d
Create gear_menu.js (with code from ui.js).
...
(imported from commit fc4d058d49d5d4aaaa20ef6237ea3e927eac03e3)
2014-03-14 20:48:58 -04:00
405c3d7626
Created floating_recipient_bar.js (with code from ui.js).
...
(imported from commit 2b6631938b0fc8e39c14aacd92f9f1670b68b199)
2014-03-14 20:48:58 -04:00
f8b71fa497
Created condense.js (with code taken from ui.js).
...
(imported from commit 72b27b48614a7c396170d46936646e52757e2743)
2014-03-14 20:48:58 -04:00
af3411cab8
Handle removing the selected local message from the message list
...
(imported from commit 185fc33cc19699ebe61ce9d65262383e39289cf3)
2014-03-14 20:48:57 -04:00
9162ef3e0f
Fix wrong logic in handling local-only message edit saves
...
(imported from commit a9074fbfb75884c3280807ddeba576c0fbe313b7)
2014-03-14 20:48:57 -04:00
bba2eb7622
Send missedmessage notifications as soon as you're idle or offline
...
Previously, you'd have to be offline to recieve missedmessage
notifications, or maybe idle for an hour. However, I'm pretty sure the
latter code didn't actually work, so we scrap that and just nofity you
via email or push as soon as you're idle.
Closes trac #2350
(imported from commit 899966e0514db575b9640a96865639201824b579)
2014-03-14 20:48:57 -04:00
5bb4a74ec0
Don't log warnings about various known-unsupported Pivotal event types.
...
(imported from commit e2044e06c02bc745608fe637ce44d683c5badcd8)
2014-03-14 20:48:57 -04:00
6850835273
Improve handling of unknown JIRA event types.
...
(imported from commit d9f823dc80b26a71f7b3a891559d2360d76a258f)
2014-03-14 20:48:56 -04:00
9aa3de0664
Fix GitHub tracebacks from issue['pull_request'] not existing.
...
(imported from commit f124a8e30e25d9321e9abe2fe04a5bd35ce24445)
2014-03-14 20:48:56 -04:00
400e355a2f
Fix passing string as user_profile to upload_message_image.
...
(imported from commit b4841ef30527da6856482899d2e709cd528ff181)
2014-03-14 20:48:56 -04:00
84b59d4335
Created scroll_bar.js (with code taken from ui.js).
...
(imported from commit 0c4e8538031ceb1a0f50eea9a34e315e23e7d9ff)
2014-03-14 20:48:56 -04:00
be2a1c2893
Move resizing code to resize.js.
...
(imported from commit b6df0007307872751e1a4200af740076e08b5c11)
2014-03-14 20:48:55 -04:00
f760567b96
Fix topic edits that are initiated from the FRB.
...
Grab the id of the selected row, whether it's a message, recipient bar, or FRB
(imported from commit 93b9c282d4220ba9bb271733ded4d90d5c051c75)
2014-03-14 20:48:55 -04:00
7fce920522
Move favicon-related functions to favicon.js
...
util.reset_favicon -> favicon.reset
util.set_favicon -> favicon.set
(imported from commit 250848ec5dc7ac58649197c8cc4b7b4e7b19f25c)
2014-03-14 20:48:55 -04:00
77e7947f61
Add test_random_int()
...
(imported from commit 67ab9436463b3b4ff63f657fd8cd60cdd25f6047)
2014-03-14 20:48:55 -04:00
23e791a3b9
Enhance test_array_compare().
...
(imported from commit c6d44acd2804005a41afe6b283e11905b7e4c7c0)
2014-03-14 20:48:54 -04:00
a8d61fa930
Add test_normalize_recipients.
...
(imported from commit 9645cb471f8db01e810c9b6c396313ee4c1cf97f)
2014-03-14 20:48:54 -04:00
d52e5e551d
Remove {show,destroy}_first_run_message.
...
We essentially inlined the methods in the three places they
were called.
(imported from commit 622ee718d6dd226187f1e37ff754ee2fa635e6f2)
2014-03-14 20:48:54 -04:00
84fc8f16dd
Add test coverage for util.same_major_recipient.
...
(imported from commit 0b345679d2bf40c82167ded9968dd653823011bf)
2014-03-14 20:48:54 -04:00
b12b44579c
Set up $.fn.expectOne in setup.js
...
(imported from commit 77922cf8f506d4eb811498d418215eabf74b76ae)
2014-03-14 20:48:53 -04:00
91e83731f0
Promote setup.js in the list of JS files.
...
I don't think this matters a ton, but there's no reason for
the two muting files to come before setup.js.
(imported from commit c18231b633fba6acccaf5bc180c7605f7591462e)
2014-03-14 20:48:53 -04:00
3889edd824
Move xhr_error_message() into channel.js
...
(imported from commit c68c2d475b5673a3dd5f68c75624dfcfe56728ca)
2014-03-14 20:48:53 -04:00
0e129614cf
Remove unused util.recipient_key() function.
...
(imported from commit cee6a58344971ee1439e6b66ec301f1bd0f80502)
2014-03-14 20:48:53 -04:00
50bc5401a4
Moved loading_indicator functions to loading.js.
...
util.make_loading_indicator -> loading.make_indicator
util.destroy_loading_indicator -> loading.destroy_indicator
(imported from commit 8a171622a6096476dd040912d3f1460d53159f20)
2014-03-14 20:48:52 -04:00
a1538b4bab
Eliminate gap at bottom of portico pages.
...
(imported from commit 0e1d9bde16267f9b6533f256c28374ed98566578)
2014-03-14 20:48:52 -04:00
c09b6914ba
Use new background image for /hello.
...
(imported from commit 06174760ee28a4c6b323f5c7e66cb20a50709d2a)
2014-03-14 20:48:52 -04:00
86ff8cdd8c
Add San Francisco image to repository.
...
This is a public domain work.
Source: http://www.flickr.com/photos/allenr/13127238845/in/photostream/
(imported from commit 90f7e79131302a9da2323125ca27f78d5ac79a78)
2014-03-14 20:48:52 -04:00
9cefe46a1f
Change /features icon color to match header.
...
(imported from commit d9cabd13acd8981a5bef93011ae4ea0c45cb451b)
2014-03-14 20:48:51 -04:00
202ac0fe10
Restyle /hello to be more consistent with current app style.
...
(imported from commit 7e1df8cb885908f40569692283e98ac851ca3d2e)
2014-03-14 20:48:51 -04:00
4eded59dbe
Revert "signup: point to /register at the top too."
...
This reverts commit 517df29d10182c05780017c15225c9f95b844225.
(imported from commit 7820bb2dad7010579342450040d0f5c72ad2c627)
2014-03-14 20:48:51 -04:00
c832543168
Remove very confusing dom_id message attribute
...
(imported from commit c7e3e50bf8827f6f087d7df28ec7b7c173a3c041)
2014-03-14 20:48:51 -04:00
ef81999f3f
Make sure to store raw DOM elements, not jQuery objects, in _rows
...
(imported from commit ccf85bfd514b5b143c1021d4a186f1448abc700d)
2014-03-14 20:48:50 -04:00
163d93c15b
Move timestamp up when sender is included
...
(imported from commit a347b397a41028f3ca9642ad1edd704e3255245a)
2014-03-14 20:48:50 -04:00
6d2c6f269d
Make sure to use the proper dom_id in the proper places
...
(imported from commit c4852f972d4fe8b2732c87dcc499f91f837e912c)
2014-03-14 20:48:50 -04:00
8f7542f34d
Use elem.html() instead of elem.replaceWith() when swapping in new rendered messages
...
(imported from commit 82664bf2eb20faa8e98b7912b4c26174046d2dd6)
2014-03-14 20:48:50 -04:00
8b1f0223fe
Update the dom_id of message objects when their id changes
...
(imported from commit e766eff7d966d95616ac192c8cb0cb328bd96b1b)
2014-03-14 20:48:50 -04:00
7f3ea34dc5
Make sure to re-select selected after re-ordering
...
(imported from commit 50878874372d1304014f5285b488db6ab896abbd)
2014-03-14 20:48:49 -04:00
26690adc47
Save the correct-from-dom rerendered message in _rows when rerendering
...
(imported from commit c021beef3106148a6d085ca16f34a1c4bb4fc7af)
2014-03-14 20:48:49 -04:00
1c06e37245
[puppet] Change digest email send time by 1 hour for daylight savings.
...
(imported from commit 8ac1747f15e10b850f73ce28ea4579bee62ba1a4)
2014-03-14 20:48:49 -04:00
e7c8c322c0
Handle case where _lower_bound returns size of input list
...
(imported from commit bd91512615b11935eafd5809ca414eeb0cf189c4)
2014-03-14 20:48:49 -04:00
fa1333c026
integrations: make Codebase dependency on python-dateutil explicit.
...
requests is already required generally by the API bindings.
(imported from commit 216c7031def710aac415cca755dbe2454514decb)
2014-03-14 20:48:48 -04:00
fa461e86fd
integrations: make Asana dependency on python-dateutil explicit.
...
(imported from commit 354b42f68e3d1f980649993bad4dbe4ff79a11d6)
2014-03-14 20:48:48 -04:00
3dc9ee182f
Add test for people.reify()
...
(imported from commit 3ad061ba52c1fd7fa2c2a053e91de87117370dd6)
2014-03-14 20:48:48 -04:00
6ec72a290d
Simplify condition for aborting people.reify().
...
Since it's basically impossible to add a person with an
undefined full_name--even "skeleton" people--there is no
need to check the full_name field to short circuit reify(),
because it will always be defined.
(imported from commit 3a30cfd583a040f7460739abea1604594c450ffe)
2014-03-14 20:48:47 -04:00
cbb5878477
Test people.remove() only removes one person.
...
(imported from commit 7cd21cd9e4b99d0542bf81737a1c16a346ecc37e)
2014-03-14 20:48:47 -04:00
065fcf1a1b
Handle out-of-order local ids in message_list
...
(imported from commit e805837d7d2790be90490cc9ec9415882ff9b549)
2014-03-14 20:48:47 -04:00
Jason Michalski
Steve Howell
Leo Franchi
Luke Faraone
Tim Abbott
Waseem Daher
Allen Rabinovich
Jessica McKellar